From cd077513f267e43ce4b659eb18a1734d8a369992 Mon Sep 17 00:00:00 2001 From: Patrick Griffis Date: Wed, 5 Feb 2025 14:03:05 -0600 Subject: [PATCH] auth-digest: Handle missing nonce --- libsoup/auth/soup-auth-digest.c | 2 +- tests/auth-test.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libsoup/auth/soup-auth-digest.c b/libsoup/auth/soup-auth-digest.c index 9eb7fa0e..d69a4013 100644 --- a/libsoup/auth/soup-auth-digest.c +++ b/libsoup/auth/soup-auth-digest.c @@ -162,7 +162,7 @@ soup_auth_digest_update (SoupAuth *auth, SoupMessage *msg, guint qop_options; gboolean ok = TRUE; - if (!soup_auth_get_realm (auth)) + if (!soup_auth_get_realm (auth) || !g_hash_table_contains (auth_params, "nonce")) return FALSE; g_free (priv->domain); diff --git a/tests/auth-test.c b/tests/auth-test.c index c651c7cd..484097f1 100644 --- a/tests/auth-test.c +++ b/tests/auth-test.c @@ -1952,6 +1952,7 @@ main (int argc, char **argv) g_test_add_data_func ("/auth/missing-params/realm", "Digest qop=\"auth\"", do_missing_params_test); g_test_add_data_func ("/auth/missing-params/nonce", "Digest realm=\"auth-test\", qop=\"auth,auth-int\", opaque=\"5ccc069c403ebaf9f0171e9517f40e41\"", do_missing_params_test); g_test_add_data_func ("/auth/missing-params/nonce-md5-sess", "Digest realm=\"auth-test\", qop=\"auth,auth-int\", opaque=\"5ccc069c403ebaf9f0171e9517f40e41\" algorithm=\"MD5-sess\"", do_missing_params_test); + g_test_add_data_func ("/auth/missing-params/nonce-and-qop", "Digest realm=\"auth-test\"", do_missing_params_test); ret = g_test_run (); -- GitLab