OBS-URL: https://build.opensuse.org/package/show/science:GPU:ROCm/hiprand?expand=0&rev=9

Hip wrapper for rocRAND

OBS-URL: https://build.opensuse.org/request/show/1243186
OBS-URL: https://build.opensuse.org/package/show/science:GPU:ROCm/hiprand?expand=0&rev=1

hipRAND-6.2.1.tar.gz

@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:0d4585b8adbc299f3fdc2c74bb20ffd4285027b861a759c3e62ce564589465da
-size 125256

hipRAND-6.3.0.tar.gz

@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:7464c1e48f4e1a97a5e5978146641971d068886038810876b60acb5dfb6c4d39
-size 125500

hiprand.spec

@@ -1,6 +1,12 @@
+%if 0%{?suse_version}
+%global hiprand_name libhiprand1
+%else
+%global hiprand_name hiprand
+%endif
+
 %global upstreamname hipRAND
 
-%global rocm_release 6.3
+%global rocm_release 6.4
 %global rocm_patch 0
 %global rocm_version %{rocm_release}.%{rocm_patch}
 
@@ -8,9 +14,6 @@
 # hipcc does not support some clang flags
 %global build_cxxflags %(echo %{optflags} | sed -e 's/-fstack-protector-strong/-Xarch_host -fstack-protector-strong/' -e 's/-fcf-protection/-Xarch_host -fcf-protection/')
 
-# $gpu will be evaluated in the loops below
-%global _vpath_builddir %{_vendor}-%{_target_os}-build-${gpu}
-
 %bcond_with debug
 %if %{with debug}
 %global build_type DEBUG
@@ -26,20 +29,23 @@
 %global build_test OFF
 %endif
 
+# Option to test suite for testing on real HW:
+%bcond_with check
+# For docs
 %bcond_with doc
 
 # Compression type and level for source/binary package payloads.
 #  "w7T0.xzdio"	xz level 7 using %%{getncpus} threads
-%define _source_payload	w7T0.xzdio
-%define _binary_payload	w7T0.xzdio
+%global _source_payload w7T0.xzdio
+%global _binary_payload w7T0.xzdio
 
-Name:           hiprand
+Name:           %{hiprand_name}
 Version:        %{rocm_version}
 Release:        4%{?dist}
 Summary:        HIP random number generator
 
 Url:            https://github.com/ROCm/%{upstreamname}
-License:        MIT and BSD
+License:        MIT AND BSD-3-Clause
 Source0:        %{url}/archive/rocm-%{version}.tar.gz#/%{upstreamname}-%{version}.tar.gz
 
 BuildRequires:  cmake
@@ -53,13 +59,19 @@ BuildRequires:  rocm-runtime-devel
 BuildRequires:  rocrand-devel
 
 %if %{with test}
+%if 0%{?suse_version}
+BuildRequires:  gtest
+%else
 BuildRequires:  gtest-devel
 %endif
+%endif
 
 %if %{with doc}
 BuildRequires:  doxygen
 %endif
 
+Provides:       hiprand = %{version}-%{release}
+
 # Only x86_64 works right now:
 ExclusiveArch:  x86_64
 
@@ -70,10 +82,14 @@ into the backend and results back to the application. hipRAND exports an
 interface that does not require the client to change, regardless of the chosen
 backend. Currently, hipRAND supports either rocRAND or cuRAND.
 
+%post -p /sbin/ldconfig
+%postun -p /sbin/ldconfig
+
 %package devel
 Summary:        The hipRAND development package
 Requires:       %{name}%{?_isa} = %{version}-%{release}
 Requires:       rocrand-devel
+Provides:       hiprand-devel = %{version}-%{release}
 
 %description devel
 The hipRAND development package.
@@ -93,45 +109,34 @@ Requires:       %{name}%{?_isa} = %{version}-%{release}
 #Remove RPATH:
 sed -i '/INSTALL_RPATH/d' CMakeLists.txt
 
+# On Tumbleweed Q2,2025
+# /usr/include/gtest/internal/gtest-port.h:279:2: error: C++ versions less than C++14 are not supported.
+#   279 | #error C++ versions less than C++14 are not supported.
+# https://github.com/ROCm/hipRAND/issues/222
+# Convert the c++11's to c++14
+sed -i -e 's@set(CMAKE_CXX_STANDARD 11)@set(CMAKE_CXX_STANDARD 14)@' {,test/package/}CMakeLists.txt
+
 %build
-for gpu in %{rocm_gpu_list}
-do
-    module load rocm/$gpu
 
-    %cmake \
-	-DCMAKE_CXX_COMPILER=hipcc \
-	-DCMAKE_C_COMPILER=hipcc \
-	-DCMAKE_LINKER=%rocmllvm_bindir/ld.lld \
-	-DCMAKE_AR=%rocmllvm_bindir/llvm-ar \
-	-DCMAKE_RANLIB=%rocmllvm_bindir/llvm-ranlib \
-           -DCMAKE_BUILD_TYPE=%{build_type} \
-           -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \
-           -DCMAKE_SKIP_RPATH=ON \
-           -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \
-           -DAMDGPU_TARGETS=${ROCM_GPUS} \
-           -DCMAKE_INSTALL_LIBDIR=$ROCM_LIB \
-           -DCMAKE_INSTALL_BINDIR=$ROCM_BIN \
-           -DBUILD_TEST=%{build_test} \
-           -DROCM_SYMLINK_LIBS=OFF
+%cmake \
+    -DCMAKE_CXX_COMPILER=hipcc \
+    -DCMAKE_C_COMPILER=hipcc \
+    -DCMAKE_LINKER=%rocmllvm_bindir/ld.lld \
+    -DCMAKE_AR=%rocmllvm_bindir/llvm-ar \
+    -DCMAKE_RANLIB=%rocmllvm_bindir/llvm-ranlib \
+    -DCMAKE_BUILD_TYPE=%{build_type} \
+    -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \
+    -DCMAKE_SKIP_RPATH=ON \
+    -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \
+    -DAMDGPU_TARGETS=%{rocm_gpu_list_default} \
+    -DCMAKE_INSTALL_LIBDIR=%_libdir \
+    -DBUILD_TEST=%{build_test} \
+    -DROCM_SYMLINK_LIBS=OFF
 
-           %cmake_build
-    module purge
-done
+%cmake_build
 
 %install
-for gpu in %{rocm_gpu_list}
-do
-    %cmake_install
-done
-
-echo s@%{buildroot}@@ > br.sed
-find %{buildroot}%{_libdir} -name '*.so.*.[0-9]' | sed -f br.sed >  %{name}.files
-find %{buildroot}%{_libdir} -name '*.so.[0-9]'   | sed -f br.sed >> %{name}.files
-find %{buildroot}%{_libdir} -name '*.so'         | sed -f br.sed >  %{name}.devel
-find %{buildroot}%{_libdir} -name '*.cmake'      | sed -f br.sed >> %{name}.devel
-%if %{with test}
-find %{buildroot}           -name 'test_*'       | sed -f br.sed >  %{name}.test
-%endif
+%cmake_install
 
 if [ -f %{buildroot}%{_prefix}/share/doc/hiprand/LICENSE.txt ]; then
     rm %{buildroot}%{_prefix}/share/doc/hiprand/LICENSE.txt
@@ -140,20 +145,55 @@ if [ -f %{buildroot}%{_prefix}/bin/hipRAND/CTestTestfile.cmake ]; then
     rm %{buildroot}%{_prefix}/bin/hipRAND/CTestTestfile.cmake
 fi
 
-%files -f %{name}.files
+%check
+%if %{with test}
+%if %{with check}
+%if 0%{?suse_version}
+export LD_LIBRARY_PATH=$PWD/build/library:$LD_LIBRARY_PATH
+%endif
+
+%ctest
+%endif
+%endif
+
+%files
 %doc README.md
 %license LICENSE.txt
+%{_libdir}/libhiprand.so.1{,.*}
 
-%files devel -f %{name}.devel
-%dir %{_libdir}/cmake/%{name}
-%dir %{_includedir}/%{name}
-%{_includedir}/%{name}/*
+%files devel
+%dir %{_libdir}/cmake/hiprand
+%dir %{_includedir}/hiprand
+%{_includedir}/hiprand/*
+%{_libdir}/libhiprand.so
+%{_libdir}/cmake/hiprand/*.cmake
 
 %if %{with test}
-%files test -f %{name}.test
+%files test
+%{_bindir}/test*
 %endif
 
 %changelog
+* Mon Jun 16 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-4
+- Remove suse check of ldconfig
+
+* Mon May 12 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-3
+- Cleanup module build
+
+* Sun Apr 27 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-2
+- Improve testing on suse
+
+* Sat Apr 19 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-1
+- Update to 6.4.0
+
+* Fri Apr 4 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-6
+- Use correct spdx license
+- cleanup
+
+* Tue Feb 11 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-5
+- Remove split building
+- Fix SLE 15.6
+
 * Mon Jan 20 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-4
 - multithread compress