OBS-URL: https://build.opensuse.org/package/show/science:GPU:ROCm/rocfft?expand=0&rev=13

rocFFT-rocm-6.3.0.tar.gz

@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:afc716c95d1c80097f7a965e0c3cf1fe246c9fdf10a8fd9a303202156bd3811d
-size 1386056

rocfft.spec

@@ -6,21 +6,15 @@
 
 %global upstreamname rocFFT
 
-%global rocm_release 6.3
+%global rocm_release 6.4
 %global rocm_patch 0
 %global rocm_version %{rocm_release}.%{rocm_patch}
 
-# rocFFT has a version seperate from the ROCm version that it is released with
-%global rocfft_version 1.0.31
-
 %global toolchain rocm
 
 # hipcc does not support some clang flags
 %global build_cxxflags %(echo %{optflags} | sed -e 's/-fstack-protector-strong/-Xarch_host -fstack-protector-strong/' -e 's/-fcf-protection/-Xarch_host-fcf-protection/')
 
-# $gpu will be evaluated in the loops below
-%global _vpath_builddir %{_vendor}-%{_target_os}-build-${gpu}
-
 %bcond_with debug
 %if %{with debug}
 %global build_type DEBUG
@@ -28,6 +22,8 @@
 %global build_type RelWithDebInfo
 %endif
 
+# kernel oops on gfx1201
+# https://github.com/ROCm/rocFFT/issues/560
 %bcond_with test
 %if %{with test}
 # Disable rpatch checks for a local build
@@ -37,13 +33,68 @@
 %global build_test OFF
 %endif
 
+# Option to test suite for testing on real HW:
+# May have to set gpu under test with
+# export HIP_VISIBLE_DEVICES=<num> - 0, 1 etc.
+%bcond_with check
+
 # For docs
 %bcond_with doc
 
 # Compression type and level for source/binary package payloads.
 #  "w7T0.xzdio"	xz level 7 using %%{getncpus} threads
-%define _source_payload	w7T0.xzdio
-%define _binary_payload	w7T0.xzdio
+%global _source_payload w7T0.xzdio
+%global _binary_payload w7T0.xzdio
+
+# Use rocm-llvm strip
+%global __strip %rocmllvm_bindir/llvm-strip
+
+# Use ninja if it is available
+%if 0%{?fedora} || 0%{?suse_version}
+%bcond_without ninja
+%else
+%bcond_with ninja
+%endif
+
+%if %{with ninja}
+%global cmake_generator -G Ninja
+%else
+%global cmake_generator %{nil}
+%endif
+
+%global cmake_config \\\
+  -DCMAKE_CXX_COMPILER=hipcc \\\
+  -DCMAKE_CXX_FLAGS="--rtlib=compiler-rt --unwindlib=libgcc" \\\
+  -DCMAKE_C_COMPILER=hipcc \\\
+  -DCMAKE_LINKER=%rocmllvm_bindir/ld.lld \\\
+  -DCMAKE_AR=%rocmllvm_bindir/llvm-ar \\\
+  -DCMAKE_RANLIB=%rocmllvm_bindir/llvm-ranlib \\\
+  -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \\\
+  -DBUILD_CLIENTS_TESTS_OPENMP=OFF \\\
+  -DBUILD_CLIENTS_TESTS=%{build_test} \\\
+  -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \\\
+  -DCMAKE_BUILD_TYPE=%{build_type} \\\
+  -DROCFFT_BUILD_OFFLINE_TUNER=OFF \\\
+  -DROCFFT_KERNEL_CACHE_ENABLE=OFF \\\
+  -DROCM_SYMLINK_LIBS=OFF \\\
+  -DSQLITE_USE_SYSTEM_PACKAGE=ON
+
+%bcond_with generic
+%global rocm_gpu_list_generic "gfx9-generic;gfx9-4-generic;gfx10-1-generic;gfx10-3-generic;gfx11-generic;gfx12-generic"
+%if %{with generic}
+%global gpu_list %{rocm_gpu_list_generic}
+%else
+%global gpu_list %{rocm_gpu_list_default}
+%endif
+
+# gfx950 is an experimental target
+# Enabling will short circuit the normal build.
+# There is no check support.
+# To use do
+# $ module load rocm/gfx950
+#     <do stuff>
+# $ module purge
+%bcond_with gfx950
 
 Name:           %{rocfft_name}
 Version:        %{rocm_version}
@@ -66,22 +117,38 @@ BuildRequires:  rocm-runtime-devel
 BuildRequires:  rocm-rpm-macros
 
 %if %{with test}
-BuildRequires:  gtest-devel
 BuildRequires:  rocrand-devel
 BuildRequires:  fftw-devel
 BuildRequires:  boost-devel
 BuildRequires:  hipcc-libomp-devel
 BuildRequires:  hiprand-devel
 
+%if 0%{?suse_version}
+BuildRequires:  gtest
+%else
+BuildRequires:  gtest-devel
+%endif
+
 # rocfft-test compiles some things and requires rocm-hip-devel
 Requires:  rocm-hip-devel
+
 %endif
 
 %if %{with doc}
 BuildRequires:  python3-sphinx
 %endif
 
-Requires:       rocm-rpm-macros-modules
+%if %{with ninja}
+%if 0%{?fedora}
+BuildRequires:  ninja-build
+%endif
+%if 0%{?suse_version}
+BuildRequires:  ninja
+%define __builder ninja
+%endif
+%endif
+
+Provides:       rocfft = %{version}-%{release}
 
 # Only x86_64 works right now:
 ExclusiveArch:  x86_64
@@ -99,6 +166,8 @@ A library for computing Fast Fourier Transforms (FFT), part of ROCm.
 %package devel
 Summary:        The rocFFT development package
 Requires:       %{name}%{?_isa} = %{version}-%{release}
+Provides:       rocfft-devel = %{version}-%{release}
+Requires:       rocm-hip-devel
 
 %description devel
 The rocFFT development package.
@@ -112,9 +181,42 @@ Requires:       %{name}%{?_isa} = %{version}-%{release}
 %{summary}
 %endif
 
+%if %{with gfx950}
+
+%package gfx950
+Summary:        The gfx950 rocFFT package
+Provides:       rocfft-gfx950 = %{version}-%{release}
+Conflicts:      %{name}
+
+%description gfx950
+%{summary}
+
+%package gfx950-devel
+Summary:        The gfx950 rocFFT development package
+Requires:       %{name}-gfx950%{?_isa} = %{version}-%{release}
+Provides:       rocfft-gfx950-devel = %{version}-%{release}
+Conflicts:      %{name}-devel
+
+%description gfx950-devel
+%{summary}
+
+%if %{with test}
+%package gfx950-test
+Summary:        The gfx950 rocFFT test package
+Requires:       %{name}-gfx950%{?_isa} = %{version}-%{release}
+Conflicts:      %{name}-test
+
+%description gfx950-test
+%{summary}
+
+%endif # gfx950-test
+%endif # gfx950
+
 %prep
 %autosetup -n %{upstreamname}-rocm-%{version} -p 1
 
+# Do not care so much about the sqlite version
+sed -i -e 's@SQLite3 3.36 @SQLite3 @' cmake/sqlite.cmake
 
 %build
 
@@ -123,64 +225,129 @@ export LDFLAGS="${LDFLAGS} -pie"
 
 # OpenMP tests are disabled because upstream sets rpath in that case without
 # a way to skip
+#
+# RHEL 9 has an issue with missing symbol __truncsfhf2 in libgcc.
+# So switch from libgcc to rocm-llvm's libclang-rt.builtins with
+# the rtlib=compiler-rt. Leave unwind unchange with unwindlib=libgcc
 
-%cmake \
-    -DCMAKE_CXX_COMPILER=hipcc \
-    -DCMAKE_C_COMPILER=hipcc \
-    -DCMAKE_LINKER=%rocmllvm_bindir/ld.lld \
-    -DCMAKE_AR=%rocmllvm_bindir/llvm-ar \
-    -DCMAKE_RANLIB=%rocmllvm_bindir/llvm-ranlib \
-    -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \
-    -DAMDGPU_TARGETS=%{rocm_gpu_list_default} \
-    -DCMAKE_INSTALL_LIBDIR=%_libdir \
-    -DBUILD_CLIENTS_TESTS_OPENMP=OFF \
-    -DBUILD_CLIENTS_TESTS=%{build_test} \
-    -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \
-    -DCMAKE_BUILD_TYPE=%{build_type} \
-    -DROCFFT_BUILD_OFFLINE_TUNER=OFF \
-    -DROCFFT_KERNEL_CACHE_ENABLE=OFF \
-    -DROCM_SYMLINK_LIBS=OFF \
-    -DSQLITE_USE_SYSTEM_PACKAGE=ON
+%if %{with gfx950}
+
+module load rocm/gfx950
+
+%cmake %{cmake_generator} %{cmake_config} \
+    -DAMDGPU_TARGETS=${ROCM_GPUS} \
+    -DCMAKE_INSTALL_BINDIR=${ROCM_BIN} \
+    -DCMAKE_INSTALL_INCLUDEDIR=${ROCM_INCLUDE} \
+    -DCMAKE_INSTALL_LIBDIR=${ROCM_LIB}
+
+%else
+%cmake %{cmake_generator} %{cmake_config} \
+    -DAMDGPU_TARGETS=%{gpu_list} \
+    -DCMAKE_INSTALL_LIBDIR=%_libdir
 
 %cmake_build
+%endif
+
+%if %{with gfx950}
+module purge
+%endif
 
 %install
 %cmake_install
 
 # we don't need the rocfft_rtc_helper binary, don't package it
-find %{buildroot} -type d -name "%{rocfft_version}" -print0 | xargs -0 -I {} /usr/bin/rm -rf "{}"
+find %{buildroot} -type f -name "rocfft_rtc_helper" -print0 | xargs -0 -I {} /usr/bin/rm -rf "{}"
 
 # we don't need or want the client-info file installed by rocfft
 rm -rf %{buildroot}/%{_prefix}/.info
 
-echo s@%{buildroot}@@ > br.sed
-find %{buildroot}%{_libdir} -name '*.so.*.[0-9]'     | sed -f br.sed >  %{name}.files
-find %{buildroot}%{_libdir} -name '*.so.[0-9]'       | sed -f br.sed >> %{name}.files
-find %{buildroot}%{_libdir} -name '*.so'             | sed -f br.sed >  %{name}.devel
-find %{buildroot}%{_libdir} -name '*.cmake'          | sed -f br.sed >> %{name}.devel
-%if %{with test}
-find %{buildroot}           -name 'rocfft-test'      | sed -f br.sed >  %{name}.test
-find %{buildroot}           -name 'rtc_helper_crash' | sed -f br.sed >> %{name}.test
-%endif
-
 if [ -f %{buildroot}%{_prefix}/share/doc/rocfft/LICENSE.md ]; then
     rm %{buildroot}%{_prefix}/share/doc/rocfft/LICENSE.md
 fi
 
-%files -f %{name}.files
+%check
+%if %{with test}
+%if %{with check}
+%if 0%{?suse_version}
+%{__builddir}/clients/staging/rocfft-test
+%else
+%{_vpath_builddir}/clients/staging/rocfft-test
+%endif
+%endif
+%endif
+
+%if %{with gfx950}
+%files gfx950
 %doc README.md
 %license LICENSE.md
+%{_libdir}/rocm/gfx950/lib/librocfft.so.0{,.*}
+
+%files gfx950-devel
+%dir %{_libdir}/rocm/gfx950/include/rocfft
+%dir %{_libdir}/rocm/gfx950/lib/cmake/rocfft
+%{_libdir}/rocm/gfx950/include/rocfft/*.h
+%{_libdir}/rocm/gfx950/lib/librocfft.so
+%{_libdir}/rocm/gfx950/lib/cmake/rocfft/*.cmake
 
-%files devel -f %{name}.devel
-%dir %{_libdir}/cmake/rocfft
-%dir %{_includedir}/rocfft
-%{_includedir}/rocfft/*
 
 %if %{with test}
-%files test -f %{name}.test
+%files gfx950-test
+%{_libdir}/rocm/gfx950/bin/rocfft-test
+%{_libdir}/rocm/gfx950/bin/rtc_helper_crash
+%endif
+
+%else
+
+%files
+%doc README.md
+%license LICENSE.md
+%{_libdir}/librocfft.so.0{,.*}
+
+%files devel
+%dir %{_libdir}/cmake/rocfft
+%dir %{_includedir}/rocfft
+%{_includedir}/rocfft/*.h
+%{_libdir}/librocfft.so
+%{_libdir}/cmake/rocfft/*.cmake
+
+%if %{with test}
+%files test
+%{_bindir}/rocfft-test
+%{_bindir}/rtc_helper_crash
+%endif
 %endif
 
 %changelog
+* Sun May 11 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-4
+- Add experimential gfx950
+
+* Sun Apr 27 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-3
+- Improve testing on suse
+
+* Sat Apr 26 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-2
+- Add generic gpus
+
+* Sat Apr 19 2025 Tom Rix <Tom.Rix@amd.com> - 6.4.0-1
+- Update to 6.4.0
+
+* Sun Apr 13 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-10
+- Remove global rocfft_version
+
+* Thu Apr 10 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-9
+- Reenble ninja
+
+* Fri Apr 4 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-8
+- Work around old gcc for rhel 9
+
+* Thu Apr 3 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-7
+- Remove sqlite version check for ol9
+
+* Fri Feb 14 2025 Christoph Junghans <junghans@votca.org> - 6.3.0-6
+- Add missing dep on rocm-hic-devel
+
+* Wed Feb 12 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-5
+- Fix provides
+
 * Tue Feb 11 2025 Tom Rix <Tom.Rix@amd.com> - 6.3.0-4
 - Remove multi build
 - Fix SLE 15.6