ROCmWork/rocclr
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add reproducible.patch for reproducible builds #1

Closed
bmwiedemann wants to merge 1 commits from bmwiedemann/rocclr:rawhide into rawhide
pull from: bmwiedemann/rocclr:rawhide
merge into: ROCmWork:rawhide
Conversation 3 Commits 1 Files Changed 2 +20
bmwiedemann commented 2025-10-09 11:26:35 +02:00
First-time contributor
Copy Link
No description provided.
bmwiedemann added 1 commit 2025-10-09 11:26:36 +02:00
Add reproducible.patch for reproducible builds 3b177c08a0
eeich commented 2025-10-09 13:30:18 +02:00
Owner
Copy Link

@bmwiedemann - please do not submit patches here. This is just a 'slave' copy of the Fedora repository.

@bmwiedemann - please do not submit patches here. This is just a 'slave' copy of the Fedora repository.
eeich closed this pull request 2025-10-09 13:30:18 +02:00
eeich commented 2025-10-09 13:32:24 +02:00
Owner
Copy Link

I will propose your change to the AMD developers.

I will propose your change to the AMD developers.
bmwiedemann commented 2025-10-10 12:45:19 +02:00
Author
First-time contributor
Copy Link

Note that a different approach will be needed when upstreaming, because /tmp is writable to users, predictable names there allow for symlink attacks (also feasible when PIDs are small), so even the status quo is likely unsafe.

There are options such as --fdebug-prefix-map= for mapping pathes that can help there.

For OBS builds we don't need to worry, because builds happen in a scratch-VM without other users.

Note that a different approach will be needed when upstreaming, because /tmp is writable to users, predictable names there allow for symlink attacks (also feasible when PIDs are small), so even the status quo is likely unsafe. There are options such as `--fdebug-prefix-map=` for mapping pathes that can help there. For OBS builds we don't need to worry, because builds happen in a scratch-VM without other users.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adamm eeich
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ROCmWork/rocclr#1
Delete Branch "bmwiedemann/rocclr:rawhide"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?