Files
pacemaker/pacemaker#3835-0001-Low-tools-Fix-memory-leak-in-cli_resource_delete.patch

28 lines
1.2 KiB
Diff

From f36e0de53d4a3c3a0e770f49bfa50f23fe6c1225 Mon Sep 17 00:00:00 2001
From: Reid Wahl <nrwahl@protonmail.com>
Date: Mon, 3 Mar 2025 16:39:12 -0800
Subject: [PATCH] Low: tools: Fix memory leak in cli_resource_delete()
pcmk__copy_node_list() made a copy of each pcmk_node_t object, but we
never freed those copies. Since we don't modify the nodes in this
function, we can make a shallow copy using g_list_copy().
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
---
tools/crm_resource_runtime.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: pacemaker-3.0.0+20250218.64cd85422c/tools/crm_resource_runtime.c
===================================================================
--- pacemaker-3.0.0+20250218.64cd85422c.orig/tools/crm_resource_runtime.c
+++ pacemaker-3.0.0+20250218.64cd85422c/tools/crm_resource_runtime.c
@@ -970,7 +970,7 @@ cli_resource_delete(pcmk_ipc_api_t *cont
GList *nodes = g_hash_table_get_values(rsc->priv->probed_nodes);
if(nodes == NULL && force) {
- nodes = pcmk__copy_node_list(scheduler->nodes, false);
+ nodes = g_list_copy(scheduler->nodes);
} else if ((nodes == NULL)
&& pcmk_is_set(rsc->flags, pcmk__rsc_exclusive_probes)) {