Accepting request 1219793 from systemsmanagement

OBS-URL: https://build.opensuse.org/request/show/1219793
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/ipmitool?expand=0&rev=50

.gitignore

@@ -0,0 +1 @@
+.osc

ipmitool-fix_init_from_incompat_ptr_type.patch

@@ -0,0 +1,34 @@
+From 497fce4461611feb949bdb6f8cc7ea251552f02a Mon Sep 17 00:00:00 2001
+From: Martin Jambor <mjambor@suse.cz>
+Date: Wed, 10 Jul 2024 14:37:49 +0200
+Subject: [PATCH] Fix GCC 14 initialization from incompatible pointer error
+Upstream: project archived
+References: boo#1225992
+
+In file lib/ipmi_fru.c in function fru_area_print_multirec, local
+variable mmh which is of type "struct fru_multirec_mgmt *" is
+initialized with a type-cast to type "(struct fru_multirect_mgmt *)" -
+note the t in multirect.  This causes a compile error by default with
+GCC 14.  This patch fixes the typo to avoid the issue.
+
+Signed-off-by: Martin Jambor <mjambor@suse.cz>
+---
+ lib/ipmi_fru.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/ipmi_fru.c b/lib/ipmi_fru.c
+index 4d1dbbb..90b2a63 100644
+--- a/lib/ipmi_fru.c
++++ b/lib/ipmi_fru.c
+@@ -1553,7 +1553,7 @@ fru_area_print_multirec(struct ipmi_intf * intf, struct fru_info * fru,
+ 		case FRU_RECORD_TYPE_MANAGEMENT_ACCESS:
+ 			{
+ 				struct fru_multirec_mgmt *mmh =
+-					(struct fru_multirect_mgmt *)
++					(struct fru_multirec_mgmt *)
+ 					&fru_data[sizeof(struct fru_multirec_header)];
+ 				size_t datalen = h->len - sizeof(*mmh);
+ 				struct {
+-- 
+2.45.2
+

ipmitool.changes

@@ -1,3 +1,22 @@
+-------------------------------------------------------------------
+Wed Oct 30 12:32:58 UTC 2024 - Dominique Leuenberger <dimstar@opensuse.org>
+
+- Drop rcFOO symlinks (PED-266).
+
+-------------------------------------------------------------------
+Fri Sep 13 13:13:13 UTC 2024 - olaf@aepfle.de
+
+- To create rcipmievd, the service binary is required at
+  build time. This binary is provided by aaa_base. Make sure this
+  package is available during build.
+
+-------------------------------------------------------------------
+Wed Jul 10 13:07:32 UTC 2024 - Martin Jambor <mjambor@suse.com>
+
+- Added ipmitool-fix_init_from_incompat_ptr_type.patch fixing a type
+  which led to assignment from incompatible pointer type which is an
+  error in GCC 14 [boo#1225992]
+
 -------------------------------------------------------------------
 Tue Oct 31 15:55:01 UTC 2023 - Thomas Renninger <trenn@suse.de>
 

ipmitool.spec

@@ -34,6 +34,7 @@ Patch4:         0004-Adjust-SUSE-paths.patch
 Patch5:         0005-HPM-x-compatibility-message-is-DEBUG-only.patch
 Patch6:         Fix-time-format-for-sel-list-v.patch
 Patch7:         lanp-Fix-error-response-from-Unsupported-Parameter-lookup.patch.txt
+Patch8:         ipmitool-fix_init_from_incompat_ptr_type.patch
 BuildRequires:  libtool
 BuildRequires:  openssl-devel
 BuildRequires:  readline-devel
@@ -94,18 +95,15 @@ install -D -m 644 %{SOURCE3}  %{buildroot}%{_datadir}/misc/enterprise-numbers
 install -D -m 0755 contrib/exchange-bmc-os-info.init.redhat %{buildroot}/%{_sbindir}/exchange-bmc-os-info
 install -D -m 0644 contrib/exchange-bmc-os-info.service.redhat %{buildroot}%{_unitdir}/exchange-bmc-os-info.service
 install -D -m 0644 contrib/exchange-bmc-os-info.sysconf %{buildroot}/%{_sysconfdir}/exchange-bmc-os-info
-ln -sf service %{buildroot}%{_sbindir}/rcexchange-bmc-os-info
 
 # ipmievd service
 install -D -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/ipmievd.service
 install -D -m 644 %{SOURCE2} %{buildroot}/%{_sysconfdir}/ipmievd
-ln -sf service %{buildroot}%{_sbindir}/rcipmievd
 
 # bmc-snmp-proxy
 install -D -m 755 contrib/bmc-snmp-proxy         %{buildroot}/%{_sbindir}/bmc-snmp-proxy
 install -D -m 644 contrib/bmc-snmp-proxy.service %{buildroot}%{_unitdir}/bmc-snmp-proxy.service
 install -D -m 755 contrib/bmc-snmp-proxy.sysconf %{buildroot}/%{_sysconfdir}/bmc-snmp-proxy
-ln -sf service %{buildroot}%{_sbindir}/rcbmc-snmp-proxy
 
 %pre
 %service_add_pre exchange-bmc-os-info.service ipmievd.service
@@ -138,8 +136,6 @@ ln -sf service %{buildroot}%{_sbindir}/rcbmc-snmp-proxy
 %attr(755,root,root) %{_bindir}/ipmitool
 %attr(755,root,root) %{_sbindir}/ipmievd
 %attr(755,root,root) %{_sbindir}/exchange-bmc-os-info
-%{_sbindir}/rcipmievd
-%{_sbindir}/rcexchange-bmc-os-info
 %config(noreplace) %{_sysconfdir}/exchange-bmc-os-info
 %config(noreplace) %{_sysconfdir}/ipmievd
 %{_unitdir}/exchange-bmc-os-info.service
@@ -150,7 +146,6 @@ ln -sf service %{buildroot}%{_sbindir}/rcbmc-snmp-proxy
 
 %files bmc-snmp-proxy
 %attr(755,root,root) %{_sbindir}/bmc-snmp-proxy
-%{_sbindir}/rcbmc-snmp-proxy
 %attr(644,root,root) %config(noreplace) %{_sysconfdir}/bmc-snmp-proxy
 %{_unitdir}/bmc-snmp-proxy.service