forked from cockpit/cockpit
36 lines
1.5 KiB
Diff
36 lines
1.5 KiB
Diff
|
From 979e3a4f0f499c2128094c00ca9b9e9accb9efe4 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Martin Pitt <martinpitt@users.noreply.github.com>
|
||
|
|
Date: Mon, 30 Mar 2020 19:14:18 +0200
|
||
|
|
Subject: [PATCH] bridge: Pass connectable to TLS client connection
|
||
|
|
|
||
|
|
This is being used for SNI and better error messages for TLS
|
||
|
|
connections [1]. Recent glib versions started to warn about this, which
|
||
|
|
makes our tests fail:
|
||
|
|
|
||
|
|
(test-httpstream:172365): GLib-Net-WARNING **: 02:19:07.627: GTlsClientConnection certificate verification will fail because its server-identity property is NULL. Fix your application!
|
||
|
|
(test-websocketstream:172431): GLib-Net-WARNING **: 02:19:08.201: GTlsClientConnection certificate verification will fail because its server-identity property is NULL. Fix your application!
|
||
|
|
|
||
|
|
[1] https://developer.gnome.org/gio/stable/GTlsClientConnection.html#GTlsClientConnection--server-identity
|
||
|
|
|
||
|
|
Closes #13814
|
||
|
|
---
|
||
|
|
src/bridge/cockpitconnect.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/bridge/cockpitconnect.c b/src/bridge/cockpitconnect.c
|
||
|
|
index dab1c7946..baee6bba3 100644
|
||
|
|
--- a/src/bridge/cockpitconnect.c
|
||
|
|
+++ b/src/bridge/cockpitconnect.c
|
||
|
|
@@ -135,7 +135,7 @@ on_socket_connect (GObject *object,
|
||
|
|
|
||
|
|
if (connectable->tls)
|
||
|
|
{
|
||
|
|
- cs->io = g_tls_client_connection_new (G_IO_STREAM (object), NULL, &error);
|
||
|
|
+ cs->io = g_tls_client_connection_new (G_IO_STREAM (object), connectable->address, &error);
|
||
|
|
if (cs->io)
|
||
|
|
{
|
||
|
|
g_debug ("%s: tls handshake", connectable->name);
|
||
|
|
--
|
||
|
|
2.16.4
|
||
|
|
|