[group review bot] Better wording #50

New Issue

dmach · 2025-07-02T10:40:21+02:00

dmach commented

2025-07-02 10:40:21 +02:00

I'm not a big fan of LGTM, it carries only little information.
I'd prefer to use approve instead to remain consistent with obs/osc/git-obs.

user:

@<bot> : approve

bot:

<user> approved a review on behalf of <bot>

user:

@<bot> : [decline] (optional keyword)

justification follows

bot:

<user> requested changes on behalf of <bot>. See <clickable link to user's comment>.

I'd also consider rephrasing the bot's message from

Review by <bot> represents a group of reviewers: <user>, <user> . To review as part of this group, create a comment with contents @<bot>: LGTM on a separate line to accept a review. To request changes, write @<bot>: followed by reason for rejection. Do not use reviews to review as a group. Editing a comment invalidates that comment.

to

Review by <bot> represents a group of reviewers: <user>, <user>.
Do **not** use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: `@<bot>: approve`.
To request changes on behalf of the group, create the following comment: `@<bot>: decline` followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

I'm not a big fan of `LGTM`, it carries only little information. I'd prefer to use `approve` instead to remain consistent with obs/osc/git-obs. user: ``` @<bot> : approve ``` bot: ``` <user> approved a review on behalf of <bot> ``` --- user: ``` @<bot> : [decline] (optional keyword) justification follows ``` bot: ``` <user> requested changes on behalf of <bot>. See <clickable link to user's comment>. ``` --- I'd also consider rephrasing the bot's message from ``` Review by <bot> represents a group of reviewers: <user>, <user> . To review as part of this group, create a comment with contents @<bot>: LGTM on a separate line to accept a review. To request changes, write @<bot>: followed by reason for rejection. Do not use reviews to review as a group. Editing a comment invalidates that comment. ``` to ``` Review by <bot> represents a group of reviewers: <user>, <user>. Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@<bot>: approve`. To request changes on behalf of the group, create the following comment: `@<bot>: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state. ```

adamm referenced this issue from a commit

2025-08-27 19:28:40 +02:00

group-review: use suggested wording

adamm closed this issue

2025-08-27 19:28:40 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adamm/autogits#50