Adam Majer adamm
1 Followers · 0 Following
  • Joined on 2023-07-21
Repositories
45
 Projects Packages Public Activity Starred Repositories
adamm pushed to main at openSUSE/Maintainers 2025-04-08 11:15:26 +02:00
bf25e8322c Update release-team.json
adamm commented on pull request cockpit/cockpit#17 2025-04-08 10:47:32 +02:00
Always install selinux modules regardless of selinuxenabled status

I'm not advocating for quick action here. I'm advocating for discussing this and fixing it in the right place 😉

adamm commented on pull request cockpit/cockpit#17 2025-04-08 10:46:12 +02:00
Always install selinux modules regardless of selinuxenabled status

Yes, selinux should take care about selinux and we should only care that the module is installed. It's selinux's problem to handle how it should handle its policy and modules when enabled or…

adamm commented on pull request cockpit/cockpit#17 2025-04-08 10:13:31 +02:00
Always install selinux modules regardless of selinuxenabled status

This entire section should not be in an if block. The %selinux* macros already have their own conditionals.

adamm pushed to refactor at git-workflow/autogits 2025-04-07 19:03:35 +02:00
06aef50047 start refactoring PR bot
adamm created branch refactor in git-workflow/autogits 2025-04-07 19:03:35 +02:00
adamm commented on pull request cockpit/cockpit#17 2025-04-07 17:07:08 +02:00
Always install selinux modules regardless of selinuxenabled status

It seems almost like a broken architecture of selinux if you can't just install config files and have them used when selinux is actually enabled. On the other hand, selinux breaks completely when…

adamm pushed to main at git-workflow/autogits 2025-04-07 14:24:56 +02:00
52a5cdea94 group-review: fix typo
adamm pushed to main at git-workflow/autogits 2025-04-07 14:21:46 +02:00
d3f1b36676 Use "-gitea-url" instead of "-gitea-host" or simiar
adamm commented on issue git-workflow/autogits#18 2025-04-07 14:02:41 +02:00
Group reviewer bot

-gitea-url is probably better here then

adamm pushed to main at cockpit/cockpit 2025-04-07 13:20:57 +02:00
e638b3db10 Always install selinux modules regardless of selinuxenabled status
adamm merged pull request cockpit/cockpit#17 2025-04-07 13:20:57 +02:00
Always install selinux modules regardless of selinuxenabled status
adamm pushed to master at cockpit/_ObsPrj 2025-04-07 13:20:50 +02:00
f33493df14 Merge pull request 'Forwarded PR: cockpit' (#42) from PR_cockpit#17 into master
4227c93dbd auto-created for cockpit
Compare 2 commits »
adamm merged pull request cockpit/_ObsPrj#42 2025-04-07 13:20:49 +02:00
Forwarded PR: cockpit
adamm commented on pull request cockpit/cockpit#17 2025-04-07 13:00:33 +02:00
Always install selinux modules regardless of selinuxenabled status

The question here is, do we need to split the subpackage at all? Can we just run this registration on all systems instead?

The macro expands to

> rpm --eval %selinux_modules_install

…
adamm pushed to PR_cockpit#17 at cockpit/_ObsPrj 2025-04-07 12:44:19 +02:00
4227c93dbd auto-created for cockpit
adamm created pull request cockpit/_ObsPrj#42 2025-04-07 12:44:18 +02:00
Forwarded PR: cockpit
adamm created branch PR_cockpit#17 in cockpit/_ObsPrj 2025-04-07 12:44:18 +02:00
adamm pushed to main at git-workflow/autogits 2025-04-07 09:47:14 +02:00
5ea5f05b02 common: reviews fix
adamm pushed to main at git-workflow/autogits 2025-04-06 17:32:32 +02:00
5877081280 whitespace