From b5bf0ca046ce2396feaa239d20792c13bfc0b0711018392591889a22a9904537 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Wed, 8 Mar 2023 10:15:18 +0000 Subject: [PATCH] Accepting request 1070110 from home:marxin:branches:graphics - Add silent-Werror_dangling-reference.patch that addressed a false-positive warning in GCC: https://bugs.libcamera.org/show_bug.cgi?id=185. OBS-URL: https://build.opensuse.org/request/show/1070110 OBS-URL: https://build.opensuse.org/package/show/graphics/libcamera?expand=0&rev=38 --- libcamera.changes | 6 ++++++ libcamera.spec | 1 + silent-Werror_dangling-reference.patch | 15 +++++++++++++++ 3 files changed, 22 insertions(+) create mode 100644 silent-Werror_dangling-reference.patch diff --git a/libcamera.changes b/libcamera.changes index 9bf2e96..582de2e 100644 --- a/libcamera.changes +++ b/libcamera.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Wed Mar 8 09:21:29 UTC 2023 - Martin Liška + +- Add silent-Werror_dangling-reference.patch that addressed a false-positive + warning in GCC: https://bugs.libcamera.org/show_bug.cgi?id=185. + ------------------------------------------------------------------- Mon Feb 6 10:08:27 UTC 2023 - Paolo Stivanin diff --git a/libcamera.spec b/libcamera.spec index 24967da..a975a88 100644 --- a/libcamera.spec +++ b/libcamera.spec @@ -28,6 +28,7 @@ URL: http://libcamera.org/ Source: %name-%version.tar.xz Source1: baselibs.conf +Patch0: silent-Werror_dangling-reference.patch BuildRequires: boost-devel BuildRequires: c++_compiler diff --git a/silent-Werror_dangling-reference.patch b/silent-Werror_dangling-reference.patch new file mode 100644 index 0000000..349c5ae --- /dev/null +++ b/silent-Werror_dangling-reference.patch @@ -0,0 +1,15 @@ +diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp +index b32aad24..5fb07526 100644 +--- a/src/apps/cam/file_sink.cpp ++++ b/src/apps/cam/file_sink.cpp +@@ -114,7 +114,10 @@ void FileSink::writeBuffer(const Stream *stream, FrameBuffer *buffer, + } + + for (unsigned int i = 0; i < buffer->planes().size(); ++i) { ++#pragma GCC diagnostic push ++#pragma GCC diagnostic ignored "-Wdangling-reference" + const FrameMetadata::Plane &meta = buffer->metadata().planes()[i]; ++#pragma GCC diagnostic pop + + Span data = image->data(i); + unsigned int length = std::min(meta.bytesused, data.size());