747 Commits

Author SHA1 Message Date
James Youngman
352eb0e9f7 Prepare for release of 4.5.13.
* configure.ac: Change the version number to 4.5.13.
* NEWS: Mention some documentation bug fixes which have been
applied (ChangeLog entries already exist for these).  Change the
version number of the top section of the NEWS file.
2014-07-16 07:26:01 +01:00
James Youngman
00864c7e7f Routinely check .xo and .exp test file lists in a clearer way.
* find/testsuite/checklists.py: Tiny program for checking that the
correct lists of .xo and .exp files exist in the Makefile.am file.
* Makefile.am (checklists): Update target to use the new program.
Make this target phony.
2014-06-01 00:10:38 +01:00
James Youngman
8c0780f2ae Check there are no duplicate configuration entries for test files.
* find/testsuite/Makefile.am (EXTRA_DIST_XO): Remove duplicate items.
(EXTRA_DIST_EXP): Likewise.
(checklists): Run with the other checks, using check-local.  Don't
echo the full command, because it will make the summary of the
Automake-driven tests scroll offscreen.
(TEST_EXTENSIONS): Add .sh and .py.
2014-05-31 19:36:22 +01:00
James Youngman
d503be8998 Enable parallel tests.
* find/testsuite/Makefile.am (AUTOMAKE_OPTIONS): Enable
parallel-tests.  This will only include tests known directly via
$(TESTS), not DejaGnu tests.
2014-05-31 15:04:19 +01:00
Eric S. Raymond
dc3d88dec2 Fix errant backslash in find manpage.
* find/find.1 (UNUSUAL FILENAMES): Fix errant backslash.
2014-05-25 14:42:12 +01:00
James Youngman
d0e51f0eeb Update German translation.
* po/de.po: Update German translation from the Translation
Project.
2014-05-12 00:47:39 +01:00
James Youngman
4bddc49db8 Several updates and clarifications to README-hacking.
* README-hacking: Explain that tool-versions.txt is not checked
into git.  The repository has grown from 14MB to 16MB.  Gnulib is
now a submodule and the directory we keep it in has changed.
Remove the suggestion to rsync the translations from the
translation project, since the files that fetches seem to be out
of date.  Move the instruction to update ChangeLog to a more
prominent place.  Mention that there is an electronic process for
assignments in some locations.  Update the copyright year.
2014-05-12 00:41:46 +01:00
James Youngman
9585dd6da2 * gnulib: Update submodule to current version at origin/master. 2014-05-11 15:40:09 +01:00
James Youngman
4962f15a17 Fix inadequte quoting in AC_ARG_ENABLE usage.
* configure.ac: Quote second argument of AC_ARG_ENABLE.
2014-05-11 15:40:09 +01:00
James Youngman
cb1406fe11 Fix typo "ouptut".
* locate/locate.1 (OPTIONS): fix typo "ouptut" (from an anonymous
Savannah bug report #40804).
2014-01-14 23:55:59 +00:00
James Youngman
0dcc67d8b1 Add source files to po/POTFILES.in.
* po/POTFILES.in: Add some source file names which were missing.
2014-01-12 21:12:10 +00:00
Nguyễn Thái Ngọc Duy
1d6d1afa52 Mark strings from gnulib for translation 2014-01-12 20:52:44 +00:00
James Youngman
7dbefe0f85 Updated various translations from the Translation Project.
* po/ru.po: Updated Russian translation from the Translation
Project.
* po/fr.po: Updated French translation.
* po/pt_BR.po: Updated Brazilian Portuguese translation.
* po/it.po: Updated Italian translation.
* po/sr.po: Updated Serbian translation.
* po/eo.po: Updated Esperanto translation.
* po/tr.po: Updated Turkish translation.
* po/fi.po: Updated Finnish translation.
* po/el.po: Updated Greek translation.
2014-01-05 23:11:08 +00:00
James Youngman
0290b11d0e Updated Slovenian translation.
* po/sl.po: Updated Slovenian translation from the Translation
Project.
2014-01-05 22:59:35 +00:00
James Youngman
8acf1d2ecf Bug #35753: check the success/failure of material I/O operations.
* lib/listfile.c (list_file): Check the result of fprintf to
determine if there was an I/O error on output.  Return false (bool
instead of void) if so.
(print_name_without_quoting): Likewise.
(print_name_with_quoting): Likewise.
(print_name): Propagate the result of print_name_without_quoting
or print_name_with_quoting (and make all three functions return bool).
* find/pred.c (is_ok): Check the result of fprintf to
determine if there was an I/O error on output.  Exit fatally if
there was a problem (since we cannot expect the user to say "yes"
or "no" to a prompt they will not have seen).
* xargs/xargs.c (print_args): Check the result of fprintf and
fflush to determine if there was an I/O error on output.  Exit
fatally for the same reason as above if there is a problem.
* NEWS: Mention this bugfix (now that it is fully fixed).
2013-12-08 21:02:51 +00:00
James Youngman
d0bba0775b Fix some signed/unsigned problems.
* find/util.c (show_valid_debug_options): change type of array
subscript to size_t to avoid signed/unsigned problems.
(set_stat_placeholders): Silence unuseful compiler warning about
unused parameter.
* find/ftsfind.c (show_outstanding_execdirs): change type of array
subscript to size_t to avoid signed/unsizned problems.
2013-12-08 20:11:02 +00:00
James Youngman
4cae4b12df Fix format specifier in safe_read error message.
* xargs/xargs.c (xargs_do_exec): print size_t values with %zu, not
%d (since size_t is not and never can be the same type as int).
2013-12-08 19:42:30 +00:00
James Youngman
c0e9035f57 Bug #35753: detect failure of the atexit library function.
* find/find.c (main): Issue a fatal error message if atexit fails.
* xargs/xargs.c (main): Likewise.
* find/ftsfind.c (main): Likewise.
* locate/code.c (main): Likewise.
* locate/frcode.c (main): Likewise.
* locate/locate.c (dolocate): Likewise.
* locate/bigram.c (main): Likewise; also include <errno.h>.
2013-12-08 19:32:20 +00:00
James Youngman
bd0d840775 Add bracket missing from synopsis in locate manpage.
* locate/locate.1 (SYNOPSIS): Add missing bracket.
2013-10-27 00:44:00 +01:00
James Youngman
72e9e595cc Clearly explain the result of -exec/-execdir ... +
* doc/find.texi (Single File): Explain that "-exec command ;"
returns true of the command exited with a status of 0.
(Multiple Files): Explain that "-execdir command +" always returns
true.  Likewise for "-exec command +".
* find/find.1: similar changes.
2013-10-26 14:56:17 +01:00
James Youngman
3aad932d73 Fix bug #40094: minor inconsistencies in xargs option descriptions.
* xargs/xargs.1: Update the description of -e option to emphasize
that the argument must follow the option letter immediately (in
other words, that it may not appear in the next program argument).
Likewise for the the -i and -l (lower-case L) options.
* xargs/xargs.c (usage): Minor consistency improvements to help
text.
2013-09-24 23:02:00 +01:00
James Youngman
c2ea2eb56b Update Czech and Dutch translations.
* po/nl.po: Update Dutch translation.
* po/cs.po: Update Czech translation.
2013-09-24 22:44:26 +01:00
James Youngman
cdd390b492 Fix bug #39162: -printf reads beyond arguments terminated by \
* find/print.c (insert_fprintf): If a \ is found at the end of a
format string, issue a warning (and render it as-is).
* NEWS: Mention this bugfix.
2013-09-24 00:28:05 +01:00
James Youngman
4f45698bc3 Update version number to 4.5.13-git.
* configure.ac: Update version number to 4.5.13-git.
* NEWS: Likewise.
2013-09-23 23:35:25 +01:00
James Youngman
f0c6598876 Updated Estonian, Polish, Ukrainian translations.
* po/et.po: Updated the Estonian translation from the Translation
Project.
* po/pl.po: Updated the Polish translation.
* po/uk.po: Updated the Ukrainian translation.
2013-09-23 23:32:33 +01:00
James Youngman
b3bac66162 Fix typo in ChangeLog 2013-09-22 22:51:03 +01:00
James Youngman
570bc9f186 Release findnutils-4.5.12.
* configure.ac (AC_INIT): Change version number to 4.5.12.
* NEWS: Change version number of most recent release to 4.5.12.
2013-09-22 22:10:44 +01:00
James Youngman
af219516a3 Add a bug number for bug #40088.
* NEWS: Add a bug number for bug #40088: potential buffer overflow
in -execdir and -okdir.  Re-order the bugs listed to be
decreasing numerically by ID.
2013-09-22 21:33:19 +01:00
James Youngman
96df69c709 Issue an error message when fts_read fails. Fixes bug #39324.
* find/ftsfind.c (find): when fts_read fails, issue an error
message, set the exit status to zero and stop.  Previously the
program would just stop (i.e. it failed to distinguish "done" from
"failed").
* find/find.1 (-exec): explain that on failure, some pending
command launches may not happen.  The Texinfo documentation
already pointed this out, so that didn't need to be changed.
* NEWS: Mention this bugfix.
2013-09-22 15:20:38 +01:00
James Youngman
6cd5d3b1a8 find: state that -execdir command is run locally to the matched file.
* doc/find.texi (Single File): Correct the description of what the
current directory will be when the command specified by -execdir
gets run.  This fixes a documentation but reported by Eric
Hanchrow.
* NEWS: Mention this fix.
2013-09-21 23:45:08 +01:00
169161fa0e xargs: wait for process before prompting in interactive mode (-p)
In interactive mode, there is a race between xargs prompting
about the next command to be run, vs. the execution of the
echo command:

  $ echo 1 2 | xargs -n 1 -p
  /bin/echo 1 ?...y
  /bin/echo 2 ?...1
  y
  2

This behavior violates POSIX:
(http://pubs.opengroup.org/onlinepubs/9699919799/utilities/xargs.html):

  The xargs utility shall then invoke the constructed command line
  and wait for its completion. This sequence shall be repeated until
  one of the following occurs: [...]

* xargs/xargs.c (xargs_do_exec): Move the code for waiting for forked
processes up, so that the child process terminates before we prompt
for the next command.
* NEWS: Mention the fix.

Reported by jidanni@jidanni.org in
http://lists.gnu.org/archive/html/bug-findutils/2013-07/msg00015.html
2013-09-21 23:18:19 +01:00
Dmitry V. Levin
29f3173a56 find: fix potential buffer overflow in -execdir and -okdir
* lib/buildcmd.c (bc_push_arg): Take prefix length into account
to avoid state->argbuf overflow.
* NEWS: Mention this fix.
2013-09-21 22:55:43 +01:00
James Youngman
2376e7c4a8 Make sv-34976-execdir-fd-leak.sh test more POSIX-compliant.
* find/testsuite/sv-34976-execdir-fd-leak.sh: Avoid using seq;
instead, use pre-generated lists of test file names.  Also avoid
using file descriptors 0, 1, 2 in the test.
2013-09-21 00:22:32 +01:00
James Youngman
9b0079c1d3 Fix typo "sturct".
* find/exec.c (impl_pred_exec): Typo fix: struct/struct.
* ChangeLog (2007-03-28): Likewise.
2013-09-21 00:06:04 +01:00
183115d048 find: fix fd leak with --execdir option (bug#34976)
Prevent "Failed to save working dir[...]: Too many open files"
error by closing the file descriptor of the working directory.

* find/exec.c (impl_pred_exec): Free the working directory if find
executes the command in the local dir, i.e. if it has been saved
by record_exec_dir().  Re-indent code.
* find/testsuite/sv-34976-execdir-fd-leak.sh: Add test.
* find/testsuite/Makefile.am (test_shell_progs): Mention the test.
* NEWS: Mention the fix.
2013-09-20 22:14:05 +01:00
James Youngman
80c3d55922 Updated Greek translation.
* po/el.po: Updated Greek translation from the Translation
Project.
2013-09-20 21:27:23 +01:00
193d1255e6 xargs: Fix integer overflow in implicit conversion in do_exec.
* xargs/xargs.c (xargs_do_exec): Change type of r from int to
size_t, since that is the type that safe_read actually returns.
2013-09-20 21:00:19 +01:00
James Youngman
c67dc56c81 Add Bernhard Voelker to AUTHORS.
* AUTHORS: Add Bernhard Voelker.
2013-09-20 20:52:09 +01:00
James Youngman
4afb645b82 Check for prefixed versions of ranlib, too.
* configure.ac: Check for prefixed versions of ranlib, too.
2013-09-20 19:51:19 +01:00
Benedikt Morbach
f15fa8ecf7 configure.ac: look for prefixed ar
Look for '${host}-ar' as set by AC_CANONICAL_HOST before looking for
the unprefixed 'ar'.  This is useful when cross-compiling when all
your binutils are prefixed.
2013-09-20 19:44:57 +01:00
James Youngman
c47259c0fa Fix compilation error where struct dirent lacks a d_ino member.
* find/find.c (NOT_AN_INODE_NUMBER): Add missing identifier which
(when missing) caused a compilation error on system where struct
dirent lacks a d_ino member.
2013-09-20 18:42:27 +01:00
James Youngman
1ccfd46a25 Refer to the info manual in a clearer and more explicit way.
* find/find.1 (SEE ALSO): Explain how to invoke info to read the
Texinfo manual.
* locate/locate.1 (SEE ALSO): Likewise.
* locate/updatedb.1 (SEE ALSO): Likewise.
* xargs/xargs.1 (SEE ALSO): Likewise.
2013-09-20 17:56:29 +01:00
James Youngman
be6ddda792 Be consistent about what we call the places the search starts.
* find/find.1: Consistently describe the paths at which the search
begins as "satrting points".
2013-09-20 17:42:21 +01:00
James Youngman
5d3bf5aa7f Add unlinkat moduile.
* import-gnulib.config (modules): Add unlinkat module, following
bug report from Martin von Gagern.
2013-06-02 14:36:00 +01:00
Paul Eggert
3d13be5654 More removal of support for -perm +MODE.
* find/parser.c (parse_perm): Remove no-longer-needed local var
and associated code.  Reported by Eric Blake in
<http://savannah.gnu.org/bugs/?38474#comment9>.
2013-04-24 07:55:38 +01:00
Paul Eggert
90f0c5d241 Remove support for obsolete -perm +MODE syntax.
Also, do not reject -perm /MODE merely because of POSIXLY_CORRECT.
Problem reported in <https://savannah.gnu.org/bugs/?38474>.
* NEWS:
* doc/find.texi (Mode Bits): Document this.
(Environment Variables): POSIXLY_CORRECT does not affect -perm.
* find/parser.c (parse_help): Mention /MODE, not +MODE.
(non_posix_mode): Remove.
(parse_perm): Remove support for -perm +MODE.
Do not reject -perm /MODE merely because POSIXLY_CORRECT is set;
POSIXLY_CORRECT is not supposed to be for pedantic checking.
2013-04-22 22:18:15 +01:00
James Youngman
2957a7ae55 Fix documentation typo.
* doc/find.texi (Mode Bits): Fix typo "it set" -> "is set".
2013-04-22 21:49:40 +01:00
Paul Eggert
a8981eb058 doc: fix typos uncovered by texinfo 5.0
* doc/find-maint.texi: Fix typos that cause 'make' to fail
if texinfo 5.0 is installed.
2013-04-22 21:30:52 +01:00
James Youngman
35b0ec1143 Enable assertions in locate.
* locate/locate.c: Don't #define NDEBUG.
2013-04-22 21:19:01 +01:00
James Youngman
b8ffa159fe Explain rounding semantics of -size more clearly in manpage.
* find/find.1 (-size): explain the rounding-up semantics more
clearly.
2013-04-21 23:09:47 +01:00