SHA256
11
0
forked from pool/gn
Files
gn/redundant-move.patch
Ruediger Oertel afdc86b78b - Update to version 0.20250306:
* Remove deps from rust executable to module's pcm files
  * Update test for rust executable deps
  * Add toolchain for cxx modules in TestWithScope
  * Apply the latest clang-format
  * Update reference for {rustdeps}
  * Always generate a .toolchain file even if it is empty.
  * Pass --with-lg-page=16 when building jemalloc for arm64.
  * Remove obsolete debug checks.
  * Make default vs ide version on Windows as 2022
  * Reland "Adds a path_exists() function"
  * Revert "Adds a path_exists() function"
  * Adds a path_exists() function
  * Revert "Speed-up GN with custom OutputStream interface."
  * Speed-up GN with custom OutputStream interface.
  * Add `exec_script_allowlist` to replace `exec_script_whitelist`.
  * Retry ReplaceFile in case of failure
  * Fix crash when NinjaBuildWriter::RunAndWriteFile fails
  * fix include for escape.h
  * fix exit code for gn gen failure
  * misc: Use html.escape instead of cgi.escape
  * Do not copy parent build_dependency_files_ in Scope constructors.
  * Improve error message for duplicated items
  * [rust-project] Always use forward slashes in sysroot paths
  * Update all_dependent_configs docs.
  * set 'no_stamp_files' by default
  * fix a typo
  * Stop using transitional LFS64 APIs
  * do not use tool prefix for phony rule
  * [rust] Add sysroot_src to rust-project.json

OBS-URL: https://build.opensuse.org/package/show/network:chromium/gn?expand=0&rev=53
2025-03-06 17:15:12 +00:00

36 lines
1.6 KiB
Diff

[ 75s] ../src/gn/desc_builder.cc: In member function 'base::Value {anonymous}::BaseDescBuilder::ToBaseValue(const Scope*)':
[ 75s] ../src/gn/desc_builder.cc:180:21: error: redundant move in return statement [-Werror=redundant-move]
[ 75s] 180 | return std::move(res);
[ 75s] | ~~~~~~~~~^~~~~
[ 75s] ../src/gn/desc_builder.cc:180:21: note: remove 'std::move' call
[ 75s] ../src/gn/desc_builder.cc: In instantiation of 'base::Value {anonymous}::BaseDescBuilder::ToBaseValue(const std::vector<T>&) [with T = Value]':
[ 75s] ../src/gn/desc_builder.cc:194:27: required from here
[ 75s] ../src/gn/desc_builder.cc:171:25: error: redundant move in return statement [-Werror=redundant-move]
[ 75s] 171 | return std::move(res);
[ 75s] | ^
[ 75s] ../src/gn/desc_builder.cc:171:25: note: remove 'std::move' call
[ 75s] cc1plus: all warnings being treated as errors
Index: gn-0.20231023/src/gn/desc_builder.cc
===================================================================
--- gn-0.20231023.orig/src/gn/desc_builder.cc
+++ gn-0.20231023/src/gn/desc_builder.cc
@@ -168,7 +168,7 @@ class BaseDescBuilder {
base::ListValue res;
for (const auto& v : vector)
res.GetList().emplace_back(ToBaseValue(v));
- return std::move(res);
+ return res;
}
base::Value ToBaseValue(const Scope* scope) {
@@ -177,7 +177,7 @@ class BaseDescBuilder {
scope->GetCurrentScopeValues(&map);
for (const auto& v : map)
res.SetKey(v.first, ToBaseValue(v.second));
- return std::move(res);
+ return res;
}
base::Value ToBaseValue(const Value& val) {