Patch cockpit-machines to ignore domain not found errors when domain is deleted

.gitignore

@@ -1 +1,2 @@
 .osc
+node_modules.sums

cockpit-machines.changes

@@ -1,7 +1,43 @@
+-------------------------------------------------------------------
+Thu Jun 26 11:58:26 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
+
+- Patch cockpit-machines to ignore domain not found errors
+  when domain is deleted (bsc#1236383)
+  * added nic-domain-not-found.patch
+
+-------------------------------------------------------------------
+Mon Jun 16 08:22:25 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
+
+- Update to 333
+  * Bug fixes
+  * The "shareable" attribute of disks is no longer modified by Cockpit
+  * Virtual network interfaces can now select source mode
+
+-------------------------------------------------------------------
+Fri May  2 06:54:32 UTC 2025 - Luna D Dragon <luna.dragon@suse.com>
+
+- update to 330
+  * Upgraded to Patternfly 6
+- changes from 329
+  * Fix launching remote viewer
+  * Translation updates
+
+-------------------------------------------------------------------
+Fri Mar 14 12:49:21 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
+
+- Patch cockpit-machines to use UEFI as default firmware
+  * added uefi-default-firmware.patch
+
+-------------------------------------------------------------------
+Mon Mar 10 12:45:15 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
+
+- Update to 328
+  * Translation updates
+
 -------------------------------------------------------------------
 Mon Mar 10 08:49:16 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
 
-- Remove qemu-spice from SLFO_16
+- Remove qemu-spice from SLFO_16 (bsc#1238723)
 
 -------------------------------------------------------------------
 Wed Feb 19 18:01:04 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
@@ -159,7 +195,7 @@ Fri Jun 16 12:07:39 UTC 2023 - Adam Majer <adam.majer@suse.de>
 -------------------------------------------------------------------
 Fri Sep 23 10:30:20 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Require qemu-block-curl for installing over https (bsc#1199672) 
+- Require qemu-block-curl for installing over https (bsc#1199672)
 
 -------------------------------------------------------------------
 Wed Aug 10 10:19:26 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
@@ -198,7 +234,7 @@ Thu Mar 17 13:42:11 UTC 2022 - Adam Majer <adam.majer@suse.de>
 -------------------------------------------------------------------
 Mon Mar 14 22:37:04 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Hide links pointing to RHEL docs, hide-docs.patch (bsc#1197003) 
+- Hide links pointing to RHEL docs, hide-docs.patch (bsc#1197003)
 
 -------------------------------------------------------------------
 Thu Mar 10 15:41:35 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
@@ -209,12 +245,12 @@ Thu Mar 10 15:41:35 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 -------------------------------------------------------------------
 Mon Jan 31 09:50:20 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Remove translate-toolkit which is not available in SLE 
+- Remove translate-toolkit which is not available in SLE
 
 -------------------------------------------------------------------
 Fri Jan 28 10:53:18 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Re-add source-offset to _service. 
+- Re-add source-offset to _service.
 
 -------------------------------------------------------------------
 Fri Aug 13 11:23:02 UTC 2021 - Ludwig Nussel <lnussel@suse.de>

cockpit-machines.spec

@@ -17,7 +17,7 @@
 
 
 Name:           cockpit-machines
-Version:        327
+Version:        333
 Release:        0
 Summary:        Cockpit user interface for virtual machines
 License:        LGPL-2.1-or-later AND MIT
@@ -29,6 +29,8 @@ Source12:       update_version.sh
 %include %_sourcedir/node_modules.spec.inc
 Patch10:        hide-docs.patch
 Patch11:        load-css-overrides.patch
+Patch12:        uefi-default-firmware.patch
+Patch13:        nic-domain-not-found.patch
 BuildArch:      noarch
 BuildRequires:  appstream-glib
 BuildRequires:  make

nic-domain-not-found.patch

@@ -0,0 +1,36 @@
+From 6c982496f7b9cd9ef08308e1edd820b3910a7833 Mon Sep 17 00:00:00 2001
+From: Miika Alikirri <miika.alikirri@suse.com>
+Date: Wed, 25 Jun 2025 14:07:00 +0300
+Subject: [PATCH] nics: ignore domain not found error caused by domain being
+ removed
+
+If user is in the VMDetails page during migration, the VM might get
+deleted before domainInterfaceAddresses is done processing. This race
+condition can end up causing a confusing view where the UI shows a
+redundant "Domain not found" error, and the regular "VM doesn't exist"
+page at the same time
+---
+ src/components/vm/nics/vmNicsCard.tsx | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+diff --git a/src/components/vm/nics/vmNicsCard.jsx b/src/components/vm/nics/vmNicsCard.jsx
+index 8b309ac0..79efe152 100644
+--- a/src/components/vm/nics/vmNicsCard.jsx
++++ b/src/components/vm/nics/vmNicsCard.jsx
+@@ -239,8 +239,15 @@ export class VmNetworkTab extends React.Component {
+         domainInterfaceAddresses({ connectionName: this.props.vm.connectionName, objPath: this.props.vm.id })
+                 .then(domifaddressAllSources => {
+                     const allRejected = !domifaddressAllSources.some(promise => promise.status == 'fulfilled');
++                    // If user is in the VMDetails page during migration, the VM might get deleted
++                    // before domainInterfaceAddresses is done processing. This race condition can end up
++                    // causing a confusing view where the UI shows a redundant "Domain not found error"
++                    // and the regular VM doesn't exist page, at the same time.
++                    const domainNotFound = domifaddressAllSources.some(promise =>
++                        promise.status === 'rejected' && promise.reason?.message.startsWith("Domain not found:")
++                    );
+
+-                    if (allRejected)
++                    if (allRejected && !domainNotFound)
+                         this.props.onAddErrorNotification({
+                             text: cockpit.format(_("Failed to fetch the IP addresses of the interfaces present in $0"), this.props.vm.name),
+                             detail: [...new Set(domifaddressAllSources.map(promise => promise.reason ? promise.reason.message : ''))].join(', '),

uefi-default-firmware.patch

@@ -0,0 +1,41 @@
+From a580aa1ee6c24aab29fc7710b82187c15f21e6ec Mon Sep 17 00:00:00 2001
+From: Miika Alikirri <miika.alikirri@suse.com>
+Date: Thu, 6 Mar 2025 09:25:08 +0200
+Subject: Use UEFI as default firmware instead of bios
+
+---
+ src/components/vm/overview/firmware.jsx | 4 ++--
+ src/components/vm/overview/helpers.jsx  | 2 +-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/components/vm/overview/firmware.jsx b/src/components/vm/overview/firmware.jsx
+index e99c893a..f04dc023 100644
+--- a/src/components/vm/overview/firmware.jsx
++++ b/src/components/vm/overview/firmware.jsx
+@@ -32,8 +32,8 @@ import { supportsUefiXml, labelForFirmwarePath } from './helpers.jsx';
+ 
+ const _ = cockpit.gettext;
+ 
+-const xmlToState = value => value || 'bios';
+-const stateToXml = value => value == 'bios' ? null : value;
++const xmlToState = value => value || 'efi';
++const stateToXml = value => value == 'efi' ? null : value;
+ 
+ class FirmwareModal extends React.Component {
+     static contextType = DialogsContext;
+diff --git a/src/components/vm/overview/helpers.jsx b/src/components/vm/overview/helpers.jsx
+index e0702ac6..582225fd 100644
+--- a/src/components/vm/overview/helpers.jsx
++++ b/src/components/vm/overview/helpers.jsx
+@@ -69,7 +69,7 @@ export function labelForFirmwarePath(path, guest_arch) {
+     };
+     if (!path) {
+         if (["i686", "x86_64"].includes(guest_arch))
+-            return "bios";
++            return "efi";
+         else
+             return "unknown";
+     } else {
+-- 
+2.48.1
+