Explicitly set uefi as default firmware (bsc#1245145)

cockpit-machines.changes

@@ -1,3 +1,38 @@
+-------------------------------------------------------------------
+Wed Jul  9 08:18:07 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
+
+- Explicitly set uefi as default firmware (bsc#1245145)
+
+-------------------------------------------------------------------
+Thu Jun 26 11:58:26 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
+
+- Patch cockpit-machines to ignore domain not found errors
+  when domain is deleted (bsc#1236383)
+  * added nic-domain-not-found.patch
+
+-------------------------------------------------------------------
+Mon Jun 16 08:22:25 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
+
+- Update to 333
+  * Bug fixes
+  * The "shareable" attribute of disks is no longer modified by Cockpit
+  * Virtual network interfaces can now select source mode
+
+-------------------------------------------------------------------
+Fri May  2 06:54:32 UTC 2025 - Luna D Dragon <luna.dragon@suse.com>
+
+- update to 330
+  * Upgraded to Patternfly 6
+- changes from 329
+  * Fix launching remote viewer
+  * Translation updates
+
+-------------------------------------------------------------------
+Fri Mar 14 12:49:21 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
+
+- Patch cockpit-machines to use UEFI as default firmware
+  * added uefi-default-firmware.patch
+
 -------------------------------------------------------------------
 Mon Mar 10 12:45:15 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
 
@@ -7,7 +42,7 @@ Mon Mar 10 12:45:15 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
 -------------------------------------------------------------------
 Mon Mar 10 08:49:16 UTC 2025 - Miika Alikirri <miika.alikirri@suse.com>
 
-- Remove qemu-spice from SLFO_16
+- Remove qemu-spice from SLFO_16 (bsc#1238723)
 
 -------------------------------------------------------------------
 Wed Feb 19 18:01:04 UTC 2025 - Alice Brooks <alice.brooks@suse.com>
@@ -165,7 +200,7 @@ Fri Jun 16 12:07:39 UTC 2023 - Adam Majer <adam.majer@suse.de>
 -------------------------------------------------------------------
 Fri Sep 23 10:30:20 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Require qemu-block-curl for installing over https (bsc#1199672) 
+- Require qemu-block-curl for installing over https (bsc#1199672)
 
 -------------------------------------------------------------------
 Wed Aug 10 10:19:26 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
@@ -204,7 +239,7 @@ Thu Mar 17 13:42:11 UTC 2022 - Adam Majer <adam.majer@suse.de>
 -------------------------------------------------------------------
 Mon Mar 14 22:37:04 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Hide links pointing to RHEL docs, hide-docs.patch (bsc#1197003) 
+- Hide links pointing to RHEL docs, hide-docs.patch (bsc#1197003)
 
 -------------------------------------------------------------------
 Thu Mar 10 15:41:35 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
@@ -215,12 +250,12 @@ Thu Mar 10 15:41:35 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 -------------------------------------------------------------------
 Mon Jan 31 09:50:20 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Remove translate-toolkit which is not available in SLE 
+- Remove translate-toolkit which is not available in SLE
 
 -------------------------------------------------------------------
 Fri Jan 28 10:53:18 UTC 2022 - Jacek Tomasiak <jtomasiak@suse.com>
 
-- Re-add source-offset to _service. 
+- Re-add source-offset to _service.
 
 -------------------------------------------------------------------
 Fri Aug 13 11:23:02 UTC 2021 - Ludwig Nussel <lnussel@suse.de>

cockpit-machines.spec

@@ -17,7 +17,7 @@
 
 
 Name:           cockpit-machines
-Version:        328
+Version:        333
 Release:        0
 Summary:        Cockpit user interface for virtual machines
 License:        LGPL-2.1-or-later AND MIT
@@ -29,6 +29,8 @@ Source12:       update_version.sh
 %include %_sourcedir/node_modules.spec.inc
 Patch10:        hide-docs.patch
 Patch11:        load-css-overrides.patch
+Patch12:        uefi-default-firmware.patch
+Patch13:        nic-domain-not-found.patch
 BuildArch:      noarch
 BuildRequires:  appstream-glib
 BuildRequires:  make

nic-domain-not-found.patch

@@ -0,0 +1,36 @@
+From 6c982496f7b9cd9ef08308e1edd820b3910a7833 Mon Sep 17 00:00:00 2001
+From: Miika Alikirri <miika.alikirri@suse.com>
+Date: Wed, 25 Jun 2025 14:07:00 +0300
+Subject: [PATCH] nics: ignore domain not found error caused by domain being
+ removed
+
+If user is in the VMDetails page during migration, the VM might get
+deleted before domainInterfaceAddresses is done processing. This race
+condition can end up causing a confusing view where the UI shows a
+redundant "Domain not found" error, and the regular "VM doesn't exist"
+page at the same time
+---
+ src/components/vm/nics/vmNicsCard.tsx | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+diff --git a/src/components/vm/nics/vmNicsCard.jsx b/src/components/vm/nics/vmNicsCard.jsx
+index 8b309ac0..79efe152 100644
+--- a/src/components/vm/nics/vmNicsCard.jsx
++++ b/src/components/vm/nics/vmNicsCard.jsx
+@@ -239,8 +239,15 @@ export class VmNetworkTab extends React.Component {
+         domainInterfaceAddresses({ connectionName: this.props.vm.connectionName, objPath: this.props.vm.id })
+                 .then(domifaddressAllSources => {
+                     const allRejected = !domifaddressAllSources.some(promise => promise.status == 'fulfilled');
++                    // If user is in the VMDetails page during migration, the VM might get deleted
++                    // before domainInterfaceAddresses is done processing. This race condition can end up
++                    // causing a confusing view where the UI shows a redundant "Domain not found error"
++                    // and the regular VM doesn't exist page, at the same time.
++                    const domainNotFound = domifaddressAllSources.some(promise =>
++                        promise.status === 'rejected' && promise.reason?.message.startsWith("Domain not found:")
++                    );
+
+-                    if (allRejected)
++                    if (allRejected && !domainNotFound)
+                         this.props.onAddErrorNotification({
+                             text: cockpit.format(_("Failed to fetch the IP addresses of the interfaces present in $0"), this.props.vm.name),
+                             detail: [...new Set(domifaddressAllSources.map(promise => promise.reason ? promise.reason.message : ''))].join(', '),

uefi-default-firmware.patch

@@ -0,0 +1,71 @@
+From a7a02f9aaabf6cc4c92f672eb08752374f614a32 Mon Sep 17 00:00:00 2001
+From: Miika Alikirri <miika.alikirri@suse.com>
+Date: Wed, 9 Jul 2025 11:11:07 +0300
+Subject: Explicitly set UEFI as default firmware
+
+---
+ src/libvirtApi/domain.ts | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/libvirtApi/domain.ts b/src/libvirtApi/domain.ts
+index 88d39dab..61926d52 100644
+--- a/src/libvirtApi/domain.ts
++++ b/src/libvirtApi/domain.ts
+@@ -360,6 +360,7 @@ interface DomainSpec {
+     userPassword: string,
+     vmName: string,
+     sshKeys: string[],
++    firmware: 'bios' | 'uefi'
+ }
+ 
+ export async function domainCreate({
+@@ -415,6 +416,7 @@ export async function domainCreate({
+         userPassword,
+         vmName,
+         sshKeys,
++        firmware: "uefi",
+     };
+ 
+     logDebug(`CREATE_VM(${vmName}): install_machine.py '${JSON.stringify(args)}'`);
+-- 
+2.50.0
+
+
+From a5dcfb74c517aea09f17bd3efc0ef750c335e39b Mon Sep 17 00:00:00 2001
+From: Miika Alikirri <miika.alikirri@suse.com>
+Date: Thu, 10 Jul 2025 12:48:50 +0300
+Subject: libvirt: allow changing from UEFI to BIOS
+
+When UEFI is already selected and a user tries to switch to BIOS, not
+all the relevant UEFI related elements are removed
+
+This patch adds the functionality for removing loader and nvram if they
+are set
+---
+ src/libvirtApi/domain.ts | 10 ++++++++++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/src/libvirtApi/domain.ts b/src/libvirtApi/domain.ts
+index 61926d52..5ba12a0b 100644
+--- a/src/libvirtApi/domain.ts
++++ b/src/libvirtApi/domain.ts
+@@ -1297,6 +1297,16 @@ export async function domainSetOSFirmware({
+     if (loaderElem)
+         loaderElem.remove();
+ 
++    // remove efi related things so it gets actually disabled
++    if (!loaderType || loaderType === "bios") {
++        const fwElem = getSingleOptionalElem(osElem, "firmware");
++        if (fwElem)
++            fwElem.remove();
++        const nvramElem = getSingleOptionalElem(osElem, "nvram");
++        if (nvramElem)
++            nvramElem.remove();
++    }
++
+     if (!loaderType)
+         osElem.removeAttribute("firmware");
+     else
+-- 
+2.50.0
+