cockpit/cockpit-machines
SHA256
10
0
Fork 3
forked from pool/cockpit-machines
Code Pull Requests 1 Activity

Update suse_version requirement to function with the planned bump jsc#PED-15820 #24

Manually merged
abrooks merged 1 commits from abrooks/cockpit-machines:update-suse_version into main 2026-03-05 11:08:00 +01:00
Conversation 7 Commits 1 Files Changed 2 +6 -1
abrooks commented 2026-03-04 14:11:10 +01:00
Member
Copy Link
No description provided.
abrooks added 1 commit 2026-03-04 14:11:10 +01:00
Update suse_version requirement to function with the planned bump jsc#PED-15820 b868bc9778
autogits-devel requested review from factory_bot 2026-03-04 14:11:16 +01:00
autogits-devel requested review from legaldb 2026-03-04 14:11:16 +01:00
abrooks requested review from malikirri 2026-03-04 14:11:18 +01:00
malikirri requested changes 2026-03-04 14:17:09 +01:00
Dismissed
cockpit-machines.spec Outdated
@@ -43,3 +43,3 @@
Requires: libvirt-client
Requires: libvirt-dbus >= 1.2.0
%if 0%{?suse_version} != 1600
%if 0%{?suse_version} < 1600 && %{suse_version} >= 1699
malikirri commented 2026-03-04 14:17:04 +01:00
Member
Copy Link

This will always be false. Value can never be smaller than 1600 and bigger than or equal to 1699.

&& should be replaced with ||

This will always be false. Value can never be smaller than 1600 *and* bigger than or equal to 1699. `&&` should be replaced with `||`
legaldb commented 2026-03-04 14:25:02 +01:00
Member
Copy Link

Legal review in progress.

Legal review [in progress](https://legaldb.suse.de/reviews/details/508283).
report.md
2.2 KiB
autogits_obs_staging_bot commented 2026-03-04 15:18:54 +01:00
Member
Copy Link

Build successful, for more information go in https://build.opensuse.org/project/show/home:autogits_obs_staging_bot:cockpit:PR:159.

Build successful, for more information go in https://build.opensuse.org/project/show/home:autogits_obs_staging_bot:cockpit:PR:159.
abrooks force-pushed update-suse_version from b868bc9778 to 6454591111 2026-03-05 08:31:19 +01:00 Compare
abrooks requested review from malikirri 2026-03-05 08:31:23 +01:00
legaldb commented 2026-03-05 08:48:32 +01:00
Member
Copy Link

Legal review in progress.

Legal review [in progress](https://legaldb.suse.de/reviews/details/508502).
report.md
2.2 KiB
autogits_obs_staging_bot commented 2026-03-05 09:55:27 +01:00
Member
Copy Link

Build successful, for more information go in https://build.opensuse.org/project/show/home:autogits_obs_staging_bot:cockpit:PR:159.

Build successful, for more information go in https://build.opensuse.org/project/show/home:autogits_obs_staging_bot:cockpit:PR:159.
malikirri approved these changes 2026-03-05 11:00:32 +01:00
abrooks commented 2026-03-05 11:07:48 +01:00
Author
Member
Copy Link

merge ok

merge ok
autogits-devel removed review request for factory_bot 2026-03-05 11:07:55 +01:00
autogits-devel removed review request for legaldb 2026-03-05 11:07:55 +01:00
abrooks manually merged commit 6454591111 into main 2026-03-05 11:08:00 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
malikirri
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
abrooks adamm adamm_super autogits-devel autogits_obs_staging_bot factory_bot jzerebecki ldragon legaldb malikirri
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cockpit/cockpit-machines#24
Delete Branch "abrooks/cockpit-machines:update-suse_version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?