| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * STM32F2XX USART | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Permission is hereby granted, free of charge, to any person obtaining a copy | 
					
						
							|  |  |  |  * of this software and associated documentation files (the "Software"), to deal | 
					
						
							|  |  |  |  * in the Software without restriction, including without limitation the rights | 
					
						
							|  |  |  |  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | 
					
						
							|  |  |  |  * copies of the Software, and to permit persons to whom the Software is | 
					
						
							|  |  |  |  * furnished to do so, subject to the following conditions: | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * The above copyright notice and this permission notice shall be included in | 
					
						
							|  |  |  |  * all copies or substantial portions of the Software. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | 
					
						
							|  |  |  |  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | 
					
						
							|  |  |  |  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | 
					
						
							|  |  |  |  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | 
					
						
							|  |  |  |  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | 
					
						
							|  |  |  |  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | 
					
						
							|  |  |  |  * THE SOFTWARE. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-01-26 18:17:28 +00:00
										 |  |  | #include "qemu/osdep.h"
 | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | #include "hw/char/stm32f2xx_usart.h"
 | 
					
						
							| 
									
										
										
										
											2019-08-12 07:23:42 +02:00
										 |  |  | #include "hw/irq.h"
 | 
					
						
							| 
									
										
										
										
											2019-08-12 07:23:51 +02:00
										 |  |  | #include "hw/qdev-properties.h"
 | 
					
						
							| 
									
										
										
										
											2015-12-15 13:16:16 +01:00
										 |  |  | #include "qemu/log.h"
 | 
					
						
							| 
									
										
										
										
											2019-05-23 16:35:07 +02:00
										 |  |  | #include "qemu/module.h"
 | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  | #ifndef STM_USART_ERR_DEBUG
 | 
					
						
							|  |  |  | #define STM_USART_ERR_DEBUG 0
 | 
					
						
							|  |  |  | #endif
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #define DB_PRINT_L(lvl, fmt, args...) do { \
 | 
					
						
							|  |  |  |     if (STM_USART_ERR_DEBUG >= lvl) { \ | 
					
						
							|  |  |  |         qemu_log("%s: " fmt, __func__, ## args); \ | 
					
						
							|  |  |  |     } \ | 
					
						
							| 
									
										
											  
											
												maint: Fix macros with broken 'do/while(0); ' usage
The point of writing a macro embedded in a 'do { ... } while (0)'
loop (particularly if the macro has multiple statements or would
otherwise end with an 'if' statement) is so that the macro can be
used as a drop-in statement with the caller supplying the
trailing ';'.  Although our coding style frowns on brace-less 'if':
  if (cond)
    statement;
  else
    something else;
that is the classic case where failure to use do/while(0) wrapping
would cause the 'else' to pair with any embedded 'if' in the macro
rather than the intended outer 'if'.  But conversely, if the macro
includes an embedded ';', then the same brace-less coding style
would now have two statements, making the 'else' a syntax error
rather than pairing with the outer 'if'.  Thus, even though our
coding style with required braces is not impacted, ending a macro
with ';' makes our code harder to port to projects that use
brace-less styles.
The change should have no semantic impact.  I was not able to
fully compile-test all of the changes (as some of them are
examples of the ugly bit-rotting debug print statements that are
completely elided by default, and I didn't want to recompile
with the necessary -D witnesses - cleaning those up is left as a
bite-sized task for another day); I did, however, audit that for
all files touched, all callers of the changed macros DID supply
a trailing ';' at the callsite, and did not appear to be used
as part of a brace-less conditional.
Found mechanically via: $ git grep -B1 'while (0);' | grep -A1 \\\\
Signed-off-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20171201232433.25193-7-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2017-12-01 17:24:32 -06:00
										 |  |  | } while (0) | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  | #define DB_PRINT(fmt, args...) DB_PRINT_L(1, fmt, ## args)
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static int stm32f2xx_usart_can_receive(void *opaque) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = opaque; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!(s->usart_sr & USART_SR_RXNE)) { | 
					
						
							|  |  |  |         return 1; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void stm32f2xx_usart_receive(void *opaque, const uint8_t *buf, int size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = opaque; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!(s->usart_cr1 & USART_CR1_UE && s->usart_cr1 & USART_CR1_RE)) { | 
					
						
							|  |  |  |         /* USART not enabled - drop the chars */ | 
					
						
							|  |  |  |         DB_PRINT("Dropping the chars\n"); | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-01-21 10:23:10 +00:00
										 |  |  |     s->usart_dr = *buf; | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |     s->usart_sr |= USART_SR_RXNE; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (s->usart_cr1 & USART_CR1_RXNEIE) { | 
					
						
							|  |  |  |         qemu_set_irq(s->irq, 1); | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     DB_PRINT("Receiving: %c\n", s->usart_dr); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void stm32f2xx_usart_reset(DeviceState *dev) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = STM32F2XX_USART(dev); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     s->usart_sr = USART_SR_RESET; | 
					
						
							|  |  |  |     s->usart_dr = 0x00000000; | 
					
						
							|  |  |  |     s->usart_brr = 0x00000000; | 
					
						
							|  |  |  |     s->usart_cr1 = 0x00000000; | 
					
						
							|  |  |  |     s->usart_cr2 = 0x00000000; | 
					
						
							|  |  |  |     s->usart_cr3 = 0x00000000; | 
					
						
							|  |  |  |     s->usart_gtpr = 0x00000000; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     qemu_set_irq(s->irq, 0); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static uint64_t stm32f2xx_usart_read(void *opaque, hwaddr addr, | 
					
						
							|  |  |  |                                        unsigned int size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = opaque; | 
					
						
							|  |  |  |     uint64_t retvalue; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     DB_PRINT("Read 0x%"HWADDR_PRIx"\n", addr); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     switch (addr) { | 
					
						
							|  |  |  |     case USART_SR: | 
					
						
							|  |  |  |         retvalue = s->usart_sr; | 
					
						
							| 
									
										
										
										
											2016-10-22 12:52:59 +03:00
										 |  |  |         qemu_chr_fe_accept_input(&s->chr); | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |         return retvalue; | 
					
						
							|  |  |  |     case USART_DR: | 
					
						
							|  |  |  |         DB_PRINT("Value: 0x%" PRIx32 ", %c\n", s->usart_dr, (char) s->usart_dr); | 
					
						
							|  |  |  |         s->usart_sr &= ~USART_SR_RXNE; | 
					
						
							| 
									
										
										
										
											2016-10-22 12:52:59 +03:00
										 |  |  |         qemu_chr_fe_accept_input(&s->chr); | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |         qemu_set_irq(s->irq, 0); | 
					
						
							|  |  |  |         return s->usart_dr & 0x3FF; | 
					
						
							|  |  |  |     case USART_BRR: | 
					
						
							|  |  |  |         return s->usart_brr; | 
					
						
							|  |  |  |     case USART_CR1: | 
					
						
							|  |  |  |         return s->usart_cr1; | 
					
						
							|  |  |  |     case USART_CR2: | 
					
						
							|  |  |  |         return s->usart_cr2; | 
					
						
							|  |  |  |     case USART_CR3: | 
					
						
							|  |  |  |         return s->usart_cr3; | 
					
						
							|  |  |  |     case USART_GTPR: | 
					
						
							|  |  |  |         return s->usart_gtpr; | 
					
						
							|  |  |  |     default: | 
					
						
							|  |  |  |         qemu_log_mask(LOG_GUEST_ERROR, | 
					
						
							|  |  |  |                       "%s: Bad offset 0x%"HWADDR_PRIx"\n", __func__, addr); | 
					
						
							|  |  |  |         return 0; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     return 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void stm32f2xx_usart_write(void *opaque, hwaddr addr, | 
					
						
							|  |  |  |                                   uint64_t val64, unsigned int size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = opaque; | 
					
						
							|  |  |  |     uint32_t value = val64; | 
					
						
							|  |  |  |     unsigned char ch; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     DB_PRINT("Write 0x%" PRIx32 ", 0x%"HWADDR_PRIx"\n", value, addr); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     switch (addr) { | 
					
						
							|  |  |  |     case USART_SR: | 
					
						
							|  |  |  |         if (value <= 0x3FF) { | 
					
						
							| 
									
										
										
										
											2018-02-22 15:12:51 +00:00
										 |  |  |             /* I/O being synchronous, TXE is always set. In addition, it may
 | 
					
						
							|  |  |  |                only be set by hardware, so keep it set here. */ | 
					
						
							|  |  |  |             s->usart_sr = value | USART_SR_TXE; | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |         } else { | 
					
						
							|  |  |  |             s->usart_sr &= value; | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |         if (!(s->usart_sr & USART_SR_RXNE)) { | 
					
						
							|  |  |  |             qemu_set_irq(s->irq, 0); | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_DR: | 
					
						
							|  |  |  |         if (value < 0xF000) { | 
					
						
							|  |  |  |             ch = value; | 
					
						
							| 
									
										
										
										
											2016-10-22 12:52:59 +03:00
										 |  |  |             /* XXX this blocks entire thread. Rewrite to use
 | 
					
						
							|  |  |  |              * qemu_chr_fe_write and background I/O callbacks */ | 
					
						
							|  |  |  |             qemu_chr_fe_write_all(&s->chr, &ch, 1); | 
					
						
							| 
									
										
										
										
											2018-02-22 15:12:51 +00:00
										 |  |  |             /* XXX I/O are currently synchronous, making it impossible for
 | 
					
						
							|  |  |  |                software to observe transient states where TXE or TC aren't | 
					
						
							|  |  |  |                set. Unlike TXE however, which is read-only, software may | 
					
						
							|  |  |  |                clear TC by writing 0 to the SR register, so set it again | 
					
						
							|  |  |  |                on each write. */ | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |             s->usart_sr |= USART_SR_TC; | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_BRR: | 
					
						
							|  |  |  |         s->usart_brr = value; | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_CR1: | 
					
						
							|  |  |  |         s->usart_cr1 = value; | 
					
						
							|  |  |  |             if (s->usart_cr1 & USART_CR1_RXNEIE && | 
					
						
							|  |  |  |                 s->usart_sr & USART_SR_RXNE) { | 
					
						
							|  |  |  |                 qemu_set_irq(s->irq, 1); | 
					
						
							|  |  |  |             } | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_CR2: | 
					
						
							|  |  |  |         s->usart_cr2 = value; | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_CR3: | 
					
						
							|  |  |  |         s->usart_cr3 = value; | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     case USART_GTPR: | 
					
						
							|  |  |  |         s->usart_gtpr = value; | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     default: | 
					
						
							|  |  |  |         qemu_log_mask(LOG_GUEST_ERROR, | 
					
						
							|  |  |  |                       "%s: Bad offset 0x%"HWADDR_PRIx"\n", __func__, addr); | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static const MemoryRegionOps stm32f2xx_usart_ops = { | 
					
						
							|  |  |  |     .read = stm32f2xx_usart_read, | 
					
						
							|  |  |  |     .write = stm32f2xx_usart_write, | 
					
						
							|  |  |  |     .endianness = DEVICE_NATIVE_ENDIAN, | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-06 16:59:32 +01:00
										 |  |  | static Property stm32f2xx_usart_properties[] = { | 
					
						
							|  |  |  |     DEFINE_PROP_CHR("chardev", STM32F2XXUsartState, chr), | 
					
						
							|  |  |  |     DEFINE_PROP_END_OF_LIST(), | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | static void stm32f2xx_usart_init(Object *obj) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = STM32F2XX_USART(obj); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     memory_region_init_io(&s->mmio, obj, &stm32f2xx_usart_ops, s, | 
					
						
							| 
									
										
										
										
											2018-11-19 15:29:08 +00:00
										 |  |  |                           TYPE_STM32F2XX_USART, 0x400); | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  |     sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); | 
					
						
							| 
									
										
										
										
											2016-06-06 16:59:32 +01:00
										 |  |  | } | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-06 16:59:32 +01:00
										 |  |  | static void stm32f2xx_usart_realize(DeviceState *dev, Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     STM32F2XXUsartState *s = STM32F2XX_USART(dev); | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-10-22 12:52:59 +03:00
										 |  |  |     qemu_chr_fe_set_handlers(&s->chr, stm32f2xx_usart_can_receive, | 
					
						
							| 
									
										
										
										
											2017-07-06 15:08:49 +03:00
										 |  |  |                              stm32f2xx_usart_receive, NULL, NULL, | 
					
						
							|  |  |  |                              s, NULL, true); | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void stm32f2xx_usart_class_init(ObjectClass *klass, void *data) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     DeviceClass *dc = DEVICE_CLASS(klass); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     dc->reset = stm32f2xx_usart_reset; | 
					
						
							| 
									
										
										
										
											2020-01-10 19:30:32 +04:00
										 |  |  |     device_class_set_props(dc, stm32f2xx_usart_properties); | 
					
						
							| 
									
										
										
										
											2016-06-06 16:59:32 +01:00
										 |  |  |     dc->realize = stm32f2xx_usart_realize; | 
					
						
							| 
									
										
										
										
											2015-03-11 13:21:05 +00:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static const TypeInfo stm32f2xx_usart_info = { | 
					
						
							|  |  |  |     .name          = TYPE_STM32F2XX_USART, | 
					
						
							|  |  |  |     .parent        = TYPE_SYS_BUS_DEVICE, | 
					
						
							|  |  |  |     .instance_size = sizeof(STM32F2XXUsartState), | 
					
						
							|  |  |  |     .instance_init = stm32f2xx_usart_init, | 
					
						
							|  |  |  |     .class_init    = stm32f2xx_usart_class_init, | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void stm32f2xx_usart_register_types(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     type_register_static(&stm32f2xx_usart_info); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | type_init(stm32f2xx_usart_register_types) |