| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Intel XScale PXA255/270 DMA controller. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (c) 2006 Openedhand Ltd. | 
					
						
							|  |  |  |  * Copyright (c) 2006 Thorsten Zitterell | 
					
						
							|  |  |  |  * Written by Andrzej Zaborowski <balrog@zabor.org> | 
					
						
							|  |  |  |  * | 
					
						
							| 
									
										
										
										
											2011-06-26 12:21:35 +10:00
										 |  |  |  * This code is licensed under the GPL. | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-01-26 18:17:05 +00:00
										 |  |  | #include "qemu/osdep.h"
 | 
					
						
							| 
									
										
										
										
											2020-05-18 16:03:07 +02:00
										 |  |  | #include "qemu/log.h"
 | 
					
						
							| 
									
										
										
										
											2013-02-04 15:40:22 +01:00
										 |  |  | #include "hw/hw.h"
 | 
					
						
							| 
									
										
										
										
											2019-08-12 07:23:42 +02:00
										 |  |  | #include "hw/irq.h"
 | 
					
						
							| 
									
										
										
										
											2019-08-12 07:23:51 +02:00
										 |  |  | #include "hw/qdev-properties.h"
 | 
					
						
							| 
									
										
										
										
											2013-02-05 17:06:20 +01:00
										 |  |  | #include "hw/arm/pxa.h"
 | 
					
						
							| 
									
										
										
										
											2013-02-04 15:40:22 +01:00
										 |  |  | #include "hw/sysbus.h"
 | 
					
						
							| 
									
										
										
										
											2019-08-12 07:23:45 +02:00
										 |  |  | #include "migration/vmstate.h"
 | 
					
						
							| 
									
										
										
										
											2016-06-14 15:59:14 +01:00
										 |  |  | #include "qapi/error.h"
 | 
					
						
							| 
									
										
										
										
											2019-05-23 16:35:07 +02:00
										 |  |  | #include "qemu/module.h"
 | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  | #define PXA255_DMA_NUM_CHANNELS 16
 | 
					
						
							|  |  |  | #define PXA27X_DMA_NUM_CHANNELS 32
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #define PXA2XX_DMA_NUM_REQUESTS 75
 | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  | typedef struct { | 
					
						
							| 
									
										
										
										
											2012-03-14 15:37:53 +00:00
										 |  |  |     uint32_t descr; | 
					
						
							|  |  |  |     uint32_t src; | 
					
						
							|  |  |  |     uint32_t dest; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     uint32_t cmd; | 
					
						
							|  |  |  |     uint32_t state; | 
					
						
							|  |  |  |     int request; | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  | } PXA2xxDMAChannel; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2013-07-26 16:43:17 +02:00
										 |  |  | #define TYPE_PXA2XX_DMA "pxa2xx-dma"
 | 
					
						
							|  |  |  | #define PXA2XX_DMA(obj) OBJECT_CHECK(PXA2xxDMAState, (obj), TYPE_PXA2XX_DMA)
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | typedef struct PXA2xxDMAState { | 
					
						
							| 
									
										
										
										
											2013-07-26 16:43:17 +02:00
										 |  |  |     SysBusDevice parent_obj; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |     MemoryRegion iomem; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     qemu_irq irq; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     uint32_t stopintr; | 
					
						
							|  |  |  |     uint32_t eorintr; | 
					
						
							|  |  |  |     uint32_t rasintr; | 
					
						
							|  |  |  |     uint32_t startintr; | 
					
						
							|  |  |  |     uint32_t endintr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     uint32_t align; | 
					
						
							|  |  |  |     uint32_t pio; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     int channels; | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  |     PXA2xxDMAChannel *chan; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     uint8_t req[PXA2XX_DMA_NUM_REQUESTS]; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  |     /* Flag to avoid recursive DMA invocations.  */ | 
					
						
							|  |  |  |     int running; | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | } PXA2xxDMAState; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  | #define DCSR0	0x0000	/* DMA Control / Status register for Channel 0 */
 | 
					
						
							|  |  |  | #define DCSR31	0x007c	/* DMA Control / Status register for Channel 31 */
 | 
					
						
							|  |  |  | #define DALGN	0x00a0	/* DMA Alignment register */
 | 
					
						
							|  |  |  | #define DPCSR	0x00a4	/* DMA Programmed I/O Control Status register */
 | 
					
						
							|  |  |  | #define DRQSR0	0x00e0	/* DMA DREQ<0> Status register */
 | 
					
						
							|  |  |  | #define DRQSR1	0x00e4	/* DMA DREQ<1> Status register */
 | 
					
						
							|  |  |  | #define DRQSR2	0x00e8	/* DMA DREQ<2> Status register */
 | 
					
						
							|  |  |  | #define DINT	0x00f0	/* DMA Interrupt register */
 | 
					
						
							|  |  |  | #define DRCMR0	0x0100	/* Request to Channel Map register 0 */
 | 
					
						
							|  |  |  | #define DRCMR63	0x01fc	/* Request to Channel Map register 63 */
 | 
					
						
							|  |  |  | #define D_CH0	0x0200	/* Channel 0 Descriptor start */
 | 
					
						
							|  |  |  | #define DRCMR64	0x1100	/* Request to Channel Map register 64 */
 | 
					
						
							|  |  |  | #define DRCMR74	0x1128	/* Request to Channel Map register 74 */
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | /* Per-channel register */ | 
					
						
							|  |  |  | #define DDADR	0x00
 | 
					
						
							|  |  |  | #define DSADR	0x01
 | 
					
						
							|  |  |  | #define DTADR	0x02
 | 
					
						
							|  |  |  | #define DCMD	0x03
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | /* Bit-field masks */ | 
					
						
							|  |  |  | #define DRCMR_CHLNUM		0x1f
 | 
					
						
							|  |  |  | #define DRCMR_MAPVLD		(1 << 7)
 | 
					
						
							|  |  |  | #define DDADR_STOP		(1 << 0)
 | 
					
						
							|  |  |  | #define DDADR_BREN		(1 << 1)
 | 
					
						
							|  |  |  | #define DCMD_LEN		0x1fff
 | 
					
						
							|  |  |  | #define DCMD_WIDTH(x)		(1 << ((((x) >> 14) & 3) - 1))
 | 
					
						
							|  |  |  | #define DCMD_SIZE(x)		(4 << (((x) >> 16) & 3))
 | 
					
						
							|  |  |  | #define DCMD_FLYBYT		(1 << 19)
 | 
					
						
							|  |  |  | #define DCMD_FLYBYS		(1 << 20)
 | 
					
						
							|  |  |  | #define DCMD_ENDIRQEN		(1 << 21)
 | 
					
						
							|  |  |  | #define DCMD_STARTIRQEN		(1 << 22)
 | 
					
						
							|  |  |  | #define DCMD_CMPEN		(1 << 25)
 | 
					
						
							|  |  |  | #define DCMD_FLOWTRG		(1 << 28)
 | 
					
						
							|  |  |  | #define DCMD_FLOWSRC		(1 << 29)
 | 
					
						
							|  |  |  | #define DCMD_INCTRGADDR		(1 << 30)
 | 
					
						
							|  |  |  | #define DCMD_INCSRCADDR		(1 << 31)
 | 
					
						
							|  |  |  | #define DCSR_BUSERRINTR		(1 << 0)
 | 
					
						
							|  |  |  | #define DCSR_STARTINTR		(1 << 1)
 | 
					
						
							|  |  |  | #define DCSR_ENDINTR		(1 << 2)
 | 
					
						
							|  |  |  | #define DCSR_STOPINTR		(1 << 3)
 | 
					
						
							|  |  |  | #define DCSR_RASINTR		(1 << 4)
 | 
					
						
							|  |  |  | #define DCSR_REQPEND		(1 << 8)
 | 
					
						
							|  |  |  | #define DCSR_EORINT		(1 << 9)
 | 
					
						
							|  |  |  | #define DCSR_CMPST		(1 << 10)
 | 
					
						
							|  |  |  | #define DCSR_MASKRUN		(1 << 22)
 | 
					
						
							|  |  |  | #define DCSR_RASIRQEN		(1 << 23)
 | 
					
						
							|  |  |  | #define DCSR_CLRCMPST		(1 << 24)
 | 
					
						
							|  |  |  | #define DCSR_SETCMPST		(1 << 25)
 | 
					
						
							|  |  |  | #define DCSR_EORSTOPEN		(1 << 26)
 | 
					
						
							|  |  |  | #define DCSR_EORJMPEN		(1 << 27)
 | 
					
						
							|  |  |  | #define DCSR_EORIRQEN		(1 << 28)
 | 
					
						
							|  |  |  | #define DCSR_STOPIRQEN		(1 << 29)
 | 
					
						
							|  |  |  | #define DCSR_NODESCFETCH	(1 << 30)
 | 
					
						
							|  |  |  | #define DCSR_RUN		(1 << 31)
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  | static inline void pxa2xx_dma_update(PXA2xxDMAState *s, int ch) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							|  |  |  |     if (ch >= 0) { | 
					
						
							|  |  |  |         if ((s->chan[ch].state & DCSR_STOPIRQEN) && | 
					
						
							|  |  |  |                 (s->chan[ch].state & DCSR_STOPINTR)) | 
					
						
							|  |  |  |             s->stopintr |= 1 << ch; | 
					
						
							|  |  |  |         else | 
					
						
							|  |  |  |             s->stopintr &= ~(1 << ch); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if ((s->chan[ch].state & DCSR_EORIRQEN) && | 
					
						
							|  |  |  |                 (s->chan[ch].state & DCSR_EORINT)) | 
					
						
							|  |  |  |             s->eorintr |= 1 << ch; | 
					
						
							|  |  |  |         else | 
					
						
							|  |  |  |             s->eorintr &= ~(1 << ch); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if ((s->chan[ch].state & DCSR_RASIRQEN) && | 
					
						
							|  |  |  |                 (s->chan[ch].state & DCSR_RASINTR)) | 
					
						
							|  |  |  |             s->rasintr |= 1 << ch; | 
					
						
							|  |  |  |         else | 
					
						
							|  |  |  |             s->rasintr &= ~(1 << ch); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (s->chan[ch].state & DCSR_STARTINTR) | 
					
						
							|  |  |  |             s->startintr |= 1 << ch; | 
					
						
							|  |  |  |         else | 
					
						
							|  |  |  |             s->startintr &= ~(1 << ch); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (s->chan[ch].state & DCSR_ENDINTR) | 
					
						
							|  |  |  |             s->endintr |= 1 << ch; | 
					
						
							|  |  |  |         else | 
					
						
							|  |  |  |             s->endintr &= ~(1 << ch); | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (s->stopintr | s->eorintr | s->rasintr | s->startintr | s->endintr) | 
					
						
							|  |  |  |         qemu_irq_raise(s->irq); | 
					
						
							|  |  |  |     else | 
					
						
							|  |  |  |         qemu_irq_lower(s->irq); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static inline void pxa2xx_dma_descriptor_fetch( | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  |                 PXA2xxDMAState *s, int ch) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							|  |  |  |     uint32_t desc[4]; | 
					
						
							| 
									
										
										
										
											2012-10-23 12:30:10 +02:00
										 |  |  |     hwaddr daddr = s->chan[ch].descr & ~0xf; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     if ((s->chan[ch].descr & DDADR_BREN) && (s->chan[ch].state & DCSR_CMPST)) | 
					
						
							|  |  |  |         daddr += 32; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2013-04-12 20:53:58 +02:00
										 |  |  |     cpu_physical_memory_read(daddr, desc, 16); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     s->chan[ch].descr = desc[DDADR]; | 
					
						
							|  |  |  |     s->chan[ch].src = desc[DSADR]; | 
					
						
							|  |  |  |     s->chan[ch].dest = desc[DTADR]; | 
					
						
							|  |  |  |     s->chan[ch].cmd = desc[DCMD]; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (s->chan[ch].cmd & DCMD_FLOWSRC) | 
					
						
							|  |  |  |         s->chan[ch].src &= ~3; | 
					
						
							|  |  |  |     if (s->chan[ch].cmd & DCMD_FLOWTRG) | 
					
						
							|  |  |  |         s->chan[ch].dest &= ~3; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (s->chan[ch].cmd & (DCMD_CMPEN | DCMD_FLYBYS | DCMD_FLYBYT)) | 
					
						
							| 
									
										
										
										
											2017-11-08 14:56:31 -08:00
										 |  |  |         printf("%s: unsupported mode in channel %i\n", __func__, ch); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  |     if (s->chan[ch].cmd & DCMD_STARTIRQEN) | 
					
						
							|  |  |  |         s->chan[ch].state |= DCSR_STARTINTR; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  | static void pxa2xx_dma_run(PXA2xxDMAState *s) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							|  |  |  |     int c, srcinc, destinc; | 
					
						
							|  |  |  |     uint32_t n, size; | 
					
						
							|  |  |  |     uint32_t width; | 
					
						
							|  |  |  |     uint32_t length; | 
					
						
							| 
									
										
										
										
											2008-09-20 08:07:15 +00:00
										 |  |  |     uint8_t buffer[32]; | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  |     PXA2xxDMAChannel *ch; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  |     if (s->running ++) | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     while (s->running) { | 
					
						
							|  |  |  |         s->running = 1; | 
					
						
							|  |  |  |         for (c = 0; c < s->channels; c ++) { | 
					
						
							|  |  |  |             ch = &s->chan[c]; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |             while ((ch->state & DCSR_RUN) && !(ch->state & DCSR_STOPINTR)) { | 
					
						
							|  |  |  |                 /* Test for pending requests */ | 
					
						
							|  |  |  |                 if ((ch->cmd & (DCMD_FLOWSRC | DCMD_FLOWTRG)) && !ch->request) | 
					
						
							|  |  |  |                     break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                 length = ch->cmd & DCMD_LEN; | 
					
						
							|  |  |  |                 size = DCMD_SIZE(ch->cmd); | 
					
						
							|  |  |  |                 width = DCMD_WIDTH(ch->cmd); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                 srcinc = (ch->cmd & DCMD_INCSRCADDR) ? width : 0; | 
					
						
							|  |  |  |                 destinc = (ch->cmd & DCMD_INCTRGADDR) ? width : 0; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                 while (length) { | 
					
						
							|  |  |  |                     size = MIN(length, size); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     for (n = 0; n < size; n += width) { | 
					
						
							|  |  |  |                         cpu_physical_memory_read(ch->src, buffer + n, width); | 
					
						
							|  |  |  |                         ch->src += srcinc; | 
					
						
							|  |  |  |                     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     for (n = 0; n < size; n += width) { | 
					
						
							|  |  |  |                         cpu_physical_memory_write(ch->dest, buffer + n, width); | 
					
						
							|  |  |  |                         ch->dest += destinc; | 
					
						
							|  |  |  |                     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     length -= size; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     if ((ch->cmd & (DCMD_FLOWSRC | DCMD_FLOWTRG)) && | 
					
						
							|  |  |  |                             !ch->request) { | 
					
						
							|  |  |  |                         ch->state |= DCSR_EORINT; | 
					
						
							|  |  |  |                         if (ch->state & DCSR_EORSTOPEN) | 
					
						
							|  |  |  |                             ch->state |= DCSR_STOPINTR; | 
					
						
							|  |  |  |                         if ((ch->state & DCSR_EORJMPEN) && | 
					
						
							|  |  |  |                                         !(ch->state & DCSR_NODESCFETCH)) | 
					
						
							|  |  |  |                             pxa2xx_dma_descriptor_fetch(s, c); | 
					
						
							|  |  |  |                         break; | 
					
						
							| 
									
										
										
										
											2018-12-13 23:37:37 +01:00
										 |  |  |                     } | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |                 } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                 ch->cmd = (ch->cmd & ~DCMD_LEN) | length; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                 /* Is the transfer complete now? */ | 
					
						
							|  |  |  |                 if (!length) { | 
					
						
							|  |  |  |                     if (ch->cmd & DCMD_ENDIRQEN) | 
					
						
							|  |  |  |                         ch->state |= DCSR_ENDINTR; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     if ((ch->state & DCSR_NODESCFETCH) || | 
					
						
							|  |  |  |                                 (ch->descr & DDADR_STOP) || | 
					
						
							|  |  |  |                                 (ch->state & DCSR_EORSTOPEN)) { | 
					
						
							|  |  |  |                         ch->state |= DCSR_STOPINTR; | 
					
						
							|  |  |  |                         ch->state &= ~DCSR_RUN; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                         break; | 
					
						
							|  |  |  |                     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |                     ch->state |= DCSR_STOPINTR; | 
					
						
							|  |  |  |                     break; | 
					
						
							|  |  |  |                 } | 
					
						
							|  |  |  |             } | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         s->running --; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-10-23 12:30:10 +02:00
										 |  |  | static uint64_t pxa2xx_dma_read(void *opaque, hwaddr offset, | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |                                 unsigned size) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  |     PXA2xxDMAState *s = (PXA2xxDMAState *) opaque; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     unsigned int channel; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |     if (size != 4) { | 
					
						
							| 
									
										
										
										
											2020-05-18 16:03:07 +02:00
										 |  |  |         qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad access width %u\n", | 
					
						
							|  |  |  |                       __func__, size); | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |         return 5; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     switch (offset) { | 
					
						
							|  |  |  |     case DRCMR64 ... DRCMR74: | 
					
						
							|  |  |  |         offset -= DRCMR64 - DRCMR0 - (64 << 2); | 
					
						
							|  |  |  |         /* Fall through */ | 
					
						
							|  |  |  |     case DRCMR0 ... DRCMR63: | 
					
						
							|  |  |  |         channel = (offset - DRCMR0) >> 2; | 
					
						
							|  |  |  |         return s->req[channel]; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DRQSR0: | 
					
						
							|  |  |  |     case DRQSR1: | 
					
						
							|  |  |  |     case DRQSR2: | 
					
						
							|  |  |  |         return 0; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DCSR0 ... DCSR31: | 
					
						
							|  |  |  |         channel = offset >> 2; | 
					
						
							| 
									
										
										
										
											2018-12-13 23:37:37 +01:00
										 |  |  |         if (s->chan[channel].request) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |             return s->chan[channel].state | DCSR_REQPEND; | 
					
						
							|  |  |  |         return s->chan[channel].state; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DINT: | 
					
						
							|  |  |  |         return s->stopintr | s->eorintr | s->rasintr | | 
					
						
							|  |  |  |                 s->startintr | s->endintr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DALGN: | 
					
						
							|  |  |  |         return s->align; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DPCSR: | 
					
						
							|  |  |  |         return s->pio; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (offset >= D_CH0 && offset < D_CH0 + (s->channels << 4)) { | 
					
						
							|  |  |  |         channel = (offset - D_CH0) >> 4; | 
					
						
							|  |  |  |         switch ((offset & 0x0f) >> 2) { | 
					
						
							|  |  |  |         case DDADR: | 
					
						
							|  |  |  |             return s->chan[channel].descr; | 
					
						
							|  |  |  |         case DSADR: | 
					
						
							|  |  |  |             return s->chan[channel].src; | 
					
						
							|  |  |  |         case DTADR: | 
					
						
							|  |  |  |             return s->chan[channel].dest; | 
					
						
							|  |  |  |         case DCMD: | 
					
						
							|  |  |  |             return s->chan[channel].cmd; | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |     } | 
					
						
							| 
									
										
										
										
											2020-05-18 16:03:07 +02:00
										 |  |  |     qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIX "\n", | 
					
						
							|  |  |  |                   __func__, offset); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     return 7; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-10-23 12:30:10 +02:00
										 |  |  | static void pxa2xx_dma_write(void *opaque, hwaddr offset, | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |                              uint64_t value, unsigned size) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2009-05-10 01:44:56 +01:00
										 |  |  |     PXA2xxDMAState *s = (PXA2xxDMAState *) opaque; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     unsigned int channel; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |     if (size != 4) { | 
					
						
							| 
									
										
										
										
											2020-05-18 16:03:07 +02:00
										 |  |  |         qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad access width %u\n", | 
					
						
							|  |  |  |                       __func__, size); | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |         return; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     switch (offset) { | 
					
						
							|  |  |  |     case DRCMR64 ... DRCMR74: | 
					
						
							|  |  |  |         offset -= DRCMR64 - DRCMR0 - (64 << 2); | 
					
						
							|  |  |  |         /* Fall through */ | 
					
						
							|  |  |  |     case DRCMR0 ... DRCMR63: | 
					
						
							|  |  |  |         channel = (offset - DRCMR0) >> 2; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (value & DRCMR_MAPVLD) | 
					
						
							|  |  |  |             if ((value & DRCMR_CHLNUM) > s->channels) | 
					
						
							| 
									
										
										
										
											2009-05-08 02:35:15 +01:00
										 |  |  |                 hw_error("%s: Bad DMA channel %i\n", | 
					
						
							| 
									
										
										
										
											2017-11-08 14:56:31 -08:00
										 |  |  |                          __func__, (unsigned)value & DRCMR_CHLNUM); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  |         s->req[channel] = value; | 
					
						
							|  |  |  |         break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DRQSR0: | 
					
						
							|  |  |  |     case DRQSR1: | 
					
						
							|  |  |  |     case DRQSR2: | 
					
						
							|  |  |  |         /* Nothing to do */ | 
					
						
							|  |  |  |         break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DCSR0 ... DCSR31: | 
					
						
							|  |  |  |         channel = offset >> 2; | 
					
						
							|  |  |  |         s->chan[channel].state &= 0x0000071f & ~(value & | 
					
						
							|  |  |  |                         (DCSR_EORINT | DCSR_ENDINTR | | 
					
						
							|  |  |  |                          DCSR_STARTINTR | DCSR_BUSERRINTR)); | 
					
						
							|  |  |  |         s->chan[channel].state |= value & 0xfc800000; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (s->chan[channel].state & DCSR_STOPIRQEN) | 
					
						
							|  |  |  |             s->chan[channel].state &= ~DCSR_STOPINTR; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (value & DCSR_NODESCFETCH) { | 
					
						
							|  |  |  |             /* No-descriptor-fetch mode */ | 
					
						
							| 
									
										
										
										
											2007-11-17 18:43:47 +00:00
										 |  |  |             if (value & DCSR_RUN) { | 
					
						
							|  |  |  |                 s->chan[channel].state &= ~DCSR_STOPINTR; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |                 pxa2xx_dma_run(s); | 
					
						
							| 
									
										
										
										
											2007-11-17 18:43:47 +00:00
										 |  |  |             } | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |         } else { | 
					
						
							|  |  |  |             /* Descriptor-fetch mode */ | 
					
						
							|  |  |  |             if (value & DCSR_RUN) { | 
					
						
							|  |  |  |                 s->chan[channel].state &= ~DCSR_STOPINTR; | 
					
						
							|  |  |  |                 pxa2xx_dma_descriptor_fetch(s, channel); | 
					
						
							|  |  |  |                 pxa2xx_dma_run(s); | 
					
						
							|  |  |  |             } | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         /* Shouldn't matter as our DMA is synchronous.  */ | 
					
						
							|  |  |  |         if (!(value & (DCSR_RUN | DCSR_MASKRUN))) | 
					
						
							|  |  |  |             s->chan[channel].state |= DCSR_STOPINTR; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         if (value & DCSR_CLRCMPST) | 
					
						
							|  |  |  |             s->chan[channel].state &= ~DCSR_CMPST; | 
					
						
							|  |  |  |         if (value & DCSR_SETCMPST) | 
					
						
							|  |  |  |             s->chan[channel].state |= DCSR_CMPST; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |         pxa2xx_dma_update(s, channel); | 
					
						
							|  |  |  |         break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DALGN: | 
					
						
							|  |  |  |         s->align = value; | 
					
						
							|  |  |  |         break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     case DPCSR: | 
					
						
							|  |  |  |         s->pio = value & 0x80000001; | 
					
						
							|  |  |  |         break; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     default: | 
					
						
							|  |  |  |         if (offset >= D_CH0 && offset < D_CH0 + (s->channels << 4)) { | 
					
						
							|  |  |  |             channel = (offset - D_CH0) >> 4; | 
					
						
							|  |  |  |             switch ((offset & 0x0f) >> 2) { | 
					
						
							|  |  |  |             case DDADR: | 
					
						
							|  |  |  |                 s->chan[channel].descr = value; | 
					
						
							|  |  |  |                 break; | 
					
						
							|  |  |  |             case DSADR: | 
					
						
							|  |  |  |                 s->chan[channel].src = value; | 
					
						
							|  |  |  |                 break; | 
					
						
							|  |  |  |             case DTADR: | 
					
						
							|  |  |  |                 s->chan[channel].dest = value; | 
					
						
							|  |  |  |                 break; | 
					
						
							|  |  |  |             case DCMD: | 
					
						
							|  |  |  |                 s->chan[channel].cmd = value; | 
					
						
							|  |  |  |                 break; | 
					
						
							|  |  |  |             default: | 
					
						
							|  |  |  |                 goto fail; | 
					
						
							|  |  |  |             } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |             break; | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |     fail: | 
					
						
							| 
									
										
										
										
											2020-05-18 16:03:07 +02:00
										 |  |  |         qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIX "\n", | 
					
						
							|  |  |  |                       __func__, offset); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  |     } | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  | static const MemoryRegionOps pxa2xx_dma_ops = { | 
					
						
							|  |  |  |     .read = pxa2xx_dma_read, | 
					
						
							|  |  |  |     .write = pxa2xx_dma_write, | 
					
						
							|  |  |  |     .endianness = DEVICE_NATIVE_ENDIAN, | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-03-03 15:06:03 +01:00
										 |  |  | static void pxa2xx_dma_request(void *opaque, int req_num, int on) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     PXA2xxDMAState *s = opaque; | 
					
						
							|  |  |  |     int ch; | 
					
						
							|  |  |  |     if (req_num < 0 || req_num >= PXA2XX_DMA_NUM_REQUESTS) | 
					
						
							| 
									
										
										
										
											2017-11-08 14:56:31 -08:00
										 |  |  |         hw_error("%s: Bad DMA request %i\n", __func__, req_num); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:06:03 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  |     if (!(s->req[req_num] & DRCMR_MAPVLD)) | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     ch = s->req[req_num] & DRCMR_CHLNUM; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!s->chan[ch].request && on) | 
					
						
							|  |  |  |         s->chan[ch].state |= DCSR_RASINTR; | 
					
						
							|  |  |  |     else | 
					
						
							|  |  |  |         s->chan[ch].state &= ~DCSR_RASINTR; | 
					
						
							|  |  |  |     if (s->chan[ch].request && !on) | 
					
						
							|  |  |  |         s->chan[ch].state |= DCSR_EORINT; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     s->chan[ch].request = on; | 
					
						
							|  |  |  |     if (on) { | 
					
						
							|  |  |  |         pxa2xx_dma_run(s); | 
					
						
							|  |  |  |         pxa2xx_dma_update(s, ch); | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2007-05-24 18:50:09 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-14 15:59:14 +01:00
										 |  |  | static void pxa2xx_dma_init(Object *obj) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     DeviceState *dev = DEVICE(obj); | 
					
						
							|  |  |  |     PXA2xxDMAState *s = PXA2XX_DMA(obj); | 
					
						
							|  |  |  |     SysBusDevice *sbd = SYS_BUS_DEVICE(obj); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     memset(s->req, 0, sizeof(uint8_t) * PXA2XX_DMA_NUM_REQUESTS); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     qdev_init_gpio_in(dev, pxa2xx_dma_request, PXA2XX_DMA_NUM_REQUESTS); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     memory_region_init_io(&s->iomem, obj, &pxa2xx_dma_ops, s, | 
					
						
							|  |  |  |                           "pxa2xx.dma", 0x00010000); | 
					
						
							|  |  |  |     sysbus_init_mmio(sbd, &s->iomem); | 
					
						
							|  |  |  |     sysbus_init_irq(sbd, &s->irq); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void pxa2xx_dma_realize(DeviceState *dev, Error **errp) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2013-07-26 16:43:17 +02:00
										 |  |  |     PXA2xxDMAState *s = PXA2XX_DMA(dev); | 
					
						
							| 
									
										
										
										
											2011-11-14 11:55:27 +02:00
										 |  |  |     int i; | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  |     if (s->channels <= 0) { | 
					
						
							| 
									
										
										
										
											2016-06-14 15:59:14 +01:00
										 |  |  |         error_setg(errp, "channels value invalid"); | 
					
						
							|  |  |  |         return; | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     } | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-10-09 17:56:35 +02:00
										 |  |  |     s->chan = g_new0(PXA2xxDMAChannel, s->channels); | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  |     for (i = 0; i < s->channels; i ++) | 
					
						
							|  |  |  |         s->chan[i].state = DCSR_STOPINTR; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-10-23 12:30:10 +02:00
										 |  |  | DeviceState *pxa27x_dma_init(hwaddr base, qemu_irq irq) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     DeviceState *dev; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion.  More to come in
this series.
Coccinelle script:
    @ depends on !(file in "hw/arm/highbank.c")@
    expression bus, type_name, dev, expr;
    @@
    -    dev = qdev_create(bus, type_name);
    +    dev = qdev_new(type_name);
         ... when != dev = expr
    -    qdev_init_nofail(dev);
    +    qdev_realize_and_unref(dev, bus, &error_fatal);
    @@
    expression bus, type_name, dev, expr;
    identifier DOWN;
    @@
    -    dev = DOWN(qdev_create(bus, type_name));
    +    dev = DOWN(qdev_new(type_name));
         ... when != dev = expr
    -    qdev_init_nofail(DEVICE(dev));
    +    qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
    @@
    expression bus, type_name, expr;
    identifier dev;
    @@
    -    DeviceState *dev = qdev_create(bus, type_name);
    +    DeviceState *dev = qdev_new(type_name);
         ... when != dev = expr
    -    qdev_init_nofail(dev);
    +    qdev_realize_and_unref(dev, bus, &error_fatal);
    @@
    expression bus, type_name, dev, expr, errp;
    symbol true;
    @@
    -    dev = qdev_create(bus, type_name);
    +    dev = qdev_new(type_name);
         ... when != dev = expr
    -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
    +    qdev_realize_and_unref(dev, bus, errp);
    @@
    expression bus, type_name, expr, errp;
    identifier dev;
    symbol true;
    @@
    -    DeviceState *dev = qdev_create(bus, type_name);
    +    DeviceState *dev = qdev_new(type_name);
         ... when != dev = expr
    -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
    +    qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name.  Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
											
										 
											2020-06-10 07:31:58 +02:00
										 |  |  |     dev = qdev_new("pxa2xx-dma"); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     qdev_prop_set_int32(dev, "channels", PXA27X_DMA_NUM_CHANNELS); | 
					
						
							| 
									
										
											  
											
												sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
    @@
    expression dev, errp;
    @@
    -    qdev_realize(DEVICE(dev), NULL, errp);
    +    sysbus_realize(SYS_BUS_DEVICE(dev), errp);
    @@
    expression sysbus_dev, dev, errp;
    @@
    +    sysbus_dev = SYS_BUS_DEVICE(dev);
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(sysbus_dev, errp);
    -    sysbus_dev = SYS_BUS_DEVICE(dev);
    @@
    expression sysbus_dev, dev, errp;
    expression expr;
    @@
         sysbus_dev = SYS_BUS_DEVICE(dev);
         ... when != dev = expr;
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(sysbus_dev, errp);
    @@
    expression dev, errp;
    @@
    -    qdev_realize_and_unref(DEVICE(dev), NULL, errp);
    +    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
    @@
    expression dev, errp;
    @@
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
											
										 
											2020-06-10 07:32:34 +02:00
										 |  |  |     sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2013-01-20 02:47:33 +01:00
										 |  |  |     sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); | 
					
						
							|  |  |  |     sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  |     return dev; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-10-23 12:30:10 +02:00
										 |  |  | DeviceState *pxa255_dma_init(hwaddr base, qemu_irq irq) | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     DeviceState *dev; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion.  More to come in
this series.
Coccinelle script:
    @ depends on !(file in "hw/arm/highbank.c")@
    expression bus, type_name, dev, expr;
    @@
    -    dev = qdev_create(bus, type_name);
    +    dev = qdev_new(type_name);
         ... when != dev = expr
    -    qdev_init_nofail(dev);
    +    qdev_realize_and_unref(dev, bus, &error_fatal);
    @@
    expression bus, type_name, dev, expr;
    identifier DOWN;
    @@
    -    dev = DOWN(qdev_create(bus, type_name));
    +    dev = DOWN(qdev_new(type_name));
         ... when != dev = expr
    -    qdev_init_nofail(DEVICE(dev));
    +    qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
    @@
    expression bus, type_name, expr;
    identifier dev;
    @@
    -    DeviceState *dev = qdev_create(bus, type_name);
    +    DeviceState *dev = qdev_new(type_name);
         ... when != dev = expr
    -    qdev_init_nofail(dev);
    +    qdev_realize_and_unref(dev, bus, &error_fatal);
    @@
    expression bus, type_name, dev, expr, errp;
    symbol true;
    @@
    -    dev = qdev_create(bus, type_name);
    +    dev = qdev_new(type_name);
         ... when != dev = expr
    -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
    +    qdev_realize_and_unref(dev, bus, errp);
    @@
    expression bus, type_name, expr, errp;
    identifier dev;
    symbol true;
    @@
    -    DeviceState *dev = qdev_create(bus, type_name);
    +    DeviceState *dev = qdev_new(type_name);
         ... when != dev = expr
    -    object_property_set_bool(OBJECT(dev), true, "realized", errp);
    +    qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name.  Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
											
										 
											2020-06-10 07:31:58 +02:00
										 |  |  |     dev = qdev_new("pxa2xx-dma"); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |     qdev_prop_set_int32(dev, "channels", PXA27X_DMA_NUM_CHANNELS); | 
					
						
							| 
									
										
											  
											
												sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
    @@
    expression dev, errp;
    @@
    -    qdev_realize(DEVICE(dev), NULL, errp);
    +    sysbus_realize(SYS_BUS_DEVICE(dev), errp);
    @@
    expression sysbus_dev, dev, errp;
    @@
    +    sysbus_dev = SYS_BUS_DEVICE(dev);
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(sysbus_dev, errp);
    -    sysbus_dev = SYS_BUS_DEVICE(dev);
    @@
    expression sysbus_dev, dev, errp;
    expression expr;
    @@
         sysbus_dev = SYS_BUS_DEVICE(dev);
         ... when != dev = expr;
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(sysbus_dev, errp);
    @@
    expression dev, errp;
    @@
    -    qdev_realize_and_unref(DEVICE(dev), NULL, errp);
    +    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
    @@
    expression dev, errp;
    @@
    -    qdev_realize_and_unref(dev, NULL, errp);
    +    sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
											
										 
											2020-06-10 07:32:34 +02:00
										 |  |  |     sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2013-01-20 02:47:33 +01:00
										 |  |  |     sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); | 
					
						
							|  |  |  |     sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  |     return dev; | 
					
						
							| 
									
										
										
										
											2007-04-30 01:26:42 +00:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | static bool is_version_0(void *opaque, int version_id) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     return version_id == 0; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static VMStateDescription vmstate_pxa2xx_dma_chan = { | 
					
						
							|  |  |  |     .name = "pxa2xx_dma_chan", | 
					
						
							|  |  |  |     .version_id = 1, | 
					
						
							|  |  |  |     .minimum_version_id = 1, | 
					
						
							|  |  |  |     .fields = (VMStateField[]) { | 
					
						
							| 
									
										
										
										
											2012-03-14 15:37:53 +00:00
										 |  |  |         VMSTATE_UINT32(descr, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_UINT32(src, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_UINT32(dest, PXA2xxDMAChannel), | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  |         VMSTATE_UINT32(cmd, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_UINT32(state, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_INT32(request, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_END_OF_LIST(), | 
					
						
							|  |  |  |     }, | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static VMStateDescription vmstate_pxa2xx_dma = { | 
					
						
							|  |  |  |     .name = "pxa2xx_dma", | 
					
						
							|  |  |  |     .version_id = 1, | 
					
						
							|  |  |  |     .minimum_version_id = 0, | 
					
						
							|  |  |  |     .fields = (VMStateField[]) { | 
					
						
							|  |  |  |         VMSTATE_UNUSED_TEST(is_version_0, 4), | 
					
						
							|  |  |  |         VMSTATE_UINT32(stopintr, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(eorintr, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(rasintr, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(startintr, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(endintr, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(align, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_UINT32(pio, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_BUFFER(req, PXA2xxDMAState), | 
					
						
							|  |  |  |         VMSTATE_STRUCT_VARRAY_POINTER_INT32(chan, PXA2xxDMAState, channels, | 
					
						
							|  |  |  |                 vmstate_pxa2xx_dma_chan, PXA2xxDMAChannel), | 
					
						
							|  |  |  |         VMSTATE_END_OF_LIST(), | 
					
						
							|  |  |  |     }, | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-01-24 13:12:29 -06:00
										 |  |  | static Property pxa2xx_dma_properties[] = { | 
					
						
							|  |  |  |     DEFINE_PROP_INT32("channels", PXA2xxDMAState, channels, -1), | 
					
						
							|  |  |  |     DEFINE_PROP_END_OF_LIST(), | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void pxa2xx_dma_class_init(ObjectClass *klass, void *data) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2011-12-07 21:34:16 -06:00
										 |  |  |     DeviceClass *dc = DEVICE_CLASS(klass); | 
					
						
							| 
									
										
										
										
											2012-01-24 13:12:29 -06:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2011-12-07 21:34:16 -06:00
										 |  |  |     dc->desc = "PXA2xx DMA controller"; | 
					
						
							|  |  |  |     dc->vmsd = &vmstate_pxa2xx_dma; | 
					
						
							| 
									
										
										
										
											2020-01-10 19:30:32 +04:00
										 |  |  |     device_class_set_props(dc, pxa2xx_dma_properties); | 
					
						
							| 
									
										
										
										
											2016-06-14 15:59:14 +01:00
										 |  |  |     dc->realize = pxa2xx_dma_realize; | 
					
						
							| 
									
										
										
										
											2012-01-24 13:12:29 -06:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2013-01-10 16:19:07 +01:00
										 |  |  | static const TypeInfo pxa2xx_dma_info = { | 
					
						
							| 
									
										
										
										
											2013-07-26 16:43:17 +02:00
										 |  |  |     .name          = TYPE_PXA2XX_DMA, | 
					
						
							| 
									
										
										
										
											2011-12-07 21:34:16 -06:00
										 |  |  |     .parent        = TYPE_SYS_BUS_DEVICE, | 
					
						
							|  |  |  |     .instance_size = sizeof(PXA2xxDMAState), | 
					
						
							| 
									
										
										
										
											2016-06-14 15:59:14 +01:00
										 |  |  |     .instance_init = pxa2xx_dma_init, | 
					
						
							| 
									
										
										
										
											2011-12-07 21:34:16 -06:00
										 |  |  |     .class_init    = pxa2xx_dma_class_init, | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-02-09 15:20:55 +01:00
										 |  |  | static void pxa2xx_dma_register_types(void) | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2011-12-07 21:34:16 -06:00
										 |  |  |     type_register_static(&pxa2xx_dma_info); | 
					
						
							| 
									
										
										
										
											2011-03-03 15:04:51 +01:00
										 |  |  | } | 
					
						
							| 
									
										
										
										
											2012-02-09 15:20:55 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  | type_init(pxa2xx_dma_register_types) |