dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
19e950d9d47d3efe4c8d5c6c872a53889a54363c
qemu/tests/qapi-schema/union-base-empty.err

2 lines
90 B
Plaintext
Raw Normal View History

qapi: Fix broken discriminator error messages check_union() checks the discriminator exists in base and makes sense. Two error messages mention the base. These are broken for anonymous bases, as demonstrated by tests flat-union-invalid-discriminator and flat-union-invalid-if-discriminator.err. The third one doesn't bother. First broken when commit ac4338f8eb "qapi: Allow anonymous base for flat union" (v2.6.0) neglected to adjust the "not a member of base" error message. Commit ccadd6bcba "qapi: Add 'if' to implicit struct members" (v4.0.0) then cloned the flawed error message. Dumb them down not to mention the base. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190914153506.2151-11-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
2019-09-14 17:34:57 +02:00
tests/qapi-schema/union-base-empty.json:5: Discriminator 'type' is not a member of 'base'
Reference in New Issue Copy Permalink