| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | /* Coverity Scan model
 | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (C) 2014 Red Hat, Inc. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Authors: | 
					
						
							|  |  |  |  *  Markus Armbruster <armbru@redhat.com> | 
					
						
							|  |  |  |  *  Paolo Bonzini <pbonzini@redhat.com> | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * This work is licensed under the terms of the GNU GPL, version 2 or, at your | 
					
						
							|  |  |  |  * option, any later version.  See the COPYING file in the top-level directory. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | /*
 | 
					
						
							|  |  |  |  * This is the source code for our Coverity user model file.  The | 
					
						
							|  |  |  |  * purpose of user models is to increase scanning accuracy by explaining | 
					
						
							|  |  |  |  * code Coverity can't see (out of tree libraries) or doesn't | 
					
						
							|  |  |  |  * sufficiently understand.  Better accuracy means both fewer false | 
					
						
							|  |  |  |  * positives and more true defects.  Memory leaks in particular. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * - A model file can't import any header files.  Some built-in primitives are | 
					
						
							|  |  |  |  *   available but not wchar_t, NULL etc. | 
					
						
							|  |  |  |  * - Modeling doesn't need full structs and typedefs. Rudimentary structs | 
					
						
							|  |  |  |  *   and similar types are sufficient. | 
					
						
							|  |  |  |  * - An uninitialized local variable signifies that the variable could be | 
					
						
							|  |  |  |  *   any value. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * The model file must be uploaded by an admin in the analysis settings of | 
					
						
							|  |  |  |  * http://scan.coverity.com/projects/378
 | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #define NULL ((void *)0)
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | typedef unsigned char uint8_t; | 
					
						
							|  |  |  | typedef char int8_t; | 
					
						
							|  |  |  | typedef unsigned int uint32_t; | 
					
						
							|  |  |  | typedef int int32_t; | 
					
						
							|  |  |  | typedef long ssize_t; | 
					
						
							|  |  |  | typedef unsigned long long uint64_t; | 
					
						
							|  |  |  | typedef long long int64_t; | 
					
						
							|  |  |  | typedef _Bool bool; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  | typedef struct va_list_str *va_list; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | /* exec.c */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | typedef struct AddressSpace AddressSpace; | 
					
						
							|  |  |  | typedef uint64_t hwaddr; | 
					
						
							| 
									
										
										
										
											2015-04-26 16:49:24 +01:00
										 |  |  | typedef uint32_t MemTxResult; | 
					
						
							|  |  |  | typedef uint64_t MemTxAttrs; | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-05-04 14:18:09 +02:00
										 |  |  | static void __bufwrite(uint8_t *buf, ssize_t len) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							|  |  |  |     int first, last; | 
					
						
							|  |  |  |     __coverity_negative_sink__(len); | 
					
						
							|  |  |  |     if (len == 0) return; | 
					
						
							|  |  |  |     buf[0] = first; | 
					
						
							|  |  |  |     buf[len-1] = last; | 
					
						
							|  |  |  |     __coverity_writeall__(buf); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-05-04 14:18:09 +02:00
										 |  |  | static void __bufread(uint8_t *buf, ssize_t len) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							|  |  |  |     __coverity_negative_sink__(len); | 
					
						
							|  |  |  |     if (len == 0) return; | 
					
						
							|  |  |  |     int first = buf[0]; | 
					
						
							|  |  |  |     int last = buf[len-1]; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-03-15 09:16:41 +01:00
										 |  |  | MemTxResult address_space_read(AddressSpace *as, hwaddr addr, | 
					
						
							|  |  |  |                                MemTxAttrs attrs, | 
					
						
							|  |  |  |                                uint8_t *buf, int len) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2015-04-26 16:49:24 +01:00
										 |  |  |     MemTxResult result; | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  |     // TODO: investigate impact of treating reads as producing
 | 
					
						
							|  |  |  |     // tainted data, with __coverity_tainted_data_argument__(buf).
 | 
					
						
							| 
									
										
										
										
											2017-03-15 09:16:41 +01:00
										 |  |  |     __bufwrite(buf, len); | 
					
						
							|  |  |  |     return result; | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-03-15 09:16:41 +01:00
										 |  |  | MemTxResult address_space_write(AddressSpace *as, hwaddr addr, | 
					
						
							|  |  |  |                                 MemTxAttrs attrs, | 
					
						
							|  |  |  |                                 const uint8_t *buf, int len) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     MemTxResult result; | 
					
						
							|  |  |  |     __bufread(buf, len); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  |     return result; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2017-03-15 09:16:41 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | /* Tainting */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | typedef struct {} name2keysym_t; | 
					
						
							|  |  |  | static int get_keysym(const name2keysym_t *table, | 
					
						
							|  |  |  |                       const char *name) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     int result; | 
					
						
							|  |  |  |     if (result > 0) { | 
					
						
							|  |  |  |         __coverity_tainted_string_sanitize_content__(name); | 
					
						
							|  |  |  |         return result; | 
					
						
							|  |  |  |     } else { | 
					
						
							|  |  |  |         return 0; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2018-05-14 16:12:18 +02:00
										 |  |  | /* Replay data is considered trusted.  */ | 
					
						
							|  |  |  | uint8_t replay_get_byte(void) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2018-06-26 10:56:42 +02:00
										 |  |  |     uint8_t byte; | 
					
						
							|  |  |  |     return byte; | 
					
						
							| 
									
										
										
										
											2018-05-14 16:12:18 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * GLib memory allocation functions. | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  |  * | 
					
						
							|  |  |  |  * Note that we ignore the fact that g_malloc of 0 bytes returns NULL, | 
					
						
							|  |  |  |  * and g_realloc of 0 bytes frees the pointer. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Modeling this would result in Coverity flagging a lot of memory | 
					
						
							|  |  |  |  * allocations as potentially returning NULL, and asking us to check | 
					
						
							|  |  |  |  * whether the result of the allocation is NULL or not.  However, the | 
					
						
							|  |  |  |  * resulting pointer should never be dereferenced anyway, and in fact | 
					
						
							|  |  |  |  * it is not in the vast majority of cases. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * If a dereference did happen, this would suppress a defect report | 
					
						
							|  |  |  |  * for an actual null pointer dereference.  But it's too unlikely to | 
					
						
							|  |  |  |  * be worth wading through the false positives, and with some luck | 
					
						
							|  |  |  |  * we'll get a buffer overflow reported anyway. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Allocation primitives, cannot return NULL | 
					
						
							|  |  |  |  * See also Coverity's library/generic/libc/all/all.c | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_malloc_n(size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     size_t sz; | 
					
						
							|  |  |  |     void *ptr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_negative_sink__(nmemb); | 
					
						
							|  |  |  |     __coverity_negative_sink__(size); | 
					
						
							|  |  |  |     sz = nmemb * size; | 
					
						
							| 
									
										
										
										
											2015-03-12 12:24:26 +01:00
										 |  |  |     ptr = __coverity_alloc__(sz); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     __coverity_mark_as_uninitialized_buffer__(ptr); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(ptr, "g_free"); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return ptr; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_malloc0_n(size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     size_t sz; | 
					
						
							|  |  |  |     void *ptr; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_negative_sink__(nmemb); | 
					
						
							|  |  |  |     __coverity_negative_sink__(size); | 
					
						
							|  |  |  |     sz = nmemb * size; | 
					
						
							| 
									
										
										
										
											2015-03-12 12:24:26 +01:00
										 |  |  |     ptr = __coverity_alloc__(sz); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     __coverity_writeall0__(ptr); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(ptr, "g_free"); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return ptr; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_realloc_n(void *ptr, size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     size_t sz; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_negative_sink__(nmemb); | 
					
						
							|  |  |  |     __coverity_negative_sink__(size); | 
					
						
							|  |  |  |     sz = nmemb * size; | 
					
						
							|  |  |  |     __coverity_escape__(ptr); | 
					
						
							| 
									
										
										
										
											2015-03-12 12:24:26 +01:00
										 |  |  |     ptr = __coverity_alloc__(sz); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     /*
 | 
					
						
							|  |  |  |      * Memory beyond the old size isn't actually initialized.  Can't | 
					
						
							|  |  |  |      * model that.  See Coverity's realloc() model | 
					
						
							|  |  |  |      */ | 
					
						
							|  |  |  |     __coverity_writeall__(ptr); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(ptr, "g_free"); | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return ptr; | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void g_free(void *ptr) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     __coverity_free__(ptr); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_freed__(ptr, "g_free"); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Derive the g_try_FOO_n() from the g_FOO_n() by adding indeterminate | 
					
						
							|  |  |  |  * out of memory conditions | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_try_malloc_n(size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     int nomem; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (nomem) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  |     return g_malloc_n(nmemb, size); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_try_malloc0_n(size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     int nomem; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (nomem) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  |     return g_malloc0_n(nmemb, size); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_try_realloc_n(void *ptr, size_t nmemb, size_t size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     int nomem; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (nomem) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  |     return g_realloc_n(ptr, nmemb, size); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | /* Trivially derive the g_FOO() from the g_FOO_n() */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_malloc(size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_malloc_n(1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void *g_malloc0(size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_malloc0_n(1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void *g_realloc(void *ptr, size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_realloc_n(ptr, 1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void *g_try_malloc(size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_try_malloc_n(1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void *g_try_malloc0(size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_try_malloc0_n(1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  | void *g_try_realloc(void *ptr, size_t size) | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | { | 
					
						
							| 
									
										
											  
											
												coverity: Improve model for GLib memory allocation
In current versions of GLib, g_new() may expand into g_malloc_n().
When it does, Coverity can't see the memory allocation, because we
don't model g_malloc_n().  Similarly for g_new0(), g_renew(),
g_try_new(), g_try_new0(), g_try_renew().
Model g_malloc_n(), g_malloc0_n(), g_realloc_n().  Model
g_try_malloc_n(), g_try_malloc0_n(), g_try_realloc_n() by adding
indeterminate out of memory conditions on top.
To avoid undue duplication, replace the existing models for g_malloc()
& friends by trivial wrappers around g_malloc_n() & friends.
In a local scan, this flags four additional RESOURCE_LEAKs and one
NULL_RETURNS.
The NULL_RETURNS is a false positive: Coverity can now see that
g_try_malloc(l1_sz * sizeof(uint64_t)) in
qcow2_check_metadata_overlap() may return NULL, but is too stupid to
recognize that a loop executing l1_sz times won't be entered then.
Three out of the four RESOURCE_LEAKs appear genuine.  The false
positive is in ppce500_prep_device_tree(): the pointer dies, but a
pointer to a struct member escapes, and we get the pointer back for
freeing with container_of().  Too funky for Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
											
										 
											2015-01-22 11:21:37 +01:00
										 |  |  |     return g_try_realloc_n(ptr, 1, size); | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-11-30 17:32:32 +01:00
										 |  |  | /* Other memory allocation functions */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void *g_memdup(const void *ptr, unsigned size) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     unsigned char *dup; | 
					
						
							|  |  |  |     unsigned i; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!ptr) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     dup = g_malloc(size); | 
					
						
							|  |  |  |     for (i = 0; i < size; i++) | 
					
						
							|  |  |  |         dup[i] = ((unsigned char *)ptr)[i]; | 
					
						
							|  |  |  |     return dup; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * GLib string allocation functions | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | char *g_strdup(const char *s) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     char *dup; | 
					
						
							|  |  |  |     size_t i; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!s) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_string_null_sink__(s); | 
					
						
							|  |  |  |     __coverity_string_size_sink__(s); | 
					
						
							|  |  |  |     dup = __coverity_alloc_nosize__(); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(dup, "g_free"); | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  |     for (i = 0; (dup[i] = s[i]); i++) ; | 
					
						
							|  |  |  |     return dup; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | char *g_strndup(const char *s, size_t n) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     char *dup; | 
					
						
							|  |  |  |     size_t i; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_negative_sink__(n); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (!s) { | 
					
						
							|  |  |  |         return NULL; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     dup = g_malloc(n + 1); | 
					
						
							|  |  |  |     for (i = 0; i < n && (dup[i] = s[i]); i++) ; | 
					
						
							|  |  |  |     dup[i] = 0; | 
					
						
							|  |  |  |     return dup; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | char *g_strdup_printf(const char *format, ...) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     char ch, *s; | 
					
						
							|  |  |  |     size_t len; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_string_null_sink__(format); | 
					
						
							|  |  |  |     __coverity_string_size_sink__(format); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     ch = *format; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     s = __coverity_alloc_nosize__(); | 
					
						
							|  |  |  |     __coverity_writeall__(s); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(s, "g_free"); | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  |     return s; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | char *g_strdup_vprintf(const char *format, va_list ap) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     char ch, *s; | 
					
						
							|  |  |  |     size_t len; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     __coverity_string_null_sink__(format); | 
					
						
							|  |  |  |     __coverity_string_size_sink__(format); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     ch = *format; | 
					
						
							|  |  |  |     ch = *(char *)ap; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     s = __coverity_alloc_nosize__(); | 
					
						
							|  |  |  |     __coverity_writeall__(s); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(s, "g_free"); | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  | 
 | 
					
						
							|  |  |  |     return len; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | char *g_strconcat(const char *s, ...) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     char *s; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     /*
 | 
					
						
							|  |  |  |      * Can't model: last argument must be null, the others | 
					
						
							|  |  |  |      * null-terminated strings | 
					
						
							|  |  |  |      */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     s = __coverity_alloc_nosize__(); | 
					
						
							|  |  |  |     __coverity_writeall__(s); | 
					
						
							| 
									
										
										
										
											2015-01-26 21:37:15 +01:00
										 |  |  |     __coverity_mark_as_afm_allocated__(s, "g_free"); | 
					
						
							| 
									
										
										
										
											2015-01-26 15:05:11 +01:00
										 |  |  |     return s; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | /* Other glib functions */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-12-17 08:20:33 +01:00
										 |  |  | typedef struct pollfd GPollFD; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | int poll(); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | int g_poll (GPollFD *fds, unsigned nfds, int timeout) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     return poll(fds, nfds, timeout); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2014-03-26 12:45:49 +01:00
										 |  |  | typedef struct _GIOChannel GIOChannel; | 
					
						
							|  |  |  | GIOChannel *g_io_channel_unix_new(int fd) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     GIOChannel *c = g_malloc0(sizeof(GIOChannel)); | 
					
						
							|  |  |  |     __coverity_escape__(fd); | 
					
						
							|  |  |  |     return c; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void g_assertion_message_expr(const char     *domain, | 
					
						
							|  |  |  |                               const char     *file, | 
					
						
							|  |  |  |                               int             line, | 
					
						
							|  |  |  |                               const char     *func, | 
					
						
							|  |  |  |                               const char     *expr) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     __coverity_panic__(); | 
					
						
							|  |  |  | } |