| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Virtio MEM PCI device | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (C) 2020 Red Hat, Inc. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Authors: | 
					
						
							|  |  |  |  *  David Hildenbrand <david@redhat.com> | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * This work is licensed under the terms of the GNU GPL, version 2. | 
					
						
							|  |  |  |  * See the COPYING file in the top-level directory. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #include "qemu/osdep.h"
 | 
					
						
							|  |  |  | #include "virtio-mem-pci.h"
 | 
					
						
							|  |  |  | #include "hw/mem/memory-device.h"
 | 
					
						
							|  |  |  | #include "qapi/error.h"
 | 
					
						
							| 
									
										
										
										
											2020-09-13 21:53:46 +02:00
										 |  |  | #include "qapi/qapi-events-machine.h"
 | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  | #include "qapi/qapi-events-misc.h"
 | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *mem_pci = VIRTIO_MEM_PCI(vpci_dev); | 
					
						
							|  |  |  |     DeviceState *vdev = DEVICE(&mem_pci->vdev); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-07-27 13:59:05 +02:00
										 |  |  |     virtio_pci_force_virtio_1(vpci_dev); | 
					
						
							|  |  |  |     qdev_realize(vdev, BUS(&vpci_dev->bus), errp); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr, | 
					
						
							|  |  |  |                                     Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
											  
											
												qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
    void object_property_set_FOO(Object *obj, FOO_TYPE value,
                                 const char *name, Error **errp)
Having to pass value before name feels grating.  Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
    @@
    identifier fun = {
        object_property_get, object_property_parse, object_property_set_str,
        object_property_set_link, object_property_set_bool,
        object_property_set_int, object_property_set_uint, object_property_set,
        object_property_set_qobject
    };
    expression obj, v, name, errp;
    @@
    -    fun(obj, v, name, errp)
    +    fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information".  Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually.  The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
											
										 
											2020-07-07 18:05:54 +02:00
										 |  |  |     object_property_set_uint(OBJECT(md), VIRTIO_MEM_ADDR_PROP, addr, errp); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static uint64_t virtio_mem_pci_get_addr(const MemoryDeviceState *md) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_ADDR_PROP, | 
					
						
							|  |  |  |                                     &error_abort); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static MemoryRegion *virtio_mem_pci_get_memory_region(MemoryDeviceState *md, | 
					
						
							|  |  |  |                                                       Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = VIRTIO_MEM_PCI(md); | 
					
						
							| 
									
										
										
										
											2023-06-01 11:34:52 +02:00
										 |  |  |     VirtIOMEM *vmem = &pci_mem->vdev; | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  |     VirtIOMEMClass *vmc = VIRTIO_MEM_GET_CLASS(vmem); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     return vmc->get_memory_region(vmem, errp); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static uint64_t virtio_mem_pci_get_plugged_size(const MemoryDeviceState *md, | 
					
						
							|  |  |  |                                                 Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_SIZE_PROP, | 
					
						
							|  |  |  |                                     errp); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_fill_device_info(const MemoryDeviceState *md, | 
					
						
							|  |  |  |                                             MemoryDeviceInfo *info) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtioMEMDeviceInfo *vi = g_new0(VirtioMEMDeviceInfo, 1); | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = VIRTIO_MEM_PCI(md); | 
					
						
							| 
									
										
										
										
											2023-06-01 11:34:52 +02:00
										 |  |  |     VirtIOMEM *vmem = &pci_mem->vdev; | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  |     VirtIOMEMClass *vpc = VIRTIO_MEM_GET_CLASS(vmem); | 
					
						
							|  |  |  |     DeviceState *dev = DEVICE(md); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     if (dev->id) { | 
					
						
							|  |  |  |         vi->id = g_strdup(dev->id); | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     /* let the real device handle everything else */ | 
					
						
							|  |  |  |     vpc->fill_device_info(vmem, vi); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     info->u.virtio_mem.data = vi; | 
					
						
							|  |  |  |     info->type = MEMORY_DEVICE_INFO_KIND_VIRTIO_MEM; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-10-08 10:30:29 +02:00
										 |  |  | static uint64_t virtio_mem_pci_get_min_alignment(const MemoryDeviceState *md) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_BLOCK_SIZE_PROP, | 
					
						
							|  |  |  |                                     &error_abort); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  | static void virtio_mem_pci_size_change_notify(Notifier *notifier, void *data) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = container_of(notifier, VirtIOMEMPCI, | 
					
						
							|  |  |  |                                          size_change_notifier); | 
					
						
							|  |  |  |     DeviceState *dev = DEVICE(pci_mem); | 
					
						
							| 
									
										
										
										
											2021-09-29 18:24:44 +02:00
										 |  |  |     char *qom_path = object_get_canonical_path(OBJECT(dev)); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  |     const uint64_t * const size_p = data; | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2022-11-04 17:06:57 +01:00
										 |  |  |     qapi_event_send_memory_device_size_change(dev->id, *size_p, qom_path); | 
					
						
							| 
									
										
										
										
											2021-09-29 18:24:44 +02:00
										 |  |  |     g_free(qom_path); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2023-07-11 17:34:45 +02:00
										 |  |  | static void virtio_mem_pci_unplug_request_check(VirtIOMDPCI *vmd, Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = VIRTIO_MEM_PCI(vmd); | 
					
						
							|  |  |  |     VirtIOMEM *vmem = &pci_mem->vdev; | 
					
						
							|  |  |  |     VirtIOMEMClass *vpc = VIRTIO_MEM_GET_CLASS(vmem); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     vpc->unplug_request_check(vmem, errp); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_get_requested_size(Object *obj, Visitor *v, | 
					
						
							|  |  |  |                                               const char *name, void *opaque, | 
					
						
							|  |  |  |                                               Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = VIRTIO_MEM_PCI(obj); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     object_property_get(OBJECT(&pci_mem->vdev), name, v, errp); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_set_requested_size(Object *obj, Visitor *v, | 
					
						
							|  |  |  |                                               const char *name, void *opaque, | 
					
						
							|  |  |  |                                               Error **errp) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *pci_mem = VIRTIO_MEM_PCI(obj); | 
					
						
							|  |  |  |     DeviceState *dev = DEVICE(obj); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     /*
 | 
					
						
							|  |  |  |      * If we passed virtio_mem_pci_unplug_request_check(), making sure that | 
					
						
							|  |  |  |      * the requested size is 0, don't allow modifying the requested size | 
					
						
							|  |  |  |      * anymore, otherwise the VM might end up hotplugging memory before | 
					
						
							|  |  |  |      * handling the unplug request. | 
					
						
							|  |  |  |      */ | 
					
						
							|  |  |  |     if (dev->pending_deleted_event) { | 
					
						
							|  |  |  |         error_setg(errp, "'%s' cannot be changed if the device is in the" | 
					
						
							|  |  |  |                    " process of unplug", name); | 
					
						
							|  |  |  |         return; | 
					
						
							|  |  |  |     } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     object_property_set(OBJECT(&pci_mem->vdev), name, v, errp); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | static void virtio_mem_pci_class_init(ObjectClass *klass, void *data) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     DeviceClass *dc = DEVICE_CLASS(klass); | 
					
						
							|  |  |  |     VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass); | 
					
						
							|  |  |  |     PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass); | 
					
						
							|  |  |  |     MemoryDeviceClass *mdc = MEMORY_DEVICE_CLASS(klass); | 
					
						
							| 
									
										
										
										
											2023-07-11 17:34:45 +02:00
										 |  |  |     VirtIOMDPCIClass *vmdc = VIRTIO_MD_PCI_CLASS(klass); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  |     k->realize = virtio_mem_pci_realize; | 
					
						
							|  |  |  |     set_bit(DEVICE_CATEGORY_MISC, dc->categories); | 
					
						
							|  |  |  |     pcidev_k->revision = VIRTIO_PCI_ABI_VERSION; | 
					
						
							|  |  |  |     pcidev_k->class_id = PCI_CLASS_OTHERS; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     mdc->get_addr = virtio_mem_pci_get_addr; | 
					
						
							|  |  |  |     mdc->set_addr = virtio_mem_pci_set_addr; | 
					
						
							|  |  |  |     mdc->get_plugged_size = virtio_mem_pci_get_plugged_size; | 
					
						
							|  |  |  |     mdc->get_memory_region = virtio_mem_pci_get_memory_region; | 
					
						
							|  |  |  |     mdc->fill_device_info = virtio_mem_pci_fill_device_info; | 
					
						
							| 
									
										
										
										
											2020-10-08 10:30:29 +02:00
										 |  |  |     mdc->get_min_alignment = virtio_mem_pci_get_min_alignment; | 
					
						
							| 
									
										
										
										
											2023-07-11 17:34:45 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  |     vmdc->unplug_request_check = virtio_mem_pci_unplug_request_check; | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_instance_init(Object *obj) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     VirtIOMEMPCI *dev = VIRTIO_MEM_PCI(obj); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  |     VirtIOMEMClass *vmc; | 
					
						
							|  |  |  |     VirtIOMEM *vmem; | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  |     virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev), | 
					
						
							|  |  |  |                                 TYPE_VIRTIO_MEM); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  |     dev->size_change_notifier.notify = virtio_mem_pci_size_change_notify; | 
					
						
							| 
									
										
										
										
											2023-06-01 11:34:52 +02:00
										 |  |  |     vmem = &dev->vdev; | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:44 +02:00
										 |  |  |     vmc = VIRTIO_MEM_GET_CLASS(vmem); | 
					
						
							|  |  |  |     /*
 | 
					
						
							|  |  |  |      * We never remove the notifier again, as we expect both devices to | 
					
						
							|  |  |  |      * disappear at the same time. | 
					
						
							|  |  |  |      */ | 
					
						
							|  |  |  |     vmc->add_size_change_notifier(vmem, &dev->size_change_notifier); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  |     object_property_add_alias(obj, VIRTIO_MEM_BLOCK_SIZE_PROP, | 
					
						
							|  |  |  |                               OBJECT(&dev->vdev), VIRTIO_MEM_BLOCK_SIZE_PROP); | 
					
						
							|  |  |  |     object_property_add_alias(obj, VIRTIO_MEM_SIZE_PROP, OBJECT(&dev->vdev), | 
					
						
							|  |  |  |                               VIRTIO_MEM_SIZE_PROP); | 
					
						
							| 
									
										
										
										
											2023-07-11 17:34:45 +02:00
										 |  |  |     object_property_add(obj, VIRTIO_MEM_REQUESTED_SIZE_PROP, "size", | 
					
						
							|  |  |  |                         virtio_mem_pci_get_requested_size, | 
					
						
							|  |  |  |                         virtio_mem_pci_set_requested_size, NULL, NULL); | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static const VirtioPCIDeviceTypeInfo virtio_mem_pci_info = { | 
					
						
							|  |  |  |     .base_name = TYPE_VIRTIO_MEM_PCI, | 
					
						
							| 
									
										
										
										
											2023-07-11 17:34:39 +02:00
										 |  |  |     .parent = TYPE_VIRTIO_MD_PCI, | 
					
						
							| 
									
										
										
										
											2020-06-26 09:22:38 +02:00
										 |  |  |     .generic_name = "virtio-mem-pci", | 
					
						
							|  |  |  |     .instance_size = sizeof(VirtIOMEMPCI), | 
					
						
							|  |  |  |     .instance_init = virtio_mem_pci_instance_init, | 
					
						
							|  |  |  |     .class_init = virtio_mem_pci_class_init, | 
					
						
							|  |  |  | }; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void virtio_mem_pci_register_types(void) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     virtio_pci_types_register(&virtio_mem_pci_info); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | type_init(virtio_mem_pci_register_types) |