| 
									
										
										
										
											2018-02-16 16:50:14 +00:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * BlockBackend tests | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (c) 2017 Kevin Wolf <kwolf@redhat.com> | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Permission is hereby granted, free of charge, to any person obtaining a copy | 
					
						
							|  |  |  |  * of this software and associated documentation files (the "Software"), to deal | 
					
						
							|  |  |  |  * in the Software without restriction, including without limitation the rights | 
					
						
							|  |  |  |  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | 
					
						
							|  |  |  |  * copies of the Software, and to permit persons to whom the Software is | 
					
						
							|  |  |  |  * furnished to do so, subject to the following conditions: | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * The above copyright notice and this permission notice shall be included in | 
					
						
							|  |  |  |  * all copies or substantial portions of the Software. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | 
					
						
							|  |  |  |  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | 
					
						
							|  |  |  |  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | 
					
						
							|  |  |  |  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | 
					
						
							|  |  |  |  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | 
					
						
							|  |  |  |  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | 
					
						
							|  |  |  |  * THE SOFTWARE. | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | #include "qemu/osdep.h"
 | 
					
						
							|  |  |  | #include "block/block.h"
 | 
					
						
							|  |  |  | #include "sysemu/block-backend.h"
 | 
					
						
							|  |  |  | #include "qapi/error.h"
 | 
					
						
							| 
									
										
										
											
												Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).  It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed.  Touching it now
recompiles only some 1700 objects.  For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800.  For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
											
										 
											2019-08-12 07:23:50 +02:00
										 |  |  | #include "qemu/main-loop.h"
 | 
					
						
							| 
									
										
										
										
											2018-02-16 16:50:14 +00:00
										 |  |  | 
 | 
					
						
							|  |  |  | static void test_drain_aio_error_flush_cb(void *opaque, int ret) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     bool *completed = opaque; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     g_assert(ret == -ENOMEDIUM); | 
					
						
							|  |  |  |     *completed = true; | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void test_drain_aio_error(void) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2019-04-25 14:25:10 +02:00
										 |  |  |     BlockBackend *blk = blk_new(qemu_get_aio_context(), | 
					
						
							|  |  |  |                                 BLK_PERM_ALL, BLK_PERM_ALL); | 
					
						
							| 
									
										
										
										
											2018-02-16 16:50:14 +00:00
										 |  |  |     BlockAIOCB *acb; | 
					
						
							|  |  |  |     bool completed = false; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     acb = blk_aio_flush(blk, test_drain_aio_error_flush_cb, &completed); | 
					
						
							|  |  |  |     g_assert(acb != NULL); | 
					
						
							|  |  |  |     g_assert(completed == false); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     blk_drain(blk); | 
					
						
							|  |  |  |     g_assert(completed == true); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     blk_unref(blk); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void test_drain_all_aio_error(void) | 
					
						
							|  |  |  | { | 
					
						
							| 
									
										
										
										
											2019-04-25 14:25:10 +02:00
										 |  |  |     BlockBackend *blk = blk_new(qemu_get_aio_context(), | 
					
						
							|  |  |  |                                 BLK_PERM_ALL, BLK_PERM_ALL); | 
					
						
							| 
									
										
										
										
											2018-02-16 16:50:14 +00:00
										 |  |  |     BlockAIOCB *acb; | 
					
						
							|  |  |  |     bool completed = false; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     acb = blk_aio_flush(blk, test_drain_aio_error_flush_cb, &completed); | 
					
						
							|  |  |  |     g_assert(acb != NULL); | 
					
						
							|  |  |  |     g_assert(completed == false); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     blk_drain_all(); | 
					
						
							|  |  |  |     g_assert(completed == true); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     blk_unref(blk); | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | int main(int argc, char **argv) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     bdrv_init(); | 
					
						
							|  |  |  |     qemu_init_main_loop(&error_abort); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     g_test_init(&argc, &argv, NULL); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     g_test_add_func("/block-backend/drain_aio_error", test_drain_aio_error); | 
					
						
							|  |  |  |     g_test_add_func("/block-backend/drain_all_aio_error", | 
					
						
							|  |  |  |                     test_drain_all_aio_error); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     return g_test_run(); | 
					
						
							|  |  |  | } |