| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | /*
 | 
					
						
							|  |  |  |  * Coroutine-aware I/O functions | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Copyright (C) 2009-2010 Nippon Telegraph and Telephone Corporation. | 
					
						
							|  |  |  |  * Copyright (c) 2011, Red Hat, Inc. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Permission is hereby granted, free of charge, to any person obtaining a copy | 
					
						
							|  |  |  |  * of this software and associated documentation files (the "Software"), to deal | 
					
						
							|  |  |  |  * in the Software without restriction, including without limitation the rights | 
					
						
							|  |  |  |  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | 
					
						
							|  |  |  |  * copies of the Software, and to permit persons to whom the Software is | 
					
						
							|  |  |  |  * furnished to do so, subject to the following conditions: | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * The above copyright notice and this permission notice shall be included in | 
					
						
							|  |  |  |  * all copies or substantial portions of the Software. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | 
					
						
							|  |  |  |  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | 
					
						
							|  |  |  |  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | 
					
						
							|  |  |  |  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | 
					
						
							|  |  |  |  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | 
					
						
							|  |  |  |  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | 
					
						
							|  |  |  |  * THE SOFTWARE. | 
					
						
							|  |  |  |  */ | 
					
						
							| 
									
										
										
										
											2016-01-29 17:49:55 +00:00
										 |  |  | #include "qemu/osdep.h"
 | 
					
						
							| 
									
										
										
										
											2012-12-17 18:20:00 +01:00
										 |  |  | #include "qemu/sockets.h"
 | 
					
						
							| 
									
										
										
										
											2015-09-01 14:48:02 +01:00
										 |  |  | #include "qemu/coroutine.h"
 | 
					
						
							| 
									
										
										
										
											2012-12-17 18:20:00 +01:00
										 |  |  | #include "qemu/iov.h"
 | 
					
						
							| 
									
										
										
										
											2013-08-21 16:02:47 +01:00
										 |  |  | #include "qemu/main-loop.h"
 | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  | ssize_t coroutine_fn | 
					
						
							|  |  |  | qemu_co_sendv_recvv(int sockfd, struct iovec *iov, unsigned iov_cnt, | 
					
						
							|  |  |  |                     size_t offset, size_t bytes, bool do_send) | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |     size_t done = 0; | 
					
						
							|  |  |  |     ssize_t ret; | 
					
						
							|  |  |  |     while (done < bytes) { | 
					
						
							| 
									
										
										
										
											2012-03-14 11:18:54 +04:00
										 |  |  |         ret = iov_send_recv(sockfd, iov, iov_cnt, | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |                             offset + done, bytes - done, do_send); | 
					
						
							|  |  |  |         if (ret > 0) { | 
					
						
							|  |  |  |             done += ret; | 
					
						
							|  |  |  |         } else if (ret < 0) { | 
					
						
							| 
									
										
										
										
											2016-03-07 20:36:03 +00:00
										 |  |  |             if (errno == EAGAIN || errno == EWOULDBLOCK) { | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  |                 qemu_coroutine_yield(); | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |             } else if (done == 0) { | 
					
						
							| 
									
										
										
										
											2016-03-07 20:36:03 +00:00
										 |  |  |                 return -errno; | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |             } else { | 
					
						
							|  |  |  |                 break; | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  |             } | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |         } else if (ret == 0 && !do_send) { | 
					
						
							|  |  |  |             /* write (send) should never return 0.
 | 
					
						
							|  |  |  |              * read (recv) returns 0 for end-of-file (-data). | 
					
						
							|  |  |  |              * In both cases there's little point retrying, | 
					
						
							|  |  |  |              * but we do for write anyway, just in case */ | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  |             break; | 
					
						
							|  |  |  |         } | 
					
						
							|  |  |  |     } | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |     return done; | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  | ssize_t coroutine_fn | 
					
						
							|  |  |  | qemu_co_send_recv(int sockfd, void *buf, size_t bytes, bool do_send) | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | { | 
					
						
							| 
									
										
										
										
											2012-06-07 20:22:46 +04:00
										 |  |  |     struct iovec iov = { .iov_base = buf, .iov_len = bytes }; | 
					
						
							|  |  |  |     return qemu_co_sendv_recvv(sockfd, &iov, 1, 0, bytes, do_send); | 
					
						
							| 
									
										
										
										
											2011-09-08 13:46:25 +02:00
										 |  |  | } | 
					
						
							| 
									
										
										
										
											2013-06-25 21:35:29 -04:00
										 |  |  | 
 | 
					
						
							|  |  |  | typedef struct { | 
					
						
							| 
									
										
										
										
											2019-10-24 06:56:10 +02:00
										 |  |  |     AioContext *ctx; | 
					
						
							| 
									
										
										
										
											2013-06-25 21:35:29 -04:00
										 |  |  |     Coroutine *co; | 
					
						
							|  |  |  |     int fd; | 
					
						
							|  |  |  | } FDYieldUntilData; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | static void fd_coroutine_enter(void *opaque) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     FDYieldUntilData *data = opaque; | 
					
						
							| 
									
										
											  
											
												aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
  @@
  expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
  @@
  - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
  + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
  @@
  expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
  @@
  - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
  + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
											
										 
											2023-05-16 15:02:38 -04:00
										 |  |  |     aio_set_fd_handler(data->ctx, data->fd, NULL, NULL, NULL, NULL, NULL); | 
					
						
							| 
									
										
											  
											
												coroutine: move entry argument to qemu_coroutine_create
In practice the entry argument is always known at creation time, and
it is confusing that sometimes qemu_coroutine_enter is used with a
non-NULL argument to re-enter a coroutine (this happens in
block/sheepdog.c and tests/test-coroutine.c).  So pass the opaque value
at creation time, for consistency with e.g. aio_bh_new.
Mostly done with the following semantic patch:
@ entry1 @
expression entry, arg, co;
@@
- co = qemu_coroutine_create(entry);
+ co = qemu_coroutine_create(entry, arg);
  ...
- qemu_coroutine_enter(co, arg);
+ qemu_coroutine_enter(co);
@ entry2 @
expression entry, arg;
identifier co;
@@
- Coroutine *co = qemu_coroutine_create(entry);
+ Coroutine *co = qemu_coroutine_create(entry, arg);
  ...
- qemu_coroutine_enter(co, arg);
+ qemu_coroutine_enter(co);
@ entry3 @
expression entry, arg;
@@
- qemu_coroutine_enter(qemu_coroutine_create(entry), arg);
+ qemu_coroutine_enter(qemu_coroutine_create(entry, arg));
@ reentry @
expression co;
@@
- qemu_coroutine_enter(co, NULL);
+ qemu_coroutine_enter(co);
except for the aforementioned few places where the semantic patch
stumbled (as expected) and for test_co_queue, which would otherwise
produce an uninitialized variable warning.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
											
										 
											2016-07-04 19:10:01 +02:00
										 |  |  |     qemu_coroutine_enter(data->co); | 
					
						
							| 
									
										
										
										
											2013-06-25 21:35:29 -04:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | void coroutine_fn yield_until_fd_readable(int fd) | 
					
						
							|  |  |  | { | 
					
						
							|  |  |  |     FDYieldUntilData data; | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     assert(qemu_in_coroutine()); | 
					
						
							| 
									
										
										
										
											2019-10-24 06:56:10 +02:00
										 |  |  |     data.ctx = qemu_get_current_aio_context(); | 
					
						
							| 
									
										
										
										
											2013-06-25 21:35:29 -04:00
										 |  |  |     data.co = qemu_coroutine_self(); | 
					
						
							|  |  |  |     data.fd = fd; | 
					
						
							| 
									
										
											  
											
												aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
  @@
  expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
  @@
  - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
  + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
  @@
  expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
  @@
  - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
  + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
											
										 
											2023-05-16 15:02:38 -04:00
										 |  |  |     aio_set_fd_handler(data.ctx, fd, fd_coroutine_enter, NULL, NULL, NULL, | 
					
						
							|  |  |  |                        &data); | 
					
						
							| 
									
										
										
										
											2013-06-25 21:35:29 -04:00
										 |  |  |     qemu_coroutine_yield(); | 
					
						
							|  |  |  | } |