qapi: Add a 'coroutine' flag for commands
This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher that the command handler is safe to be run in a coroutine. The documentation of the new flag pretends that this flag is already used as intended, which it isn't yet after this patch. We'll implement this in another patch in this series. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-Id: <20201005155855.256490-9-kwolf@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
committed by
Markus Armbruster
parent
e69ee454b5
commit
04f22362f1
@@ -88,10 +88,17 @@ def check_flags(expr, info):
|
||||
if key in expr and expr[key] is not False:
|
||||
raise QAPISemError(
|
||||
info, "flag '%s' may only use false value" % key)
|
||||
for key in ['boxed', 'allow-oob', 'allow-preconfig']:
|
||||
for key in ['boxed', 'allow-oob', 'allow-preconfig', 'coroutine']:
|
||||
if key in expr and expr[key] is not True:
|
||||
raise QAPISemError(
|
||||
info, "flag '%s' may only use true value" % key)
|
||||
if 'allow-oob' in expr and 'coroutine' in expr:
|
||||
# This is not necessarily a fundamental incompatibility, but
|
||||
# we don't have a use case and the desired semantics isn't
|
||||
# obvious. The simplest solution is to forbid it until we get
|
||||
# a use case for it.
|
||||
raise QAPISemError(info, "flags 'allow-oob' and 'coroutine' "
|
||||
"are incompatible")
|
||||
|
||||
|
||||
def check_if(expr, info, source):
|
||||
@@ -342,7 +349,7 @@ def check_exprs(exprs):
|
||||
['command'],
|
||||
['data', 'returns', 'boxed', 'if', 'features',
|
||||
'gen', 'success-response', 'allow-oob',
|
||||
'allow-preconfig'])
|
||||
'allow-preconfig', 'coroutine'])
|
||||
normalize_members(expr.get('data'))
|
||||
check_command(expr, info)
|
||||
elif meta == 'event':
|
||||
|
Reference in New Issue
Block a user