monitor: Cleanup mon->outbuf on write error
In case monitor_flush() fails to write the contents of mon->outbuf to the output device, mon->outbuf is not cleaned up properly. Check the return code of the qemu_chr_fe_write() function and cleanup the outbuf if it fails. References: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg02890.html Signed-off-by: Stratos Psomadakis <psomas@grnet.gr> Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
		
				
					committed by
					
						
						Luiz Capitulino
					
				
			
			
				
	
			
			
			
						parent
						
							57d3e1b3f5
						
					
				
				
					commit
					056f49ff2c
				
			@@ -288,8 +288,8 @@ void monitor_flush(Monitor *mon)
 | 
			
		||||
 | 
			
		||||
    if (len && !mon->mux_out) {
 | 
			
		||||
        rc = qemu_chr_fe_write(mon->chr, (const uint8_t *) buf, len);
 | 
			
		||||
        if (rc == len) {
 | 
			
		||||
            /* all flushed */
 | 
			
		||||
        if ((rc < 0 && errno != EAGAIN) || (rc == len)) {
 | 
			
		||||
            /* all flushed or error */
 | 
			
		||||
            QDECREF(mon->outbuf);
 | 
			
		||||
            mon->outbuf = qstring_new();
 | 
			
		||||
            return;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user