dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

semihosting: Clean up common_semi_open_cb

Browse Source 
Use common_semi_cb to return results instead of calling
set_swi_errno and common_semi_set_ret directly.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson
2022-05-16 19:37:14 -07:00
parent 84ca0dfd1e
commit 4cfeff4ac1
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
semihosting/arm-compat-semi.c
View File

@@ -364,15 +364,13 @@ static int common_semi_open_guestfd;
static void static void
common_semi_open_cb(CPUState *cs, target_ulong ret, target_ulong err) common_semi_open_cb(CPUState *cs, target_ulong ret, target_ulong err)
{ {
if (ret == (target_ulong)-1) { if (err) {
errno = err;
set_swi_errno(cs, -1);
dealloc_guestfd(common_semi_open_guestfd); dealloc_guestfd(common_semi_open_guestfd);
} else { } else {
associate_guestfd(common_semi_open_guestfd, ret); associate_guestfd(common_semi_open_guestfd, ret);
ret = common_semi_open_guestfd; ret = common_semi_open_guestfd;
} }
common_semi_set_ret(cs, ret); common_semi_cb(cs, ret, err);
} }
static target_ulong static target_ulong