dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mirror: Fix resource leak when bdrv_getlength fails

Browse Source 
The direct return will skip releasing of all the resouces at
immediate_exit, don't miss that.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 373df5b135)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Fam Zheng
2014-04-29 18:09:09 +08:00
committed by Michael Roth
parent e0efb023c0
commit 520b341264
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
block/mirror.c
View File

@@ -325,8 +325,8 @@ static void coroutine_fn mirror_run(void *opaque)
s->common.len = bdrv_getlength(bs); s->common.len = bdrv_getlength(bs);
if (s->common.len <= 0) { if (s->common.len <= 0) {
block_job_completed(&s->common, s->common.len); ret = s->common.len;
return; goto immediate_exit;
} }
length = (bdrv_getlength(bs) + s->granularity - 1) / s->granularity; length = (bdrv_getlength(bs) + s->granularity - 1) / s->granularity;