dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backup: Don't leak BackupBlockJob in error path

Browse Source 
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
(cherry picked from commit 91ab688379)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Kevin Wolf
2016-04-14 12:59:55 +02:00
committed by Michael Roth
parent 45f4e4be09
commit 683c1c5ea5
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
block/backup.c
View File

@@ -504,6 +504,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
{ {
int64_t len; int64_t len;
BlockDriverInfo bdi; BlockDriverInfo bdi;
BackupBlockJob *job = NULL;
int ret; int ret;
assert(bs); assert(bs);
@@ -568,8 +569,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
goto error; goto error;
} }
BackupBlockJob *job = block_job_create(&backup_job_driver, bs, speed, job = block_job_create(&backup_job_driver, bs, speed, cb, opaque, errp);
cb, opaque, errp);
if (!job) { if (!job) {
goto error; goto error;
} }
@@ -610,4 +610,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
if (sync_bitmap) { if (sync_bitmap) {
bdrv_reclaim_dirty_bitmap(bs, sync_bitmap, NULL); bdrv_reclaim_dirty_bitmap(bs, sync_bitmap, NULL);
} }
if (job) {
block_job_unref(&job->common);
}
} }