scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()
Here we don't expect a failure. In case of failure we'll crash on trying to access ['return']. Better is to use .command() that clearly raises on failure. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 20231006154125.1068348-4-vsementsov@yandex-team.ru Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
		
				
					committed by
					
						 John Snow
						John Snow
					
				
			
			
				
	
			
			
			
						parent
						
							2cee9ca97d
						
					
				
				
					commit
					7f521b023b
				
			| @@ -69,7 +69,7 @@ sock = sys.argv[1] | ||||
| shell = QEMUMonitorProtocol(sock) | ||||
| shell.connect() | ||||
| 
 | ||||
| models = shell.cmd("query-cpu-definitions") | ||||
| models = shell.command("query-cpu-definitions") | ||||
| 
 | ||||
| # These QMP props don't correspond to CPUID fatures | ||||
| # so ignore them | ||||
| @@ -85,7 +85,7 @@ skip = [ | ||||
| 
 | ||||
| names = [] | ||||
| 
 | ||||
| for model in models["return"]: | ||||
| for model in models: | ||||
|     if "alias-of" in model: | ||||
|         continue | ||||
|     names.append(model["name"]) | ||||
| @@ -93,12 +93,12 @@ for model in models["return"]: | ||||
| models = {} | ||||
| 
 | ||||
| for name in sorted(names): | ||||
|     cpu = shell.cmd("query-cpu-model-expansion", | ||||
|                      { "type": "static", | ||||
|                        "model": { "name": name }}) | ||||
|     cpu = shell.command("query-cpu-model-expansion", | ||||
|                         { "type": "static", | ||||
|                           "model": { "name": name }}) | ||||
| 
 | ||||
|     got = {} | ||||
|     for (feature, present) in cpu["return"]["model"]["props"].items(): | ||||
|     for (feature, present) in cpu["model"]["props"].items(): | ||||
|         if present and feature not in skip: | ||||
|             got[feature] = True | ||||
| 
 | ||||
|   | ||||
		Reference in New Issue
	
	Block a user