dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: Cover input visit beyond end of list

Browse Source 
When you try to visit beyond the end of a list, the qobject input
visitor crashes, and the string visitor screws returns garbage.  The
generated list visits never go beyond the list end, but manual visits
could.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1488544368-30622-27-git-send-email-armbru@redhat.com>
This commit is contained in:
Markus Armbruster
2017-03-03 13:32:46 +01:00
parent a4a1c70dc7
commit a9416dc62c
3 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/test-string-input-visitor.c
View File

@@ -123,6 +123,7 @@ static void test_visitor_in_intList(TestInputVisitorData *data,
int64List *res = NULL;
int64List *tail;
Visitor *v;
int64_t val;
/* Valid lists */
@@ -175,6 +176,21 @@ static void test_visitor_in_intList(TestInputVisitorData *data,
visit_end_list(v, (void **)&res);
qapi_free_int64List(res);
/* Visit beyond end of list */
v = visitor_input_test_init(data, "0");
visit_start_list(v, NULL, (GenericList **)&res, sizeof(*res),
&error_abort);
tail = res;
visit_type_int64(v, NULL, &tail->value, &err);
g_assert_cmpint(tail->value, ==, 0);
visit_type_int64(v, NULL, &val, &err);
g_assert_cmpint(val, ==, 1); /* BUG */
visit_check_list(v, &error_abort);
visit_end_list(v, (void **)&res);
qapi_free_int64List(res);
}
static void test_visitor_in_bool(TestInputVisitorData *data,