spapr_drc: Change value of property "fdt" from null back to {}
prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't visit anything. object_property_get_qobject() happily object_property_get_qobject(). Amazingly, the latter survives the misuse. Turns out we've papered over it long before prop_get_fdt() existed, in commit1d10b44. However, commit6c2f9a1changed how we paper over it, and as a side effect changed qom-get's value from {} to null. Change it right back by fixing the visitor misuse. Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
		
				
					committed by
					
						
						David Gibson
					
				
			
			
				
	
			
			
			
						parent
						
							c401ae8c9c
						
					
				
				
					commit
					ab8bf1d735
				
			@@ -259,6 +259,11 @@ static void prop_get_fdt(Object *obj, Visitor *v, void *opaque,
 | 
			
		||||
    void *fdt;
 | 
			
		||||
 | 
			
		||||
    if (!drc->fdt) {
 | 
			
		||||
        visit_start_struct(v, NULL, NULL, name, 0, &err);
 | 
			
		||||
        if (!err) {
 | 
			
		||||
            visit_end_struct(v, &err);
 | 
			
		||||
        }
 | 
			
		||||
        error_propagate(errp, err);
 | 
			
		||||
        return;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user