dfaggioli/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/misc: remove break after g_assert_not_reached()

Browse Source 
Use of assert(false) can trip spurious control flow warnings from
some versions of GCC (i.e. using -fsanitize=thread with gcc-12):

  error: control reaches end of non-void function [-Werror=return-type]
        default:
            g_assert_not_reached();
            break;
          | ^^^^^

Solve that by removing the unreachable 'break' statement, unifying
the code base on g_assert_not_reached() instead.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240910221606.1817478-29-pierrick.bouvier@linaro.org>
[PMD: Add description suggested by Eric Blake]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Pierrick Bouvier
2024-09-10 15:15:55 -07:00
committed by Philippe Mathieu-Daudé
parent 7185eb7e63
commit cdcb78dba4
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
hw/misc/imx6_ccm.c
View File

@@ -301,7 +301,6 @@ static uint64_t imx6_analog_get_periph_clk(IMX6CCMState *dev)
default: default:
/* We should never get there */ /* We should never get there */
g_assert_not_reached(); g_assert_not_reached();
break;
} }
trace_imx6_analog_get_periph_clk(freq); trace_imx6_analog_get_periph_clk(freq);

2
hw/misc/mac_via.c
View File

@@ -495,7 +495,6 @@ static void via1_rtc_update(MOS6522Q800VIA1State *v1s)
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();
break;
} }
return; return;
} }
@@ -556,7 +555,6 @@ static void via1_rtc_update(MOS6522Q800VIA1State *v1s)
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();
break;
} }
return; return;
} }