spapr, pnv, xive: Add a "xive-fabric" link to the XIVE router
In order to get rid of qdev_get_machine(), first add a pointer to the XIVE fabric under the XIVE router and make it configurable through a QOM link property. Configure it in the spapr and pnv machine. In the case of pnv, the XIVE routers are under the chip, so this is done with a QOM alias property of the POWER9 pnv chip. Signed-off-by: Greg Kurz <groug@kaod.org> Signed-off-by: Cédric Le Goater <clg@kaod.org> Message-Id: <20200106145645.4539-5-clg@kaod.org> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
		@@ -1714,12 +1714,19 @@ void xive_router_notify(XiveNotifier *xn, uint32_t lisn)
 | 
				
			|||||||
                           xive_get_field64(EAS_END_DATA,  eas.w));
 | 
					                           xive_get_field64(EAS_END_DATA,  eas.w));
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static Property xive_router_properties[] = {
 | 
				
			||||||
 | 
					    DEFINE_PROP_LINK("xive-fabric", XiveRouter, xfb,
 | 
				
			||||||
 | 
					                     TYPE_XIVE_FABRIC, XiveFabric *),
 | 
				
			||||||
 | 
					    DEFINE_PROP_END_OF_LIST(),
 | 
				
			||||||
 | 
					};
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void xive_router_class_init(ObjectClass *klass, void *data)
 | 
					static void xive_router_class_init(ObjectClass *klass, void *data)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
    DeviceClass *dc = DEVICE_CLASS(klass);
 | 
					    DeviceClass *dc = DEVICE_CLASS(klass);
 | 
				
			||||||
    XiveNotifierClass *xnc = XIVE_NOTIFIER_CLASS(klass);
 | 
					    XiveNotifierClass *xnc = XIVE_NOTIFIER_CLASS(klass);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    dc->desc    = "XIVE Router Engine";
 | 
					    dc->desc    = "XIVE Router Engine";
 | 
				
			||||||
 | 
					    dc->props   = xive_router_properties;
 | 
				
			||||||
    xnc->notify = xive_router_notify;
 | 
					    xnc->notify = xive_router_notify;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
@@ -1727,6 +1734,7 @@ static const TypeInfo xive_router_info = {
 | 
				
			|||||||
    .name          = TYPE_XIVE_ROUTER,
 | 
					    .name          = TYPE_XIVE_ROUTER,
 | 
				
			||||||
    .parent        = TYPE_SYS_BUS_DEVICE,
 | 
					    .parent        = TYPE_SYS_BUS_DEVICE,
 | 
				
			||||||
    .abstract      = true,
 | 
					    .abstract      = true,
 | 
				
			||||||
 | 
					    .instance_size = sizeof(XiveRouter),
 | 
				
			||||||
    .class_size    = sizeof(XiveRouterClass),
 | 
					    .class_size    = sizeof(XiveRouterClass),
 | 
				
			||||||
    .class_init    = xive_router_class_init,
 | 
					    .class_init    = xive_router_class_init,
 | 
				
			||||||
    .interfaces    = (InterfaceInfo[]) {
 | 
					    .interfaces    = (InterfaceInfo[]) {
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -809,6 +809,10 @@ static void pnv_init(MachineState *machine)
 | 
				
			|||||||
        if (object_dynamic_cast(OBJECT(pnv), TYPE_XICS_FABRIC)) {
 | 
					        if (object_dynamic_cast(OBJECT(pnv), TYPE_XICS_FABRIC)) {
 | 
				
			||||||
            object_property_set_link(chip, OBJECT(pnv), "xics", &error_abort);
 | 
					            object_property_set_link(chip, OBJECT(pnv), "xics", &error_abort);
 | 
				
			||||||
        }
 | 
					        }
 | 
				
			||||||
 | 
					        if (object_dynamic_cast(OBJECT(pnv), TYPE_XIVE_FABRIC)) {
 | 
				
			||||||
 | 
					            object_property_set_link(chip, OBJECT(pnv), "xive-fabric",
 | 
				
			||||||
 | 
					                                     &error_abort);
 | 
				
			||||||
 | 
					        }
 | 
				
			||||||
        object_property_set_bool(chip, true, "realized", &error_fatal);
 | 
					        object_property_set_bool(chip, true, "realized", &error_fatal);
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
    g_free(chip_typename);
 | 
					    g_free(chip_typename);
 | 
				
			||||||
@@ -1227,6 +1231,8 @@ static void pnv_chip_power9_instance_init(Object *obj)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
    object_initialize_child(obj, "xive", &chip9->xive, sizeof(chip9->xive),
 | 
					    object_initialize_child(obj, "xive", &chip9->xive, sizeof(chip9->xive),
 | 
				
			||||||
                            TYPE_PNV_XIVE, &error_abort, NULL);
 | 
					                            TYPE_PNV_XIVE, &error_abort, NULL);
 | 
				
			||||||
 | 
					    object_property_add_alias(obj, "xive-fabric", OBJECT(&chip9->xive),
 | 
				
			||||||
 | 
					                              "xive-fabric", &error_abort);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    object_initialize_child(obj, "psi",  &chip9->psi, sizeof(chip9->psi),
 | 
					    object_initialize_child(obj, "psi",  &chip9->psi, sizeof(chip9->psi),
 | 
				
			||||||
                            TYPE_PNV9_PSI, &error_abort, NULL);
 | 
					                            TYPE_PNV9_PSI, &error_abort, NULL);
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -332,6 +332,8 @@ void spapr_irq_init(SpaprMachineState *spapr, Error **errp)
 | 
				
			|||||||
         * priority
 | 
					         * priority
 | 
				
			||||||
         */
 | 
					         */
 | 
				
			||||||
        qdev_prop_set_uint32(dev, "nr-ends", nr_servers << 3);
 | 
					        qdev_prop_set_uint32(dev, "nr-ends", nr_servers << 3);
 | 
				
			||||||
 | 
					        object_property_set_link(OBJECT(dev), OBJECT(spapr), "xive-fabric",
 | 
				
			||||||
 | 
					                                 &error_abort);
 | 
				
			||||||
        qdev_init_nofail(dev);
 | 
					        qdev_init_nofail(dev);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
        spapr->xive = SPAPR_XIVE(dev);
 | 
					        spapr->xive = SPAPR_XIVE(dev);
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -324,9 +324,12 @@ typedef struct XiveTCTX {
 | 
				
			|||||||
/*
 | 
					/*
 | 
				
			||||||
 * XIVE Router
 | 
					 * XIVE Router
 | 
				
			||||||
 */
 | 
					 */
 | 
				
			||||||
 | 
					typedef struct XiveFabric XiveFabric;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
typedef struct XiveRouter {
 | 
					typedef struct XiveRouter {
 | 
				
			||||||
    SysBusDevice    parent;
 | 
					    SysBusDevice    parent;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    XiveFabric *xfb;
 | 
				
			||||||
} XiveRouter;
 | 
					} XiveRouter;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
#define TYPE_XIVE_ROUTER "xive-router"
 | 
					#define TYPE_XIVE_ROUTER "xive-router"
 | 
				
			||||||
@@ -402,8 +405,6 @@ int xive_presenter_tctx_match(XivePresenter *xptr, XiveTCTX *tctx,
 | 
				
			|||||||
 * XIVE Fabric (Interface between Interrupt Controller and Machine)
 | 
					 * XIVE Fabric (Interface between Interrupt Controller and Machine)
 | 
				
			||||||
 */
 | 
					 */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
typedef struct XiveFabric XiveFabric;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
#define TYPE_XIVE_FABRIC "xive-fabric"
 | 
					#define TYPE_XIVE_FABRIC "xive-fabric"
 | 
				
			||||||
#define XIVE_FABRIC(obj)                                     \
 | 
					#define XIVE_FABRIC(obj)                                     \
 | 
				
			||||||
    INTERFACE_CHECK(XiveFabric, (obj), TYPE_XIVE_FABRIC)
 | 
					    INTERFACE_CHECK(XiveFabric, (obj), TYPE_XIVE_FABRIC)
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user