Peter Maydell
41742927ee
hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct
...
Currently the bitbang_i2c_init() function allocates a
bitbang_i2c_interface struct which it returns. This is unfortunate
because it means that if the function is used from a DeviceState
init method then the memory will be leaked by an "init then delete"
cycle, as used by the qmp/hmp commands that list device properties.
Since three out of four of the uses of this function are in
device init methods, switch the function to do an in-place
initialization of a struct that can be embedded in the
device state struct of the caller.
This fixes LeakSanitizer leak warnings that have appeared in the
patchew configuration (which only tries to run the sanitizers
for the x86_64-softmmu target) now that we use the bitbang-i2c
code in an x86-64 config.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu >
Tested-by: BALATON Zoltan <balaton@eik.bme.hu >
Acked-by: David Gibson <david@gibson.dropbear.id.au >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Message-id: 20190702163844.20458-1-peter.maydell@linaro.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2019-07-03 10:51:35 +02:00
BALATON Zoltan
d718b7475b
i2c: Move bitbang_i2c.h to include/hw/i2c/
...
The bitbang i2c implementation is also useful for other device models
such as DDC in display controllers. Move the header to include/hw/i2c/
to allow it to be used from other device models and adjust users of
this include. This also reverts commit 2b4c1125acbalaton@eik.bme.hu >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Acked-by: Corey Minyard <cminyard@mvista.com >
Message-id: 5d1fe4db846ab9be4b77ddb0d43cc74cd200a003.1561028123.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2019-06-28 10:49:36 +02:00
Markus Armbruster
0b8fa32f55
Include qemu/module.h where needed, drop it from qemu-common.h
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20190523143508.25387-4-armbru@redhat.com >
[Rebased with conflicts resolved automatically, except for
hw/usb/dev-hub.c hw/misc/exynos4210_rng.c hw/misc/bcm2835_rng.c
hw/misc/aspeed_scu.c hw/display/virtio-vga.c hw/arm/stm32f205_soc.c;
ui/cocoa.m fixed up]
2019-06-12 13:18:33 +02:00
xiaoqiang zhao
8ce26fcd29
hw/i2c: QOM'ify versatile_i2c.c
...
Drop the old SysBus init function and use instance_init
Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com >
Message-id: 1465815255-21776-5-git-send-email-zxq_yx_007@163.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org >
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
2016-06-14 15:59:13 +01:00
Paolo Bonzini
03dd024ff5
hw: explicitly include qemu/log.h
...
Move the inclusion out of hw/hw.h, most files do not need it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2016-05-19 16:42:29 +02:00
Peter Maydell
8ef94f0bc9
arm: Clean up includes
...
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
Message-id: 1453832250-766-13-git-send-email-peter.maydell@linaro.org
2016-01-29 15:07:23 +00:00
Andreas Färber
a5c828525e
i2c: Rename i2c_bus to I2CBus
...
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com >
Signed-off-by: Andreas Färber <afaerber@suse.de >
2014-02-14 16:22:31 +01:00
Andreas Färber
93e7f5f42d
versatile_i2c: QOM cast cleanup
...
Signed-off-by: Andreas Färber <afaerber@suse.de >
2013-07-29 21:06:57 +02:00
Paolo Bonzini
1437c94b26
hw/i*: pass owner to memory_region_init* functions
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-07-04 17:42:48 +02:00
Paolo Bonzini
2c9b15cab1
memory: add owner argument to initialization functions
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-07-04 17:42:44 +02:00
Paolo Bonzini
47b43a1f41
hw: move private headers to hw/ subdirectories.
...
Many headers are used only in a single directory. These can be
kept in hw/.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:16 +02:00
Paolo Bonzini
49ab747f66
hw: move target-independent files to subdirectories
...
This patch tackles all files that are compiled once, moving
them to subdirectories of hw/.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:12 +02:00
