Marc-André Lureau
5662576ad0
char.h: fix gtk-doc comment style
...
Fix up conformance to GTK-Doc function comment style, as documented in
https://developer.gnome.org/gtk-doc-manual/stable/documenting_symbols.html.en
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
2018-10-03 14:45:05 +04:00
Julia Suvorova
7351681ec2
chardev/char-fe: Fix typos
...
Fixup some typos in the comments.
Signed-off-by: Julia Suvorova <jusual@mail.ru >
Message-Id: <20180813093402.10852-1-jusual@mail.ru >
Reviewed-by: Peter Maydell <peter.maydell@linaro.org >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2018-08-23 13:32:50 +02:00
Anton Nefedov
3065070153
char: avoid chardevice direct access
...
frontends should avoid accessing CharDriver struct where possible
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com >
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Message-Id: <1499342940-56739-6-git-send-email-anton.nefedov@virtuozzo.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-07-14 11:04:33 +02:00
Anton Nefedov
7c44a2a9d1
char: forbid direct chardevice access for hotswap devices
...
qemu_chr_fe_get_driver() is unsafe, frontends with hotswap support
should not access CharDriver ptr directly as CharDriver might change.
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com >
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Message-Id: <1499342940-56739-5-git-send-email-anton.nefedov@virtuozzo.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-07-14 11:04:33 +02:00
Anton Nefedov
81517ba37a
char: add backend hotswap handler
...
Frontends should have an interface to setup the handler of a backend change.
The interface will be used in the next commits
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com >
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Message-Id: <1499342940-56739-3-git-send-email-anton.nefedov@virtuozzo.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-07-14 11:04:33 +02:00
Marc-André Lureau
1ce2610c10
char: make chr_fe_deinit() optionaly delete backend
...
This simplifies removing a backend for a frontend user (no need to
retrieve the associated driver and separate delete call etc).
NB: many frontends have questionable handling of ending a chardev. They
should probably delete the backend to prevent broken reusage.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
2017-06-02 11:33:53 +04:00
Marc-André Lureau
4d43a603c7
char: move CharBackend handling in char-fe unit
...
Move all the frontend struct and methods to a seperate unit. This avoids
accidentally mixing backend and frontend calls, and helps with readabilty.
Make qemu_chr_replay() a macro shared by both char and char-fe.
Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
(nb: yes, CharBackend is for char frontend :)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
2017-06-02 11:33:53 +04:00
