All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(), aio_enable_external(), and the is_external arguments to aio_set_fd_handler() and aio_set_event_notifier(). The entire test-fdmon-epoll test is removed because its sole purpose was testing aio_disable_external(). Parts of this patch were generated using the following coccinelle (https://coccinelle.lip6.fr/) semantic patch: @@ expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; @@ - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) @@ expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; @@ - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20230516190238.8401-21-stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
		
			
				
	
	
		
			83 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			83 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * AioContext POSIX event loop implementation internal APIs
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2008
 | 
						|
 * Copyright Red Hat, Inc. 2020
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Anthony Liguori   <aliguori@us.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2.  See
 | 
						|
 * the COPYING file in the top-level directory.
 | 
						|
 *
 | 
						|
 * Contributions after 2012-01-13 are licensed under the terms of the
 | 
						|
 * GNU GPL, version 2 or (at your option) any later version.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef AIO_POSIX_H
 | 
						|
#define AIO_POSIX_H
 | 
						|
 | 
						|
#include "block/aio.h"
 | 
						|
 | 
						|
struct AioHandler {
 | 
						|
    GPollFD pfd;
 | 
						|
    IOHandler *io_read;
 | 
						|
    IOHandler *io_write;
 | 
						|
    AioPollFn *io_poll;
 | 
						|
    IOHandler *io_poll_ready;
 | 
						|
    IOHandler *io_poll_begin;
 | 
						|
    IOHandler *io_poll_end;
 | 
						|
    void *opaque;
 | 
						|
    QLIST_ENTRY(AioHandler) node;
 | 
						|
    QLIST_ENTRY(AioHandler) node_ready; /* only used during aio_poll() */
 | 
						|
    QLIST_ENTRY(AioHandler) node_deleted;
 | 
						|
    QLIST_ENTRY(AioHandler) node_poll;
 | 
						|
#ifdef CONFIG_LINUX_IO_URING
 | 
						|
    QSLIST_ENTRY(AioHandler) node_submitted;
 | 
						|
    unsigned flags; /* see fdmon-io_uring.c */
 | 
						|
#endif
 | 
						|
    int64_t poll_idle_timeout; /* when to stop userspace polling */
 | 
						|
    bool poll_ready; /* has polling detected an event? */
 | 
						|
};
 | 
						|
 | 
						|
/* Add a handler to a ready list */
 | 
						|
void aio_add_ready_handler(AioHandlerList *ready_list, AioHandler *node,
 | 
						|
                           int revents);
 | 
						|
 | 
						|
extern const FDMonOps fdmon_poll_ops;
 | 
						|
 | 
						|
#ifdef CONFIG_EPOLL_CREATE1
 | 
						|
bool fdmon_epoll_try_upgrade(AioContext *ctx, unsigned npfd);
 | 
						|
void fdmon_epoll_setup(AioContext *ctx);
 | 
						|
void fdmon_epoll_disable(AioContext *ctx);
 | 
						|
#else
 | 
						|
static inline bool fdmon_epoll_try_upgrade(AioContext *ctx, unsigned npfd)
 | 
						|
{
 | 
						|
    return false;
 | 
						|
}
 | 
						|
 | 
						|
static inline void fdmon_epoll_setup(AioContext *ctx)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
static inline void fdmon_epoll_disable(AioContext *ctx)
 | 
						|
{
 | 
						|
}
 | 
						|
#endif /* !CONFIG_EPOLL_CREATE1 */
 | 
						|
 | 
						|
#ifdef CONFIG_LINUX_IO_URING
 | 
						|
bool fdmon_io_uring_setup(AioContext *ctx);
 | 
						|
void fdmon_io_uring_destroy(AioContext *ctx);
 | 
						|
#else
 | 
						|
static inline bool fdmon_io_uring_setup(AioContext *ctx)
 | 
						|
{
 | 
						|
    return false;
 | 
						|
}
 | 
						|
 | 
						|
static inline void fdmon_io_uring_destroy(AioContext *ctx)
 | 
						|
{
 | 
						|
}
 | 
						|
#endif /* !CONFIG_LINUX_IO_URING */
 | 
						|
 | 
						|
#endif /* AIO_POSIX_H */
 |