00382fa851
The JSON parser happily accepts duplicate object member names. The last value wins. Reproducer #1: $ qemu-system-x86_64 -qmp stdio {"QMP": {"version": {"qemu": {"micro": 93, "minor": 0, "major": 3}, "package": "v3.1.0-rc3-7-g87a45d86ed"}, "capabilities": []}} {'execute':'qmp_capabilities'} {"return": {}} {'execute':'blockdev-add','arguments':{'driver':'null-co', 'node-name':'foo','node-name':'bar'}} {"return": {}} {'execute':'query-named-block-nodes'} {"return": [{ [...] "node-name": "bar" [...] }]} Reproducer #2 is iotest 229. Fix the parser to reject duplicates, and fix iotest 229 not to use them. Reported-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20181206121743.20762-1-armbru@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> [Trailing whitespace tidied up] Signed-off-by: Markus Armbruster <armbru@redhat.com>
94 lines
2.5 KiB
Bash
Executable File
94 lines
2.5 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Test for force canceling a running blockjob that is paused in
|
|
# an error state.
|
|
#
|
|
# Copyright (C) 2018 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=jcody@redhat.com
|
|
|
|
seq="$(basename $0)"
|
|
echo "QA output created by $seq"
|
|
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_qemu
|
|
_cleanup_test_img
|
|
rm -f "$TEST_IMG" "$DEST_IMG"
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
. ./common.qemu
|
|
|
|
# Needs backing file and backing format support
|
|
_supported_fmt qcow2 qed
|
|
_supported_proto file
|
|
_supported_os Linux
|
|
|
|
|
|
DEST_IMG="$TEST_DIR/d.$IMGFMT"
|
|
TEST_IMG="$TEST_DIR/b.$IMGFMT"
|
|
|
|
_make_test_img 2M
|
|
|
|
# destination for mirror will be too small, causing error
|
|
TEST_IMG=$DEST_IMG _make_test_img 1M
|
|
|
|
$QEMU_IO -c 'write 0 2M' "$TEST_IMG" | _filter_qemu_io
|
|
|
|
_launch_qemu -drive id=testdisk,file="$TEST_IMG",format="$IMGFMT"
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
"{'execute': 'qmp_capabilities'}" \
|
|
'return'
|
|
|
|
echo
|
|
echo '=== Starting drive-mirror, causing error & stop ==='
|
|
echo
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
"{'execute': 'drive-mirror',
|
|
'arguments': {'device': 'testdisk',
|
|
'format': '$IMGFMT',
|
|
'target': '$DEST_IMG',
|
|
'sync': 'full',
|
|
'mode': 'existing',
|
|
'on-source-error': 'stop',
|
|
'on-target-error': 'stop' }}" \
|
|
"JOB_STATUS_CHANGE.*pause"
|
|
|
|
echo
|
|
echo '=== Force cancel job paused in error state ==='
|
|
echo
|
|
|
|
success_or_failure="y" _send_qemu_cmd $QEMU_HANDLE \
|
|
"{'execute': 'block-job-cancel',
|
|
'arguments': { 'device': 'testdisk',
|
|
'force': true}}" \
|
|
"BLOCK_JOB_CANCELLED" "Assertion"
|
|
|
|
# success, all done
|
|
echo "*** done"
|
|
rm -f $seq.full
|
|
status=0
|