ca1ef1e62e
This patch is to reduce the number of Valgrind report messages about
using uninitialized memory with the null-co driver. It helps to filter
real memory issues and is the same work done for the iotests with the
commit ID a6862418fe.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Message-Id: <1564404360-733987-1-git-send-email-andrey.shinkevich@virtuozzo.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
89 lines
2.4 KiB
C
89 lines
2.4 KiB
C
/*
|
|
* QTest testcase for NVMe
|
|
*
|
|
* Copyright (c) 2014 SUSE LINUX Products GmbH
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/module.h"
|
|
#include "qemu/units.h"
|
|
#include "libqtest.h"
|
|
#include "libqos/qgraph.h"
|
|
#include "libqos/pci.h"
|
|
|
|
typedef struct QNvme QNvme;
|
|
|
|
struct QNvme {
|
|
QOSGraphObject obj;
|
|
QPCIDevice dev;
|
|
};
|
|
|
|
static void *nvme_get_driver(void *obj, const char *interface)
|
|
{
|
|
QNvme *nvme = obj;
|
|
|
|
if (!g_strcmp0(interface, "pci-device")) {
|
|
return &nvme->dev;
|
|
}
|
|
|
|
fprintf(stderr, "%s not present in nvme\n", interface);
|
|
g_assert_not_reached();
|
|
}
|
|
|
|
static void *nvme_create(void *pci_bus, QGuestAllocator *alloc, void *addr)
|
|
{
|
|
QNvme *nvme = g_new0(QNvme, 1);
|
|
QPCIBus *bus = pci_bus;
|
|
|
|
qpci_device_init(&nvme->dev, bus, addr);
|
|
nvme->obj.get_driver = nvme_get_driver;
|
|
|
|
return &nvme->obj;
|
|
}
|
|
|
|
/* This used to cause a NULL pointer dereference. */
|
|
static void nvmetest_oob_cmb_test(void *obj, void *data, QGuestAllocator *alloc)
|
|
{
|
|
const int cmb_bar_size = 2 * MiB;
|
|
QNvme *nvme = obj;
|
|
QPCIDevice *pdev = &nvme->dev;
|
|
QPCIBar bar;
|
|
|
|
qpci_device_enable(pdev);
|
|
bar = qpci_iomap(pdev, 2, NULL);
|
|
|
|
qpci_io_writel(pdev, bar, 0, 0xccbbaa99);
|
|
g_assert_cmpint(qpci_io_readb(pdev, bar, 0), ==, 0x99);
|
|
g_assert_cmpint(qpci_io_readw(pdev, bar, 0), ==, 0xaa99);
|
|
|
|
/* Test partially out-of-bounds accesses. */
|
|
qpci_io_writel(pdev, bar, cmb_bar_size - 1, 0x44332211);
|
|
g_assert_cmpint(qpci_io_readb(pdev, bar, cmb_bar_size - 1), ==, 0x11);
|
|
g_assert_cmpint(qpci_io_readw(pdev, bar, cmb_bar_size - 1), !=, 0x2211);
|
|
g_assert_cmpint(qpci_io_readl(pdev, bar, cmb_bar_size - 1), !=, 0x44332211);
|
|
}
|
|
|
|
static void nvme_register_nodes(void)
|
|
{
|
|
QOSGraphEdgeOptions opts = {
|
|
.extra_device_opts = "addr=04.0,drive=drv0,serial=foo",
|
|
.before_cmd_line = "-drive id=drv0,if=none,file=null-co://,"
|
|
"file.read-zeroes=on,format=raw",
|
|
};
|
|
|
|
add_qpci_address(&opts, &(QPCIAddress) { .devfn = QPCI_DEVFN(4, 0) });
|
|
|
|
qos_node_create_driver("nvme", nvme_create);
|
|
qos_node_consumes("nvme", "pci-bus", &opts);
|
|
qos_node_produces("nvme", "pci-device");
|
|
|
|
qos_add_test("oob-cmb-access", "nvme", nvmetest_oob_cmb_test, &(QOSGraphTestOptions) {
|
|
.edge.extra_device_opts = "cmb_size_mb=2"
|
|
});
|
|
}
|
|
|
|
libqos_init(nvme_register_nodes);
|