This avoids a possible division by zero. Convert s->tracks to unsigned as well because it feels better than surviving just because the results of calculations with s->tracks are converted to unsigned anyway. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
		
			
				
	
	
		
			77 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			77 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/bash
 | 
						|
#
 | 
						|
# parallels format input validation tests
 | 
						|
#
 | 
						|
# Copyright (C) 2013 Red Hat, Inc.
 | 
						|
#
 | 
						|
# This program is free software; you can redistribute it and/or modify
 | 
						|
# it under the terms of the GNU General Public License as published by
 | 
						|
# the Free Software Foundation; either version 2 of the License, or
 | 
						|
# (at your option) any later version.
 | 
						|
#
 | 
						|
# This program is distributed in the hope that it will be useful,
 | 
						|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
# GNU General Public License for more details.
 | 
						|
#
 | 
						|
# You should have received a copy of the GNU General Public License
 | 
						|
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
#
 | 
						|
 | 
						|
# creator
 | 
						|
owner=kwolf@redhat.com
 | 
						|
 | 
						|
seq=`basename $0`
 | 
						|
echo "QA output created by $seq"
 | 
						|
 | 
						|
here=`pwd`
 | 
						|
tmp=/tmp/$$
 | 
						|
status=1	# failure is the default!
 | 
						|
 | 
						|
_cleanup()
 | 
						|
{
 | 
						|
	_cleanup_test_img
 | 
						|
}
 | 
						|
trap "_cleanup; exit \$status" 0 1 2 3 15
 | 
						|
 | 
						|
# get standard environment, filters and checks
 | 
						|
. ./common.rc
 | 
						|
. ./common.filter
 | 
						|
 | 
						|
_supported_fmt parallels
 | 
						|
_supported_proto generic
 | 
						|
_supported_os Linux
 | 
						|
 | 
						|
tracks_offset=$((0x1c))
 | 
						|
catalog_entries_offset=$((0x20))
 | 
						|
nb_sectors_offset=$((0x24))
 | 
						|
 | 
						|
echo
 | 
						|
echo "== Read from a valid (enough) image =="
 | 
						|
_use_sample_img fake.parallels.bz2
 | 
						|
{ $QEMU_IO -c "read -P 0x11 0 64k" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir
 | 
						|
 | 
						|
echo
 | 
						|
echo "== Negative catalog size =="
 | 
						|
_use_sample_img fake.parallels.bz2
 | 
						|
poke_file "$TEST_IMG" "$catalog_entries_offset" "\xff\xff\xff\xff"
 | 
						|
{ $QEMU_IO -c "read 0 512" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir
 | 
						|
 | 
						|
echo
 | 
						|
echo "== Overflow in catalog allocation =="
 | 
						|
_use_sample_img fake.parallels.bz2
 | 
						|
poke_file "$TEST_IMG" "$nb_sectors_offset" "\xff\xff\xff\xff"
 | 
						|
poke_file "$TEST_IMG" "$catalog_entries_offset" "\x01\x00\x00\x40"
 | 
						|
{ $QEMU_IO -c "read 64M 64M" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir
 | 
						|
 | 
						|
echo
 | 
						|
echo "== Zero sectors per track =="
 | 
						|
_use_sample_img fake.parallels.bz2
 | 
						|
poke_file "$TEST_IMG" "$tracks_offset" "\x00\x00\x00\x00"
 | 
						|
{ $QEMU_IO -c "read 0 512" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir
 | 
						|
 | 
						|
# success, all done
 | 
						|
echo "*** done"
 | 
						|
rm -f $seq.full
 | 
						|
status=0
 |