The object_property_set_FOO() setters take property name and value in
an unusual order:
    void object_property_set_FOO(Object *obj, FOO_TYPE value,
                                 const char *name, Error **errp)
Having to pass value before name feels grating.  Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
    @@
    identifier fun = {
        object_property_get, object_property_parse, object_property_set_str,
        object_property_set_link, object_property_set_bool,
        object_property_set_int, object_property_set_uint, object_property_set,
        object_property_set_qobject
    };
    expression obj, v, name, errp;
    @@
    -    fun(obj, v, name, errp)
    +    fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information".  Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually.  The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
		
	
		
			
				
	
	
		
			274 lines
		
	
	
		
			7.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			274 lines
		
	
	
		
			7.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QMP commands related to QOM
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2011
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Anthony Liguori   <aliguori@us.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2.  See
 | 
						|
 * the COPYING file in the top-level directory.
 | 
						|
 *
 | 
						|
 * Contributions after 2012-01-13 are licensed under the terms of the
 | 
						|
 * GNU GPL, version 2 or (at your option) any later version.
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "block/qdict.h"
 | 
						|
#include "hw/qdev-core.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qapi/qapi-commands-qdev.h"
 | 
						|
#include "qapi/qapi-commands-qom.h"
 | 
						|
#include "qapi/qmp/qdict.h"
 | 
						|
#include "qapi/qmp/qerror.h"
 | 
						|
#include "qemu/cutils.h"
 | 
						|
#include "qom/object_interfaces.h"
 | 
						|
#include "qom/qom-qobject.h"
 | 
						|
 | 
						|
ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
 | 
						|
{
 | 
						|
    Object *obj;
 | 
						|
    bool ambiguous = false;
 | 
						|
    ObjectPropertyInfoList *props = NULL;
 | 
						|
    ObjectProperty *prop;
 | 
						|
    ObjectPropertyIterator iter;
 | 
						|
 | 
						|
    obj = object_resolve_path(path, &ambiguous);
 | 
						|
    if (obj == NULL) {
 | 
						|
        if (ambiguous) {
 | 
						|
            error_setg(errp, "Path '%s' is ambiguous", path);
 | 
						|
        } else {
 | 
						|
            error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
 | 
						|
                      "Device '%s' not found", path);
 | 
						|
        }
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    object_property_iter_init(&iter, obj);
 | 
						|
    while ((prop = object_property_iter_next(&iter))) {
 | 
						|
        ObjectPropertyInfoList *entry = g_malloc0(sizeof(*entry));
 | 
						|
 | 
						|
        entry->value = g_malloc0(sizeof(ObjectPropertyInfo));
 | 
						|
        entry->next = props;
 | 
						|
        props = entry;
 | 
						|
 | 
						|
        entry->value->name = g_strdup(prop->name);
 | 
						|
        entry->value->type = g_strdup(prop->type);
 | 
						|
    }
 | 
						|
 | 
						|
    return props;
 | 
						|
}
 | 
						|
 | 
						|
void qmp_qom_set(const char *path, const char *property, QObject *value,
 | 
						|
                 Error **errp)
 | 
						|
{
 | 
						|
    Object *obj;
 | 
						|
 | 
						|
    obj = object_resolve_path(path, NULL);
 | 
						|
    if (!obj) {
 | 
						|
        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
 | 
						|
                  "Device '%s' not found", path);
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    object_property_set_qobject(obj, property, value, errp);
 | 
						|
}
 | 
						|
 | 
						|
QObject *qmp_qom_get(const char *path, const char *property, Error **errp)
 | 
						|
{
 | 
						|
    Object *obj;
 | 
						|
 | 
						|
    obj = object_resolve_path(path, NULL);
 | 
						|
    if (!obj) {
 | 
						|
        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
 | 
						|
                  "Device '%s' not found", path);
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    return object_property_get_qobject(obj, property, errp);
 | 
						|
}
 | 
						|
 | 
						|
static void qom_list_types_tramp(ObjectClass *klass, void *data)
 | 
						|
{
 | 
						|
    ObjectTypeInfoList *e, **pret = data;
 | 
						|
    ObjectTypeInfo *info;
 | 
						|
    ObjectClass *parent = object_class_get_parent(klass);
 | 
						|
 | 
						|
    info = g_malloc0(sizeof(*info));
 | 
						|
    info->name = g_strdup(object_class_get_name(klass));
 | 
						|
    info->has_abstract = info->abstract = object_class_is_abstract(klass);
 | 
						|
    if (parent) {
 | 
						|
        info->has_parent = true;
 | 
						|
        info->parent = g_strdup(object_class_get_name(parent));
 | 
						|
    }
 | 
						|
 | 
						|
    e = g_malloc0(sizeof(*e));
 | 
						|
    e->value = info;
 | 
						|
    e->next = *pret;
 | 
						|
    *pret = e;
 | 
						|
}
 | 
						|
 | 
						|
ObjectTypeInfoList *qmp_qom_list_types(bool has_implements,
 | 
						|
                                       const char *implements,
 | 
						|
                                       bool has_abstract,
 | 
						|
                                       bool abstract,
 | 
						|
                                       Error **errp)
 | 
						|
{
 | 
						|
    ObjectTypeInfoList *ret = NULL;
 | 
						|
 | 
						|
    module_load_qom_all();
 | 
						|
    object_class_foreach(qom_list_types_tramp, implements, abstract, &ret);
 | 
						|
 | 
						|
    return ret;
 | 
						|
}
 | 
						|
 | 
						|
ObjectPropertyInfoList *qmp_device_list_properties(const char *typename,
 | 
						|
                                                Error **errp)
 | 
						|
{
 | 
						|
    ObjectClass *klass;
 | 
						|
    Object *obj;
 | 
						|
    ObjectProperty *prop;
 | 
						|
    ObjectPropertyIterator iter;
 | 
						|
    ObjectPropertyInfoList *prop_list = NULL;
 | 
						|
 | 
						|
    klass = module_object_class_by_name(typename);
 | 
						|
    if (klass == NULL) {
 | 
						|
        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
 | 
						|
                  "Device '%s' not found", typename);
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    klass = object_class_dynamic_cast(klass, TYPE_DEVICE);
 | 
						|
    if (klass == NULL) {
 | 
						|
        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE);
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    if (object_class_is_abstract(klass)) {
 | 
						|
        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename",
 | 
						|
                   "non-abstract device type");
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    obj = object_new(typename);
 | 
						|
 | 
						|
    object_property_iter_init(&iter, obj);
 | 
						|
    while ((prop = object_property_iter_next(&iter))) {
 | 
						|
        ObjectPropertyInfo *info;
 | 
						|
        ObjectPropertyInfoList *entry;
 | 
						|
 | 
						|
        /* Skip Object and DeviceState properties */
 | 
						|
        if (strcmp(prop->name, "type") == 0 ||
 | 
						|
            strcmp(prop->name, "realized") == 0 ||
 | 
						|
            strcmp(prop->name, "hotpluggable") == 0 ||
 | 
						|
            strcmp(prop->name, "hotplugged") == 0 ||
 | 
						|
            strcmp(prop->name, "parent_bus") == 0) {
 | 
						|
            continue;
 | 
						|
        }
 | 
						|
 | 
						|
        /* Skip legacy properties since they are just string versions of
 | 
						|
         * properties that we already list.
 | 
						|
         */
 | 
						|
        if (strstart(prop->name, "legacy-", NULL)) {
 | 
						|
            continue;
 | 
						|
        }
 | 
						|
 | 
						|
        info = g_new0(ObjectPropertyInfo, 1);
 | 
						|
        info->name = g_strdup(prop->name);
 | 
						|
        info->type = g_strdup(prop->type);
 | 
						|
        info->has_description = !!prop->description;
 | 
						|
        info->description = g_strdup(prop->description);
 | 
						|
        info->default_value = qobject_ref(prop->defval);
 | 
						|
        info->has_default_value = !!info->default_value;
 | 
						|
 | 
						|
        entry = g_malloc0(sizeof(*entry));
 | 
						|
        entry->value = info;
 | 
						|
        entry->next = prop_list;
 | 
						|
        prop_list = entry;
 | 
						|
    }
 | 
						|
 | 
						|
    object_unref(obj);
 | 
						|
 | 
						|
    return prop_list;
 | 
						|
}
 | 
						|
 | 
						|
ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename,
 | 
						|
                                             Error **errp)
 | 
						|
{
 | 
						|
    ObjectClass *klass;
 | 
						|
    Object *obj = NULL;
 | 
						|
    ObjectProperty *prop;
 | 
						|
    ObjectPropertyIterator iter;
 | 
						|
    ObjectPropertyInfoList *prop_list = NULL;
 | 
						|
 | 
						|
    klass = object_class_by_name(typename);
 | 
						|
    if (klass == NULL) {
 | 
						|
        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
 | 
						|
                  "Class '%s' not found", typename);
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    klass = object_class_dynamic_cast(klass, TYPE_OBJECT);
 | 
						|
    if (klass == NULL) {
 | 
						|
        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_OBJECT);
 | 
						|
        return NULL;
 | 
						|
    }
 | 
						|
 | 
						|
    if (object_class_is_abstract(klass)) {
 | 
						|
        object_class_property_iter_init(&iter, klass);
 | 
						|
    } else {
 | 
						|
        obj = object_new(typename);
 | 
						|
        object_property_iter_init(&iter, obj);
 | 
						|
    }
 | 
						|
    while ((prop = object_property_iter_next(&iter))) {
 | 
						|
        ObjectPropertyInfo *info;
 | 
						|
        ObjectPropertyInfoList *entry;
 | 
						|
 | 
						|
        info = g_malloc0(sizeof(*info));
 | 
						|
        info->name = g_strdup(prop->name);
 | 
						|
        info->type = g_strdup(prop->type);
 | 
						|
        info->has_description = !!prop->description;
 | 
						|
        info->description = g_strdup(prop->description);
 | 
						|
 | 
						|
        entry = g_malloc0(sizeof(*entry));
 | 
						|
        entry->value = info;
 | 
						|
        entry->next = prop_list;
 | 
						|
        prop_list = entry;
 | 
						|
    }
 | 
						|
 | 
						|
    object_unref(obj);
 | 
						|
 | 
						|
    return prop_list;
 | 
						|
}
 | 
						|
 | 
						|
void qmp_object_add(QDict *qdict, QObject **ret_data, Error **errp)
 | 
						|
{
 | 
						|
    QObject *props;
 | 
						|
    QDict *pdict;
 | 
						|
 | 
						|
    props = qdict_get(qdict, "props");
 | 
						|
    if (props) {
 | 
						|
        pdict = qobject_to(QDict, props);
 | 
						|
        if (!pdict) {
 | 
						|
            error_setg(errp, QERR_INVALID_PARAMETER_TYPE, "props", "dict");
 | 
						|
            return;
 | 
						|
        }
 | 
						|
        qobject_ref(pdict);
 | 
						|
        qdict_del(qdict, "props");
 | 
						|
        qdict_join(qdict, pdict, false);
 | 
						|
        if (qdict_size(pdict) != 0) {
 | 
						|
            error_setg(errp, "Option in 'props' conflicts with top level");
 | 
						|
            qobject_unref(pdict);
 | 
						|
            return;
 | 
						|
        }
 | 
						|
        qobject_unref(pdict);
 | 
						|
    }
 | 
						|
 | 
						|
    user_creatable_add_dict(qdict, false, errp);
 | 
						|
}
 | 
						|
 | 
						|
void qmp_object_del(const char *id, Error **errp)
 | 
						|
{
 | 
						|
    user_creatable_del(id, errp);
 | 
						|
}
 |