Try writing zeroes to a FUSE export while allowing the area to be
unmapped; block/file-posix.c generally implements writing zeroes with
BDRV_REQ_MAY_UNMAP ('write -zu') by calling fallocate(PUNCH_HOLE).  This
used to lead to a blk_pdiscard() in the FUSE export, which may or may
not lead to the area being zeroed.  HEAD^ fixed this to use
blk_pwrite_zeroes() instead (again with BDRV_REQ_MAY_UNMAP), so verify
that running `qemu-io 'write -zu'` on a FUSE exports always results in
zeroes being written.
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230227104725.33511-3-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
		
	
		
			
				
	
	
		
			210 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			210 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
QA output created by 308
 | 
						|
=== Set up ===
 | 
						|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | 
						|
wrote 67108864/67108864 bytes at offset 0
 | 
						|
64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
{'execute': 'qmp_capabilities'}
 | 
						|
{"return": {}}
 | 
						|
{'execute': 'blockdev-add',
 | 
						|
      'arguments': {
 | 
						|
          'driver': 'file',
 | 
						|
          'node-name': 'node-protocol',
 | 
						|
          'filename': 'TEST_DIR/t.IMGFMT'
 | 
						|
      } }
 | 
						|
{"return": {}}
 | 
						|
{'execute': 'blockdev-add',
 | 
						|
      'arguments': {
 | 
						|
          'driver': 'IMGFMT',
 | 
						|
          'node-name': 'node-format',
 | 
						|
          'file': 'node-protocol'
 | 
						|
      } }
 | 
						|
{"return": {}}
 | 
						|
 | 
						|
=== Mountpoint not present ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-err',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | 
						|
          } }
 | 
						|
{"error": {"class": "GenericError", "desc": "Failed to stat 'TEST_DIR/t.IMGFMT.fuse': No such file or directory"}}
 | 
						|
 | 
						|
=== Mountpoint is a directory ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-err',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | 
						|
          } }
 | 
						|
{"error": {"class": "GenericError", "desc": "'TEST_DIR/t.IMGFMT.fuse' is not a regular file"}}
 | 
						|
 | 
						|
=== Mountpoint is a regular file ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-mp',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
Images are identical.
 | 
						|
Permissions pre-chmod: 400
 | 
						|
chmod: changing permissions of 'TEST_DIR/t.IMGFMT.fuse': Read-only file system
 | 
						|
Permissions post-+w: 400
 | 
						|
Permissions post-+x: 500
 | 
						|
 | 
						|
=== Mount over existing file ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-img',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
Images are identical.
 | 
						|
 | 
						|
=== Double export ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-err',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | 
						|
          } }
 | 
						|
{"error": {"class": "GenericError", "desc": "There already is a FUSE export on 'TEST_DIR/t.IMGFMT.fuse'"}}
 | 
						|
 | 
						|
=== Remove export ===
 | 
						|
virtual size: 64 MiB (67108864 bytes)
 | 
						|
{'execute': 'block-export-del',
 | 
						|
          'arguments': {
 | 
						|
              'id': 'export-mp'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | 
						|
virtual size: 0 B (0 bytes)
 | 
						|
 | 
						|
=== Writable export ===
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-mp',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
Writing to read-only export failed: OK
 | 
						|
wrote 65536/65536 bytes at offset 1048576
 | 
						|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
wrote 65536/65536 bytes at offset 1048576
 | 
						|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
 | 
						|
=== Resizing exports ===
 | 
						|
{'execute': 'block-export-del',
 | 
						|
          'arguments': {
 | 
						|
              'id': 'export-mp'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | 
						|
{'execute': 'block-export-del',
 | 
						|
          'arguments': {
 | 
						|
              'id': 'export-img'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-img"}}
 | 
						|
{'execute': 'blockdev-del',
 | 
						|
      'arguments': {
 | 
						|
          'node-name': 'node-format'
 | 
						|
      } }
 | 
						|
{"return": {}}
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-mp',
 | 
						|
              'node-name': 'node-protocol',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
 | 
						|
--- Try growing non-growable export ---
 | 
						|
(OK: Lengths of export and original are the same)
 | 
						|
dd: error writing 'TEST_DIR/t.IMGFMT.fuse': Input/output error
 | 
						|
1+0 records in
 | 
						|
0+0 records out
 | 
						|
 | 
						|
--- Resize export ---
 | 
						|
(OK: Lengths of export and original are the same)
 | 
						|
OK: Post-truncate image size is as expected
 | 
						|
OK: Disk usage grew with fallocate
 | 
						|
 | 
						|
--- Try growing growable export ---
 | 
						|
{'execute': 'block-export-del',
 | 
						|
          'arguments': {
 | 
						|
              'id': 'export-mp'
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export-mp',
 | 
						|
              'node-name': 'node-protocol',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true, 'growable': true
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
65536+0 records in
 | 
						|
65536+0 records out
 | 
						|
(OK: Lengths of export and original are the same)
 | 
						|
OK: Post-grow image size is as expected
 | 
						|
 | 
						|
--- Shrink export ---
 | 
						|
(OK: Lengths of export and original are the same)
 | 
						|
OK: Post-truncate image size is as expected
 | 
						|
 | 
						|
=== Tear down ===
 | 
						|
{'execute': 'quit'}
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | 
						|
 | 
						|
=== Compare copy with original ===
 | 
						|
Images are identical.
 | 
						|
 | 
						|
=== Writing zeroes while unmapping ===
 | 
						|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | 
						|
wrote 67108864/67108864 bytes at offset 0
 | 
						|
64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
{'execute': 'qmp_capabilities'}
 | 
						|
{"return": {}}
 | 
						|
{'execute': 'blockdev-add',
 | 
						|
      'arguments': {
 | 
						|
          'driver': 'IMGFMT',
 | 
						|
          'node-name': 'node-format',
 | 
						|
          'file': {
 | 
						|
              'driver': 'file',
 | 
						|
              'filename': 'TEST_DIR/t.IMGFMT'
 | 
						|
          }
 | 
						|
      } }
 | 
						|
{"return": {}}
 | 
						|
{'execute': 'block-export-add',
 | 
						|
          'arguments': {
 | 
						|
              'type': 'fuse',
 | 
						|
              'id': 'export',
 | 
						|
              'node-name': 'node-format',
 | 
						|
              'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true
 | 
						|
          } }
 | 
						|
{"return": {}}
 | 
						|
wrote 67108864/67108864 bytes at offset 0
 | 
						|
64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
read 67108864/67108864 bytes at offset 0
 | 
						|
64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
{'execute': 'quit'}
 | 
						|
{"return": {}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
 | 
						|
{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export"}}
 | 
						|
read 67108864/67108864 bytes at offset 0
 | 
						|
64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | 
						|
*** done
 |