In my "build everything" tree, changing hw/qdev-properties.h triggers a recompile of some 2700 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Many places including hw/qdev-properties.h (directly or via hw/qdev.h) actually need only hw/qdev-core.h. Include hw/qdev-core.h there instead. hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h and hw/qdev-properties.h, which in turn includes hw/qdev-core.h. Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h. While there, delete a few superfluous inclusions of hw/qdev-core.h. Touching hw/qdev-properties.h now recompiles some 1200 objects. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: "Daniel P. Berrangé" <berrange@redhat.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190812052359.30071-22-armbru@redhat.com>
		
			
				
	
	
		
			39 lines
		
	
	
		
			893 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			39 lines
		
	
	
		
			893 B
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU NE2000 emulation -- isa bus windup
 | 
						|
 *
 | 
						|
 * Copyright (c) 2003-2004 Fabrice Bellard
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef HW_NET_NE2000_ISA_H
 | 
						|
#define HW_NET_NE2000_ISA_H
 | 
						|
 | 
						|
#include "hw/isa/isa.h"
 | 
						|
#include "hw/qdev-properties.h"
 | 
						|
#include "net/net.h"
 | 
						|
 | 
						|
#define TYPE_ISA_NE2000 "ne2k_isa"
 | 
						|
 | 
						|
static inline ISADevice *isa_ne2000_init(ISABus *bus, int base, int irq,
 | 
						|
                                         NICInfo *nd)
 | 
						|
{
 | 
						|
    ISADevice *d;
 | 
						|
 | 
						|
    qemu_check_nic_model(nd, "ne2k_isa");
 | 
						|
 | 
						|
    d = isa_try_create(bus, TYPE_ISA_NE2000);
 | 
						|
    if (d) {
 | 
						|
        DeviceState *dev = DEVICE(d);
 | 
						|
 | 
						|
        qdev_prop_set_uint32(dev, "iobase", base);
 | 
						|
        qdev_prop_set_uint32(dev, "irq",    irq);
 | 
						|
        qdev_set_nic_properties(dev, nd);
 | 
						|
        qdev_init_nofail(dev);
 | 
						|
    }
 | 
						|
    return d;
 | 
						|
}
 | 
						|
 | 
						|
#endif
 |