The I/O sampling rate range is enforced to 5000 to 45000HZ according to commita2cd86a9. Setting I/O sampling rate with command 41h/42h, a guest user can break this assumption and trigger an assertion in audio_calloc via command 0xd4. This patch restricts the I/O sampling rate range for command 41h/42h. Fixes:85571bc741("audio merge (malc)") Signed-off-by: Qiang Liu <cyruscyliu@gmail.com> Message-Id: <1624502687-5214-1-git-send-email-cyruscyliu@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
		
			
				
	
	
		
			70 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			70 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QTest fuzzer-generated testcase for sb16 audio device
 | 
						|
 *
 | 
						|
 * Copyright (c) 2021 Philippe Mathieu-Daudé <f4bug@amsat.org>
 | 
						|
 *
 | 
						|
 * SPDX-License-Identifier: GPL-2.0-or-later
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "libqos/libqtest.h"
 | 
						|
 | 
						|
/*
 | 
						|
 * This used to trigger the assert in audio_calloc
 | 
						|
 * https://bugs.launchpad.net/qemu/+bug/1910603
 | 
						|
 */
 | 
						|
static void test_fuzz_sb16_0x1c(void)
 | 
						|
{
 | 
						|
    QTestState *s = qtest_init("-M q35 -display none "
 | 
						|
                               "-device sb16,audiodev=snd0 "
 | 
						|
                               "-audiodev none,id=snd0");
 | 
						|
    qtest_outw(s, 0x22c, 0x41);
 | 
						|
    qtest_outb(s, 0x22c, 0x00);
 | 
						|
    qtest_outw(s, 0x22c, 0x1004);
 | 
						|
    qtest_outw(s, 0x22c, 0x001c);
 | 
						|
    qtest_quit(s);
 | 
						|
}
 | 
						|
 | 
						|
static void test_fuzz_sb16_0x91(void)
 | 
						|
{
 | 
						|
    QTestState *s = qtest_init("-M pc -display none "
 | 
						|
                               "-device sb16,audiodev=none "
 | 
						|
                               "-audiodev id=none,driver=none");
 | 
						|
    qtest_outw(s, 0x22c, 0xf141);
 | 
						|
    qtest_outb(s, 0x22c, 0x00);
 | 
						|
    qtest_outb(s, 0x22c, 0x24);
 | 
						|
    qtest_outb(s, 0x22c, 0x91);
 | 
						|
    qtest_quit(s);
 | 
						|
}
 | 
						|
 | 
						|
/*
 | 
						|
 * This used to trigger the assert in audio_calloc
 | 
						|
 * through command 0xd4
 | 
						|
 */
 | 
						|
static void test_fuzz_sb16_0xd4(void)
 | 
						|
{
 | 
						|
    QTestState *s = qtest_init("-M pc -display none "
 | 
						|
                               "-device sb16,audiodev=none "
 | 
						|
                               "-audiodev id=none,driver=none");
 | 
						|
    qtest_outb(s, 0x22c, 0x41);
 | 
						|
    qtest_outb(s, 0x22c, 0x00);
 | 
						|
    qtest_outb(s, 0x22c, 0x14);
 | 
						|
    qtest_outb(s, 0x22c, 0xd4);
 | 
						|
    qtest_quit(s);
 | 
						|
}
 | 
						|
 | 
						|
int main(int argc, char **argv)
 | 
						|
{
 | 
						|
    const char *arch = qtest_get_arch();
 | 
						|
 | 
						|
    g_test_init(&argc, &argv, NULL);
 | 
						|
 | 
						|
   if (strcmp(arch, "i386") == 0) {
 | 
						|
        qtest_add_func("fuzz/test_fuzz_sb16/1c", test_fuzz_sb16_0x1c);
 | 
						|
        qtest_add_func("fuzz/test_fuzz_sb16/91", test_fuzz_sb16_0x91);
 | 
						|
        qtest_add_func("fuzz/test_fuzz_sb16/d4", test_fuzz_sb16_0xd4);
 | 
						|
   }
 | 
						|
 | 
						|
   return g_test_run();
 | 
						|
}
 |