In my "build everything" tree, changing hw/irq.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). hw/hw.h supposedly includes it for convenience. Several other headers include it just to get qemu_irq and.or qemu_irq_handler. Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to qemu/typedefs.h, and then include hw/irq.h only where it's still needed. Touching it now recompiles only some 500 objects. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20190812052359.30071-13-armbru@redhat.com>
		
			
				
	
	
		
			37 lines
		
	
	
		
			846 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			37 lines
		
	
	
		
			846 B
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef HW_ETRAXFS_DMA_H
 | 
						|
#define HW_ETRAXFS_DMA_H
 | 
						|
 | 
						|
#include "exec/hwaddr.h"
 | 
						|
 | 
						|
struct dma_context_metadata {
 | 
						|
	/* data descriptor md */
 | 
						|
	uint16_t metadata;
 | 
						|
};
 | 
						|
 | 
						|
struct etraxfs_dma_client
 | 
						|
{
 | 
						|
	/* DMA controller. */
 | 
						|
	int channel;
 | 
						|
	void *ctrl;
 | 
						|
 | 
						|
	/* client.  */
 | 
						|
	struct {
 | 
						|
		int (*push)(void *opaque, unsigned char *buf,
 | 
						|
		            int len, bool eop);
 | 
						|
		void (*pull)(void *opaque);
 | 
						|
		void (*metadata_push)(void *opaque,
 | 
						|
		                      const struct dma_context_metadata *md);
 | 
						|
		void *opaque;
 | 
						|
	} client;
 | 
						|
};
 | 
						|
 | 
						|
void *etraxfs_dmac_init(hwaddr base, int nr_channels);
 | 
						|
void etraxfs_dmac_connect(void *opaque, int channel, qemu_irq *line,
 | 
						|
			  int input);
 | 
						|
void etraxfs_dmac_connect_client(void *opaque, int c, 
 | 
						|
				 struct etraxfs_dma_client *cl);
 | 
						|
int etraxfs_dmac_input(struct etraxfs_dma_client *client, 
 | 
						|
		       void *buf, int len, int eop);
 | 
						|
 | 
						|
#endif
 |