Merge pull request #474 from stevvooe/goroutine-leak-notifications
Address possible goroutine leak in notification library
This commit is contained in:
commit
3283ef1949
@ -53,6 +53,7 @@ type httpStatusListener interface {
|
||||
func (hs *httpSink) Write(events ...Event) error {
|
||||
hs.mu.Lock()
|
||||
defer hs.mu.Unlock()
|
||||
defer hs.client.Transport.(*headerRoundTripper).CloseIdleConnections()
|
||||
|
||||
if hs.closed {
|
||||
return ErrSinkClosed
|
||||
@ -83,6 +84,7 @@ func (hs *httpSink) Write(events ...Event) error {
|
||||
|
||||
return fmt.Errorf("%v: error posting: %v", hs, err)
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
|
||||
// The notifier will treat any 2xx or 3xx response as accepted by the
|
||||
// endpoint.
|
||||
|
Loading…
x
Reference in New Issue
Block a user