From 34d1494c7fe484a4c796bd1984da38c852fb3ad1 Mon Sep 17 00:00:00 2001
From: Doug Davis <dug@us.ibm.com>
Date: Mon, 20 Apr 2015 14:09:41 -0700
Subject: [PATCH] Make .docker dir have 0700 perms not 0600

Thanks to @dmcgowan for noticing.

Added a testcase to make sure Save() can create the dir and then
read from it.

Signed-off-by: Doug Davis <dug@us.ibm.com>
---
 docs/auth.go             |  2 +-
 docs/config_file_test.go | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/docs/auth.go b/docs/auth.go
index bccf58fc..ef4985ab 100644
--- a/docs/auth.go
+++ b/docs/auth.go
@@ -261,7 +261,7 @@ func (configFile *ConfigFile) Save() error {
 		return err
 	}
 
-	if err := os.MkdirAll(filepath.Dir(configFile.filename), 0600); err != nil {
+	if err := os.MkdirAll(filepath.Dir(configFile.filename), 0700); err != nil {
 		return err
 	}
 
diff --git a/docs/config_file_test.go b/docs/config_file_test.go
index 9abb8ee9..6f8bd74f 100644
--- a/docs/config_file_test.go
+++ b/docs/config_file_test.go
@@ -31,6 +31,28 @@ func TestMissingFile(t *testing.T) {
 	}
 }
 
+func TestSaveFileToDirs(t *testing.T) {
+	tmpHome, _ := ioutil.TempDir("", "config-test")
+
+	tmpHome += "/.docker"
+
+	config, err := LoadConfig(tmpHome)
+	if err != nil {
+		t.Fatalf("Failed loading on missing file: %q", err)
+	}
+
+	// Now save it and make sure it shows up in new form
+	err = config.Save()
+	if err != nil {
+		t.Fatalf("Failed to save: %q", err)
+	}
+
+	buf, err := ioutil.ReadFile(filepath.Join(tmpHome, CONFIGFILE))
+	if !strings.Contains(string(buf), `"auths":`) {
+		t.Fatalf("Should have save in new form: %s", string(buf))
+	}
+}
+
 func TestEmptyFile(t *testing.T) {
 	tmpHome, _ := ioutil.TempDir("", "config-test")
 	fn := filepath.Join(tmpHome, CONFIGFILE)