fcrozat/distribution
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

digestset: refine some words on unit test

Browse Source 
1. when lookup an entry which is missing, it should say NotFound.
2. when add duplicated entry, the entries size should be increased.
3. when add entry which has different algorithm, it should be allowed.

Signed-off-by: zhouhaibing089 <zhouhaibing089@gmail.com>
This commit is contained in:
zhouhaibing089 2017-10-31 16:33:36 +08:00
parent 3800056b88
commit f74613907d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
digestset/set_test.go
View File

@ -51,7 +51,7 @@ func TestLookup(t *testing.T) {
dgst, err = dset.Lookup("9876") dgst, err = dset.Lookup("9876")
if err == nil { if err == nil {
t.Fatal("Expected ambiguous error looking up: 9876") t.Fatal("Expected not found error looking up: 9876")
} }
if err != ErrDigestNotFound { if err != ErrDigestNotFound {
t.Fatal(err) t.Fatal(err)
@ -118,7 +118,7 @@ func TestAddDuplication(t *testing.T) {
} }
if len(dset.entries) != 8 { if len(dset.entries) != 8 {
t.Fatal("Duplicate digest insert allowed") t.Fatal("Duplicate digest insert should not increase entries size")
} }
if err := dset.Add(digest.Digest("sha384:123451111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111")); err != nil { if err := dset.Add(digest.Digest("sha384:123451111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111")); err != nil {
@ -126,7 +126,7 @@ func TestAddDuplication(t *testing.T) {
} }
if len(dset.entries) != 9 { if len(dset.entries) != 9 {
t.Fatal("Insert with different algorithm not allowed") t.Fatal("Insert with different algorithm should be allowed")
} }
} }