Richard Scothern
2f2875e8db
Merge pull request #1582 from aaronlehmann/garbagecollect-errors
...
garbagecollect: Clean up errors
2016-03-30 14:29:27 -07:00
Aaron Lehmann
59ef6d2d40
garbagecollect: Clean up errors
...
- Clean up error messages
- Add a missing error check on the result of blobService.Enumerate.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-03-30 11:35:24 -07:00
Stefan Majewsky
b015bf0676
don't swallow errors in Swift driver's GetContent()
...
In 000dec3c6f
, which was only intended to
be a refactoring commit, the behavior of this block subtly changed so
that unknown types of errors would be swallowed instead of propagated.
I noticed this while investigating an error similar to #1539 aka
docker/docker#21290 . It appears that during GetContent() for a
hashstate, the Swift proxy produces an error. Since this error was
silently swallowed, an empty []byte is used to restart the hash, then
producing the digest of the empty string instead of the layer's digest.
This PR will not fix the issue, but it should make the actual error more
visible by propagating it into `blobWriter#resumeDigest' and
'blobWriter#validateBlob', respectively.
Signed-off-by: Stefan Majewsky <stefan.majewsky@sap.com>
2016-03-30 16:11:29 +02:00
Stephen Day
432889df67
Merge pull request #1546 from arschles/doc-storage
...
Add documentation for how to register new StorageDrivers
2016-03-29 15:58:51 -07:00
Aaron Schlesinger
091ad89197
Remove the example
...
Instead, direct users to the one in the factory package
Signed-off-by: Aaron Schlesinger <aschlesinger@deis.com>
2016-03-29 14:42:28 -07:00
Aaron Schlesinger
0f09bcd16a
Add documentation for how to register new StorageDrivers
...
This commit adds context-specific documentation on StorageDriver,
StorageDriverFactory, and the factory’s Register func, explaining how
the internal registration mechanism should be used.
This documentation follows from the thread starting at
https://github.com/deis/builder/pull/262/files#r56720200 .
cc/ @stevvooe
Signed-off-by: Aaron Schlesinger <aschlesinger@deis.com>
2016-03-29 14:42:19 -07:00
Tony Holdstock-Brown
d52cbf923c
utulize config log format within gc
...
Signed-off-by: Tony Holdstock-Brown <tony@docker.com>
2016-03-24 14:29:43 -07:00
Richard Scothern
0ef5587b76
Merge pull request #1522 from RichardScothern/tag-events
...
Send tag events to notification listeners
2016-03-23 16:41:29 -07:00
Stephen Day
0b372266b4
Merge pull request #1491 from RichardScothern/relative-url
...
Return relative URLs
2016-03-23 16:19:39 -07:00
Richard Scothern
3dd506d896
Enable URLs returned from the registry to be configured as relative.
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-03-23 15:14:32 -07:00
Richard Scothern
f93d166068
Propogate tag as a functional argument into the notification system to attach
...
tags to manifest push and pull event notifications.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-03-23 14:57:52 -07:00
Richard Scothern
96c57c4725
Merge pull request #1547 from jzwlqx/issue1535
...
fix manifest revision search, closes #1535
2016-03-21 16:01:16 -07:00
姜继忠
5f38f0b1fe
fix manifest revision search, closes #1535
...
Signed-off-by: 姜继忠 <jizhong.jiangjz@alibaba-inc.com>
2016-03-19 19:11:25 +08:00
Derek McGowan
71d808de07
Merge pull request #1542 from runcom/typed-errors
...
registry: client: auth: type errors
2016-03-18 10:37:55 -07:00
Antonio Murdaca
e6b317f94f
registry: client: auth: type errors
...
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2016-03-18 09:34:50 +01:00
Richard Scothern
461816a8d2
Merge pull request #1531 from aaronlehmann/empty-errors-slice
...
Don't return empty errcode.Errors slices
2016-03-17 10:46:51 -07:00
Richard Scothern
22cab6d148
Merge pull request #1538 from runcom/body-leaks
...
registry: client: repository: close response body
2016-03-16 15:58:22 -07:00
Antonio Murdaca
20bba4025a
registry: client: repository: close response body
...
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2016-03-16 19:53:17 +01:00
Richard Scothern
e7ad3ced86
Merge pull request #1532 from RichardScothern/azure-error-types
...
Update missing blob error checking with latest Azure API
2016-03-15 10:08:36 -07:00
Aaron Lehmann
9638c7644e
Include status code in UnexpectedHTTPResponseError
...
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-03-15 09:03:56 -07:00
Richard Scothern
13adc62fae
Merge pull request #1502 from RichardScothern/auth-url-endpoints
...
URL parse auth endpoints to normalize hostname to lowercase.
2016-03-14 16:28:24 -07:00
Richard Scothern
98140ca0ab
Update missing blob error checking with latest Azure API
...
Signed-off-by: Richard Scothern <richard.scothern@docker.com>
2016-03-14 15:59:03 -07:00
Aaron Lehmann
c94c2a47a3
Don't return empty errcode.Errors slices
...
If this slice ends up empty after parsing the HTTP response body, it
means the body is not well-formed. We've probably encountered an error
message produced by something that uses a different JSON schema, or
an error that just happens to validate as JSON.
An empty errcode.Errors slice is not a very useful thing to return,
since its Error() output is just `<nil>`. Detect this case, and instend
return an UnexpectedHTTPResponseError.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-03-14 10:27:01 -07:00
Brian Bland
1d5d54978a
Merge pull request #1523 from matt-duch/master
...
registry/storage/driver/s3-aws kms support
2016-03-11 16:14:46 -08:00
Matt Duch
789c90ac42
registry/storage/driver/s3-aws kms support
...
Signed-off-by: Matt Duch <matt@learnmetrics.com>
2016-03-11 17:19:01 -06:00
Brian Bland
4c2edee417
Merge pull request #1438 from BrianBland/newStorageDriverWriter
...
Adds new StorageDriver.FileWriter interface
2016-03-11 15:06:07 -08:00
Brian Bland
eea043dc7b
Removes ceph rados driver in favor of Swift API gateway support
...
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-03-10 16:49:08 -08:00
Brian Bland
1d1d92469d
Merge pull request #1512 from kmala/master
...
Added support to specifiy custom endpoint
2016-03-10 13:48:59 -08:00
Keerthan Mala
19cfa36ec8
Added support to specifiy custom endpoint
...
Signed-off-by: Keerthan Reddy Mala <keerthan.mala@gmail.com>
2016-03-09 16:12:20 -07:00
Olivier Gambier
fecac1a605
Merge pull request #1521 from dmcgowan/oauth-client-id-on-get
...
Add client ID to token fetch to GET endpoint
2016-03-09 13:40:47 -08:00
Derek McGowan
259ef42c8c
Add client ID to token fetch to GET endpoint
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-03-09 12:44:55 -08:00
Brian Bland
490a2f5a55
Updates Swift driver to support new storagedriver.FileWriter interface
...
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-03-08 16:38:39 -08:00
Li Yi
5b48c81545
Support FileWriter interface for OSS storage driver
...
Change-Id: Ie5533ad85f944800499ca1040fd67bf1378815e0
Signed-off-by: Li Yi <denverdino@gmail.com>
2016-03-08 16:38:39 -08:00
Arthur Baars
9432b18e30
Storagedriver: GCS: add chunksize parameter
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-03-08 16:38:39 -08:00
Arthur Baars
115a6e5803
Storagedriver: GCS: implement resumable uploads
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-03-08 16:38:39 -08:00
Arthur Baars
34891eb7ab
StorageDriver: Testsuite: call Close before getting Size
...
Signed-off-by: Arthur Baars <arthur@semmle.com>
2016-03-08 16:38:38 -08:00
Brian Bland
c69c8a3286
Adds new storagedriver.FileWriter interface
...
Updates registry storage code to use this for better resumable writes.
Implements this interface for the following drivers:
+ Inmemory
+ Filesystem
+ S3
+ Azure
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-03-08 16:37:44 -08:00
Olivier Gambier
7adddecf0b
Merge pull request #1517 from aaronlehmann/fix-2-misspellings
...
Fix two misspellings in source code comments
2016-03-08 15:25:09 -08:00
Aaron Lehmann
5ca3b61609
Fix two misspellings in source code comments
...
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-03-08 15:13:24 -08:00
Brian Bland
6ef2280478
Merge pull request #1514 from BrianBland/s3awsParameterParsing
...
[driver/s3aws] Update s3aws driver parameter parsing to match s3goamz
2016-03-07 16:13:26 -08:00
Richard Scothern
e09891e2cf
URL parse auth endpoints to normalize hostname to lowercase.
...
It is possible for a middlebox to lowercase the URL at somepoint causing a
lookup in the auth challenges table to fail. Lowercase hostname before
using as keys to challenge map.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-03-07 14:08:21 -08:00
Brian Bland
2494c28e1f
[driver/s3aws] Update s3aws driver parameter parsing to match s3goamz
...
Mirrors changes from #1414 into the newer driver
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-03-07 11:52:34 -08:00
Aaron Lehmann
83b3d93ce3
Merge pull request #1511 from dmcgowan/fix-oauth-cross-repo-push
...
Fix oauth cross repository push
2016-03-04 15:29:08 -08:00
Derek McGowan
c536ae90a8
Fix oauth cross repository push
...
Cross repository push tokens were not being cached and could not be used,
now any returned token will be used and the caching is hidden in the getToken function.
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-03-04 15:13:27 -08:00
Aaron Lehmann
858a04160c
Merge pull request #1510 from dmcgowan/oauth-offline-access
...
Add offline token option
2016-03-04 14:47:48 -08:00
Derek McGowan
e0420f4045
Add offline token option
...
Login needs to add an offline token flag to ensure a refresh token is returned by the token endpoint.
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-03-04 14:32:51 -08:00
Richard Scothern
6d3a70430b
Merge pull request #1475 from dmcgowan/oauth-registry-client
...
Add oauth support to registry client auth
2016-03-04 11:51:53 -08:00
Derek McGowan
6a6c22e2b9
Add options struct to initialize handler
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-03-04 11:32:48 -08:00
Derek McGowan
f49bf18768
Fetch token by credentials and refresh token
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-03-04 00:34:17 -08:00
Richard Scothern
becdd83131
Merge pull request #1388 from aibaars/gcs-simplify-move
...
StorageDriver: GCS: remove support for directory Moves
2016-03-03 10:20:51 -08:00