Commit Graph

4613 Commits

Author SHA1 Message Date
Rober Morales-Chaparro
4f173262e4 patch-1 - adding more info to the error message
Signed-off-by: Rober Morales-Chaparro <rober.morales@rstor.io>
Signed-off-by: Rober Morales-Chaparro <rober.morales@ebury.com>
2021-11-24 15:55:22 +01:00
Rober Morales-Chaparro
579107cf2e Improve error message in case invalid env var found
If you set an env var with non-yaml content but accidentally collides with a possible configuration env var,...

The current error is

```configuration error: error parsing /etc/docker/registry/config.yml: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `tcp://1...` into configuration.Parameters```

With this change we can see at least which is the problematic env var.

Some orchestrators such as docker-compose set env vars on top on user env vars, so debugging can be tricky if you are not passing vars, and the error is pointing you to a problably valid config file.

Signed-off-by: Rober Morales-Chaparro <rober@rstor.io>
Signed-off-by: Rober Morales-Chaparro <rober.morales@ebury.com>
2021-11-24 15:55:22 +01:00
Milos Gajdos
41a0452eea
Merge pull request from GHSA-qq97-vm5h-rrhg
manifest: validate document type before unmarshal
2021-11-23 19:16:40 +00:00
Milos Gajdos
a29a3c99a6
Merge pull request #3534 from thaJeztah/bump_oci_specs 2021-11-18 08:35:04 +00:00
João Pereira
2ccf55b8c4
Merge pull request #3529 from wy65701436/fix-g404 2021-11-18 08:15:21 +00:00
Sebastiaan van Stijn
6fbba6a99b
go.mod: github.com/opencontainers/image-spec v1.0.2
- Bring mediaType out of reserved status
- specs-go: adding mediaType to the index and manifest structures

full diff: https://github.com/opencontainers/image-spec/compare/v1.0.1...v1.0.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-11-17 22:25:16 +01:00
Wang Yan
f637481c67 fix go check issues
1, Fix GoSec G404: Use of weak random number generator (math/rand instead of crypto/rand)
2, Fix Static check: ST1019: package "github.com/sirupsen/logrus" is being imported more than once

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-11-15 17:31:33 +08:00
Samuel Karp
b59a6f8279
manifest: validate document type before unmarshal
Signed-off-by: Samuel Karp <skarp@amazon.com>
2021-11-05 10:21:17 -07:00
Milos Gajdos
6248a88d03
Merge pull request #3515 from wyckster/patch-1
Fixed typo in error message
2021-11-01 14:28:38 +00:00
Ben Emamian
f2f9b29658 Update insecure.md 2021-11-01 12:53:08 +11:00
Chad Faragher
f619db7336 Fixed typo in error message
The wording of the error message had a typo (missing the word "not") that gave it the opposite meaning from the intended meaning.

Signed-off-by: Chad Faragher <wyckster@hotmail.com>
2021-10-28 14:50:04 -04:00
Wang Yan
b106d89db3
Merge pull request #3518 from wy65701436/go17
bump up golang v1.17
2021-10-28 11:15:35 +08:00
Wang Yan
3f4c558dac bump up golang v1.17
Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-10-27 15:51:30 +08:00
Peter Dave Hello
f6a54b0d29 Update most links to use https by default
Reference:

- #11640
- 430bf25958

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
2021-10-12 15:45:57 +08:00
Milos Gajdos
1563384b69
Merge pull request #3480 from CollinShoop/optimize-s3-walk
Optimize storagedriver/s3 Walk (up to ~500x) + small bugfix
2021-09-26 10:24:39 +01:00
Milos Gajdos
a60a3f69eb
Merge pull request #3411 from dmage/cloudfront-update-frequency
updatefrequency should not be saved into duration
2021-09-21 15:01:21 +01:00
Oleg Bulatov
f5709b285a updatefrequency should not be saved into duration
When updatefrequency is set and is a string, its value should be saved
into updateFrequency, and it shouldn't override duration.

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
2021-09-21 11:12:34 +02:00
Sebastiaan van Stijn
0d66aecd20 Merge pull request #13457 from thaJeztah/revert_service_accounts
Revert remove info on Service accounts
2021-09-02 23:10:58 +02:00
Sebastiaan van Stijn
7b77a24bb2 Revert "Remove info on service accounts"
This reverts commit 715959c171.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-09-02 23:00:07 +02:00
Usha Mandya
715959c171 Remove info on service accounts
Signed-off-by: Usha Mandya <usha.mandya@docker.com>
2021-09-02 11:58:42 +01:00
Sebastiaan van Stijn
582b141566 Merge pull request #13072 from ghodsizadeh/patch-1
Update deploying.md
2021-08-27 17:19:28 +02:00
Milos Gajdos
677772e08d
Merge pull request #3138 from devigned/autorest-update
chore: update azure go-autorest dependencies
2021-08-26 09:13:26 +01:00
David Justice
3e68d47da6
chore: update azure go-autorest dependencies
Signed-off-by: David Justice <david@devigned.com>
2021-08-25 13:43:18 -04:00
Wang Yan
eda4e7152a
Merge pull request #3488 from aviral26/docs
docs: update release-tool link
2021-08-24 17:27:07 +08:00
Aviral Takkar
b07018ff3d
docs: update release-tool link
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
2021-08-23 00:01:41 -07:00
Milos Gajdos
1cdeff259b
Merge pull request #3487 from justincormack/must
Change should to must in v2 spec
2021-08-20 14:00:19 +01:00
Justin Cormack
1660df4b60
Change should to must in v2 spec
We found some examples of manifests with URLs specififed that did
not provide a digest or size. This breaks the security model by allowing
the content to change, as it no longer provides a Merkle tree. This
was not intended, so explicitly disallow by tightening wording.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
2021-08-20 12:14:42 +01:00
Milos Gajdos
ecdf4b7e43
Merge pull request #3474 from thaJeztah/update_go_116
Update to go 1.16, and run CI on 1.15.x and 1.16.x
2021-08-19 08:59:46 +01:00
Collin Shoop
cf81f67a16 storagedriver/s3: Optimized Walk implementation + bugfix
Optimized S3 Walk impl by no longer listing files recursively. Overall gives a huge performance increase both in terms of runtime and S3 calls (up to ~500x).

Fixed a bug in WalkFallback where ErrSkipDir for was not handled as documented for non-directory.

Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-16 16:07:25 -04:00
Milos Gajdos
0256de4688
Merge pull request #3479 from CollinShoop/updated-s3-delete-to-handle-edge-cases
Updated s3 delete to no longer noop under a rare edge case
2021-08-16 15:40:00 +01:00
Usha Mandya
3fe6fc4dd4 Merge pull request #13352 from thaJeztah/add_missing_codehints
Add missing code-hints, and minor markdown edits
2021-08-16 12:15:19 +01:00
Sebastiaan van Stijn
072bad48b1 Add missing code-hints, and minor markdown edits
- Add missing code-hints (console, yaml)
- Consistently add an empty line after code-blocks
- Combine some examples where the output and the command were
  put in separate blocks. With the "console" code-hint, this
  is no longer nescessary.
- fix indentation in cloud/ecs-integration.md, which caused the
  numbered-list to be interrupted.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-16 12:59:23 +02:00
Sebastiaan van Stijn
9b971331af Desktop: move "docker-for-windows" to "desktop/windows"
Unifying all content related to Docker Desktop to be withing the desktop
directory.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-14 13:28:15 +02:00
Sebastiaan van Stijn
31c9a9d737 Desktop: move "docker-for-mac" to "desktop/mac"
Unifying all content related to Docker Desktop to be withing the desktop
directory.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-14 13:07:41 +02:00
Daniel Helfand
576f4fc074 fix broken link for setting up local registry with auth 2021-08-12 11:56:31 -05:00
Collin Shoop
9e873f31ec storagedriver/s3: Adding back missing import.
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 11:56:13 -04:00
Collin Shoop
e625bc7160 storagedriver/s3: Removed temporary S3 test
(cherry picked from commit ce80e98cea1d15aa2a2ab931c8b9a1161fc6e218)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 11:56:13 -04:00
Collin Shoop
dc5b77101d storagedriver/s3: Cleaning up tests
(cherry picked from commit 483ba26165ca66bcf18a1eaadf41ebe4d3bd5f85)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 11:56:13 -04:00
Collin Shoop
6da7217b99 storagedriver/s3: Optimize s3 Delete test cleanup.
(cherry picked from commit e4af4dc3a6da6da724e7cff18cf5b6da6ef2a3fd)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 11:56:13 -04:00
Collin Shoop
03f9eb3a18 storagedriver/s3: Fixed a Delete noop edgecase
Delete was not working when the subpath immediately followed the given path started with an ascii lower than "/" such as dash "-" and underscore "_" and requests no files to be deleted.

(cherry picked from commit 5d8fa0ce94b68cce70237805db92cdd8d40de282)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 11:56:13 -04:00
Collin Shoop
05a258e711 storagedriver/s3: Added Delete tests to s3_test
(cherry picked from commit 1e3b6b67a8e6d7f01307518370f0731212935d05)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
2021-08-12 10:57:24 -04:00
Sebastiaan van Stijn
a07b54eb68
Update to go 1.16, and run CI on 1.15.x and 1.16.x
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-10 12:12:28 +02:00
Usha Mandya
6ac695a6f5 Merge pull request #13299 from thaJeztah/more_copy_pasta
"console-idate" shell examples
2021-08-06 17:54:30 +01:00
Sebastiaan van Stijn
ee8c75cbd1 registry: use "console" for shell examples
This allows for easier copying of the commands, without selecting the
prompt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 17:19:57 +02:00
Justin Cormack
38ab4c606e
Merge pull request #3441 from justincormack/sargun
Propose Sargun as a maintainer
2021-08-04 11:49:54 +01:00
João Pereira
01f589cf87
Merge pull request #3450 from wy65701436/fixes-3446
use memory as the cache in test
2021-07-02 13:29:54 +01:00
Wang Yan
0f50e0388d use memory as the cache in test
Fixes #3446

Signed-off-by: Wang Yan <wangyan@vmware.com>
2021-07-02 19:41:47 +08:00
João Pereira
93ecc3f919
Merge pull request #3442 from milosgajdos/fix-readme-conformance 2021-06-30 18:57:33 +01:00
Milos Gajdos
351b260774
Fix OCI conformance workflow report and README badge
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
2021-06-30 15:37:18 +01:00
Wang Yan
3fa4e42634
Merge pull request #3448 from milosgajdos/action-job-names
Make GH workflows job names unique
2021-06-30 22:03:43 +08:00