1d33874951
Go 1.13 and up enforce import paths to be versioned if a project contains a go.mod and has released v2 or up. The current v2.x branches (and releases) do not yet have a go.mod, and therefore are still allowed to be imported with a non-versioned import path (go modules add a `+incompatible` annotation in that case). However, now that this project has a `go.mod` file, incompatible import paths will not be accepted by go modules, and attempting to use code from this repository will fail. This patch uses `v3` for the import-paths (not `v2`), because changing import paths itself is a breaking change, which means that the next release should increment the "major" version to comply with SemVer (as go modules dictate). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
137 lines
2.7 KiB
Go
137 lines
2.7 KiB
Go
package storage
|
|
|
|
import (
|
|
"regexp"
|
|
"testing"
|
|
|
|
"github.com/distribution/distribution/v3"
|
|
"github.com/distribution/distribution/v3/context"
|
|
"github.com/distribution/distribution/v3/manifest"
|
|
"github.com/distribution/distribution/v3/manifest/schema2"
|
|
"github.com/distribution/distribution/v3/registry/storage/driver/inmemory"
|
|
)
|
|
|
|
func TestVerifyManifestForeignLayer(t *testing.T) {
|
|
ctx := context.Background()
|
|
inmemoryDriver := inmemory.New()
|
|
registry := createRegistry(t, inmemoryDriver,
|
|
ManifestURLsAllowRegexp(regexp.MustCompile("^https?://foo")),
|
|
ManifestURLsDenyRegexp(regexp.MustCompile("^https?://foo/nope")))
|
|
repo := makeRepository(t, registry, "test")
|
|
manifestService := makeManifestService(t, repo)
|
|
|
|
config, err := repo.Blobs(ctx).Put(ctx, schema2.MediaTypeImageConfig, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
layer, err := repo.Blobs(ctx).Put(ctx, schema2.MediaTypeLayer, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
foreignLayer := distribution.Descriptor{
|
|
Digest: "sha256:463435349086340864309863409683460843608348608934092322395278926a",
|
|
Size: 6323,
|
|
MediaType: schema2.MediaTypeForeignLayer,
|
|
}
|
|
|
|
template := schema2.Manifest{
|
|
Versioned: manifest.Versioned{
|
|
SchemaVersion: 2,
|
|
MediaType: schema2.MediaTypeManifest,
|
|
},
|
|
Config: config,
|
|
}
|
|
|
|
type testcase struct {
|
|
BaseLayer distribution.Descriptor
|
|
URLs []string
|
|
Err error
|
|
}
|
|
|
|
cases := []testcase{
|
|
{
|
|
foreignLayer,
|
|
nil,
|
|
errMissingURL,
|
|
},
|
|
{
|
|
// regular layers may have foreign urls
|
|
layer,
|
|
[]string{"http://foo/bar"},
|
|
nil,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"file:///local/file"},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"http://foo/bar#baz"},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{""},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"https://foo/bar", ""},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"", "https://foo/bar"},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"http://nope/bar"},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"http://foo/nope"},
|
|
errInvalidURL,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"http://foo/bar"},
|
|
nil,
|
|
},
|
|
{
|
|
foreignLayer,
|
|
[]string{"https://foo/bar"},
|
|
nil,
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
m := template
|
|
l := c.BaseLayer
|
|
l.URLs = c.URLs
|
|
m.Layers = []distribution.Descriptor{l}
|
|
dm, err := schema2.FromStruct(m)
|
|
if err != nil {
|
|
t.Error(err)
|
|
continue
|
|
}
|
|
|
|
_, err = manifestService.Put(ctx, dm)
|
|
if verr, ok := err.(distribution.ErrManifestVerification); ok {
|
|
// Extract the first error
|
|
if len(verr) == 2 {
|
|
if _, ok = verr[1].(distribution.ErrManifestBlobUnknown); ok {
|
|
err = verr[0]
|
|
}
|
|
}
|
|
}
|
|
if err != c.Err {
|
|
t.Errorf("%#v: expected %v, got %v", l, c.Err, err)
|
|
}
|
|
}
|
|
}
|