55ea440428
Under certain circumstances, the use of `StorageDriver.GetContent` can result in unbounded memory allocations. In particualr, this happens when accessing a layer through the manifests endpoint. This problem is mitigated by setting a 4MB limit when using to access content that may have been accepted from a user. In practice, this means setting the limit with the use of `BlobProvider.Get` by wrapping `StorageDriver.GetContent` in a helper that uses `StorageDriver.Reader` with a `limitReader` that returns an error. When mitigating this security issue, we also noticed that the size of manifests uploaded to the registry is also unlimited. We apply similar logic to the request body of payloads that are full buffered. Signed-off-by: Stephen J Day <stephen.day@docker.com>
224 lines
6.2 KiB
Go
224 lines
6.2 KiB
Go
package storage
|
|
|
|
import (
|
|
"path"
|
|
|
|
"github.com/docker/distribution"
|
|
"github.com/docker/distribution/context"
|
|
"github.com/docker/distribution/registry/storage/driver"
|
|
"github.com/opencontainers/go-digest"
|
|
)
|
|
|
|
// blobStore implements the read side of the blob store interface over a
|
|
// driver without enforcing per-repository membership. This object is
|
|
// intentionally a leaky abstraction, providing utility methods that support
|
|
// creating and traversing backend links.
|
|
type blobStore struct {
|
|
driver driver.StorageDriver
|
|
statter distribution.BlobStatter
|
|
}
|
|
|
|
var _ distribution.BlobProvider = &blobStore{}
|
|
|
|
// Get implements the BlobReadService.Get call.
|
|
func (bs *blobStore) Get(ctx context.Context, dgst digest.Digest) ([]byte, error) {
|
|
bp, err := bs.path(dgst)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
p, err := getContent(ctx, bs.driver, bp)
|
|
if err != nil {
|
|
switch err.(type) {
|
|
case driver.PathNotFoundError:
|
|
return nil, distribution.ErrBlobUnknown
|
|
}
|
|
|
|
return nil, err
|
|
}
|
|
|
|
return p, nil
|
|
}
|
|
|
|
func (bs *blobStore) Open(ctx context.Context, dgst digest.Digest) (distribution.ReadSeekCloser, error) {
|
|
desc, err := bs.statter.Stat(ctx, dgst)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
path, err := bs.path(desc.Digest)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return newFileReader(ctx, bs.driver, path, desc.Size)
|
|
}
|
|
|
|
// Put stores the content p in the blob store, calculating the digest. If the
|
|
// content is already present, only the digest will be returned. This should
|
|
// only be used for small objects, such as manifests. This implemented as a convenience for other Put implementations
|
|
func (bs *blobStore) Put(ctx context.Context, mediaType string, p []byte) (distribution.Descriptor, error) {
|
|
dgst := digest.FromBytes(p)
|
|
desc, err := bs.statter.Stat(ctx, dgst)
|
|
if err == nil {
|
|
// content already present
|
|
return desc, nil
|
|
} else if err != distribution.ErrBlobUnknown {
|
|
context.GetLogger(ctx).Errorf("blobStore: error stating content (%v): %v", dgst, err)
|
|
// real error, return it
|
|
return distribution.Descriptor{}, err
|
|
}
|
|
|
|
bp, err := bs.path(dgst)
|
|
if err != nil {
|
|
return distribution.Descriptor{}, err
|
|
}
|
|
|
|
// TODO(stevvooe): Write out mediatype here, as well.
|
|
return distribution.Descriptor{
|
|
Size: int64(len(p)),
|
|
|
|
// NOTE(stevvooe): The central blob store firewalls media types from
|
|
// other users. The caller should look this up and override the value
|
|
// for the specific repository.
|
|
MediaType: "application/octet-stream",
|
|
Digest: dgst,
|
|
}, bs.driver.PutContent(ctx, bp, p)
|
|
}
|
|
|
|
func (bs *blobStore) Enumerate(ctx context.Context, ingester func(dgst digest.Digest) error) error {
|
|
|
|
specPath, err := pathFor(blobsPathSpec{})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = Walk(ctx, bs.driver, specPath, func(fileInfo driver.FileInfo) error {
|
|
// skip directories
|
|
if fileInfo.IsDir() {
|
|
return nil
|
|
}
|
|
|
|
currentPath := fileInfo.Path()
|
|
// we only want to parse paths that end with /data
|
|
_, fileName := path.Split(currentPath)
|
|
if fileName != "data" {
|
|
return nil
|
|
}
|
|
|
|
digest, err := digestFromPath(currentPath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return ingester(digest)
|
|
})
|
|
return err
|
|
}
|
|
|
|
// path returns the canonical path for the blob identified by digest. The blob
|
|
// may or may not exist.
|
|
func (bs *blobStore) path(dgst digest.Digest) (string, error) {
|
|
bp, err := pathFor(blobDataPathSpec{
|
|
digest: dgst,
|
|
})
|
|
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return bp, nil
|
|
}
|
|
|
|
// link links the path to the provided digest by writing the digest into the
|
|
// target file. Caller must ensure that the blob actually exists.
|
|
func (bs *blobStore) link(ctx context.Context, path string, dgst digest.Digest) error {
|
|
// The contents of the "link" file are the exact string contents of the
|
|
// digest, which is specified in that package.
|
|
return bs.driver.PutContent(ctx, path, []byte(dgst))
|
|
}
|
|
|
|
// readlink returns the linked digest at path.
|
|
func (bs *blobStore) readlink(ctx context.Context, path string) (digest.Digest, error) {
|
|
content, err := bs.driver.GetContent(ctx, path)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
linked, err := digest.Parse(string(content))
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return linked, nil
|
|
}
|
|
|
|
// resolve reads the digest link at path and returns the blob store path.
|
|
func (bs *blobStore) resolve(ctx context.Context, path string) (string, error) {
|
|
dgst, err := bs.readlink(ctx, path)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return bs.path(dgst)
|
|
}
|
|
|
|
type blobStatter struct {
|
|
driver driver.StorageDriver
|
|
}
|
|
|
|
var _ distribution.BlobDescriptorService = &blobStatter{}
|
|
|
|
// Stat implements BlobStatter.Stat by returning the descriptor for the blob
|
|
// in the main blob store. If this method returns successfully, there is
|
|
// strong guarantee that the blob exists and is available.
|
|
func (bs *blobStatter) Stat(ctx context.Context, dgst digest.Digest) (distribution.Descriptor, error) {
|
|
path, err := pathFor(blobDataPathSpec{
|
|
digest: dgst,
|
|
})
|
|
|
|
if err != nil {
|
|
return distribution.Descriptor{}, err
|
|
}
|
|
|
|
fi, err := bs.driver.Stat(ctx, path)
|
|
if err != nil {
|
|
switch err := err.(type) {
|
|
case driver.PathNotFoundError:
|
|
return distribution.Descriptor{}, distribution.ErrBlobUnknown
|
|
default:
|
|
return distribution.Descriptor{}, err
|
|
}
|
|
}
|
|
|
|
if fi.IsDir() {
|
|
// NOTE(stevvooe): This represents a corruption situation. Somehow, we
|
|
// calculated a blob path and then detected a directory. We log the
|
|
// error and then error on the side of not knowing about the blob.
|
|
context.GetLogger(ctx).Warnf("blob path should not be a directory: %q", path)
|
|
return distribution.Descriptor{}, distribution.ErrBlobUnknown
|
|
}
|
|
|
|
// TODO(stevvooe): Add method to resolve the mediatype. We can store and
|
|
// cache a "global" media type for the blob, even if a specific repo has a
|
|
// mediatype that overrides the main one.
|
|
|
|
return distribution.Descriptor{
|
|
Size: fi.Size(),
|
|
|
|
// NOTE(stevvooe): The central blob store firewalls media types from
|
|
// other users. The caller should look this up and override the value
|
|
// for the specific repository.
|
|
MediaType: "application/octet-stream",
|
|
Digest: dgst,
|
|
}, nil
|
|
}
|
|
|
|
func (bs *blobStatter) Clear(ctx context.Context, dgst digest.Digest) error {
|
|
return distribution.ErrUnsupported
|
|
}
|
|
|
|
func (bs *blobStatter) SetDescriptor(ctx context.Context, dgst digest.Digest, desc distribution.Descriptor) error {
|
|
return distribution.ErrUnsupported
|
|
}
|